From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DB5FB3AEF35 for ; Thu, 15 Jan 2026 15:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768491992; cv=none; b=dtCcb3geeer1nY+Fi1wd7garLpaBGMugPs0/5/ay+xAQYuYuq9IVsxsiplsRhBHbk2RMO3fOMrY21Xw1O35i6RB0bJ7lJHJ8MwLWtd51vEzPe/IX0VkCPiaiaq3BvhRDk8w4WfZD4GBzxmQAs+fbpA12kXzxSjhR9KI4qPowPgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768491992; c=relaxed/simple; bh=WF5hkRvw8DPNwO14QWZdmBZX7+HYifs4Ej3vKTZfVuY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GmB1x7Fju8Q66bnbQnFi73fvCz7Zb0mGNzJpAlj+0Arog3eOmpQrD/5jRI2z4bjTqCY44tCFSvfLgi/iHcjWlPpz2WzE5Edj9c6XjNSE9ng/XOkrtnOu9ZXSv/fwy72qO9N/X6jIe7ueWtQxlfudVmvffehTvtYXurMg75oVqVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 23A421515; Thu, 15 Jan 2026 07:46:23 -0800 (PST) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A76673F59E; Thu, 15 Jan 2026 07:46:28 -0800 (PST) Message-ID: <050fcf3b-d390-4692-b944-2d59a71888e4@arm.com> Date: Thu, 15 Jan 2026 15:46:27 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] fs/resctrl: Add missing kconfig entry for CONFIG_RESCTRL_ASSIGN_FIXED To: Reinette Chatre , linux-kernel@vger.kernel.org Cc: tony.luck@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, bp@alien8.de References: <20260113144952.47706-1-ben.horgan@arm.com> <4ebf839a-1d29-43ad-a90c-32f5bce999fd@intel.com> From: Ben Horgan Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Reinette, On 1/15/26 15:37, Reinette Chatre wrote: > Hi Ben, > > On 1/15/26 2:32 AM, Ben Horgan wrote: >> On 1/14/26 19:09, Reinette Chatre wrote: >>> On 1/13/26 6:49 AM, Ben Horgan wrote: >>>> The commit 3b497c3f4f04 ("fs/resctrl: Introduce the interface to display >>>> monitoring modes") introduced CONFIG_RESCTRL_ASSIGN_FIXED but did not add >>>> the kconfig entry. Add this. >>>> >>>> Also, take the opportunity ensure that any user attempt to change the >>>> assign mode fails from the resctrl code rather than delegating to the arch >>>> specific code and let the user know by adding a message in last_cmd_status. >>> >>> Why *any* attempt? Avoiding delegating to arch seems ok as a goal but this change >>> additionally changes interface with user space. Current behavior when user writes >>> existing mode to the file is to just return success. For example, if current mode >>> is "default" and user writes "default". This patch changes this behavior to fail >>> instead. Is this intended? >> >> Intended but as you point out, it would be best to accept the current >> value without error for maximum compatibility between architectures. >> I'll update the config option help text to reflect this. Was the help >> text also discussed previously? > > It is not clear to me which help text you are referring to. Could you > please point me to it? I just mean the description in Kconfig. Maybe I'm using the wrong terminology? >From this patch: help Enabled by the architecture when the counter assignment mode is not configurable. This ensures that counter assignment is not advertised as configurable and configuration attempts fail. > > Reinette Thanks, Ben