From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0220C43458 for ; Wed, 1 Jul 2026 10:53:01 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1349739.1607392 (Exim 4.92) (envelope-from ) id 1wesYa-00054o-Dz; Wed, 01 Jul 2026 10:52:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1349739.1607392; Wed, 01 Jul 2026 10:52:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wesYa-00054h-BR; Wed, 01 Jul 2026 10:52:40 +0000 Received: by outflank-mailman (input) for mailman id 1349739; Wed, 01 Jul 2026 10:52:39 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wesYZ-00054b-31 for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 10:52:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wesYY-008DJG-Fv for xen-devel@lists.xenproject.org; Wed, 01 Jul 2026 12:52:38 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a44f176-e002-0a2a0a5209dd-0a2a4501ba36-0 for ; Wed, 01 Jul 2026 12:52:38 +0200 Received: from [209.85.128.53] (helo=mail-wm1-f53.google.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6a44f176-400f-0a2a45010019-d1558035b871-3 for ; Wed, 01 Jul 2026 12:52:38 +0200 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493c2b3dc8bso2449635e9.2 for ; Wed, 01 Jul 2026 03:52:38 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47566fe448dsm16010183f8f.27.2026.07.01.03.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 03:52:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782903158; x=1783507958; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZcE6jBxr6nihgfqAzS4ZqpmQQYuTZk3PkpqYA/Nt5TU=; b=IGSdwTtF9RLZgaPaPA+2hvfZl8+1xHTv4uLZFzv4w9C86CyHd3OVI3ZxWw9hAXnEtl Tt+WLD1PmjkLVpoMjcngffWRgul2v5o2ntLNv3+bBkYvpMLnfmOp4IbdDr2Oonh2hQsa qlY6PZQ2XvGJZxhxH1b+KH36SFarmvYUJAUvIHsSmBILrd2+kVs32PDUTQfuT2HYu3TN 7p1m/XbuveKkeeS78djaSQ3wcOJun5NxaIkx13RVVhqjLJJQE4byA0C9f7WkxebCLgdh nn3CUKLhLiSwEANYmJLoah7SeQ7OdYlXhILK1o4MvzXVKh1QIdXJ/qZ9Hw6D/Azqho/X OzcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782903158; x=1783507958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZcE6jBxr6nihgfqAzS4ZqpmQQYuTZk3PkpqYA/Nt5TU=; b=TNNJwY6fXsyiXHwPidV3DAM5ca/WbBXfscltyoHlNZYqe5XuXVtOY+7UAPtvpJS8sG vB5LmNStwjT93UJIdieWUvqgZJyuSkPTMIwcRCy/TM9YarI5+QnTzLz/uxDxovPc5WBz lUPTZMAbq5JpR+gmamxzUxikyKYsFfsMB8CeD6JEf88T0aAlC/rRUAK/M2QVG/8fSO95 cRjsNHLUFCohaAWv+C+KtuczY8U5YaXYIhJmM0rTToy1gyyOuncHcxQ71x8owaWra4/x M+SVW3CaUXMgSHx/OwHSXtREcdL7IXpEQiLquWV7pJIg2XJUOd0CNnzc21i9iD58cIxG gBwA== X-Forwarded-Encrypted: i=1; AFNElJ9tqEh5zw/uTUvObD8lUBmRrTcynVsipsoM3QBinjPVmyVZ6SQ7Px+m9kGWKqWO0G4qM5LPYr0FXmA=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy0tbuMUF+S/c0p/mY9L0a5bKAmZ91xWFxnVi51mcM/LL+MNCjJ rH6N/8nwJdaPkLqUVN4qVNtLxyywpFntS0AvXnAhfzoNeM6BhYyylLuO X-Gm-Gg: AfdE7ckbzunoEc/qEZ+pcSn+NMO0pde7QjHN+2riRkYsOpvBDMgo4cnIau1OukvFp/2 di4lzaqmhTo2H2pd1i2x9eJWHT+NMmWkewD3p7YRAyyuSBLLTLsdPN7tZmxNJ319ipXRtVppJtR U4RloBa9UPrDTv+sYXMHmkzSK5HANUXjF9GdIosTsv7fNgGlOiw8PZ4Hj+J8ioqtEo7v4lnjUgL wmrcyKSAqSgoFgJi11cVCJm0YGFKwNS3OlEDsbMYWjJHJ7/+/xuQVkBBzbFyENtWnywqoIduEuE sFFN7F5mKTh0tfESjlk5eealw7Bl3xZLA1n8d/41dK2clAolkD5qYWjQtU+qlx6P9e972yTEgbP pgA/PTmcpTV6HjpjjPKLIweyi1AkCbbgfMtx8LCXWqWn7wfpO89BCKY8sN7ajoqEhQAMJYyAaKk EPX0+tBNoey3OS3tLhxzLMWSDvniISncNidQYGAhexnxVBSTC7hDjQNDVEuVQ9cfImirU= X-Received: by 2002:a05:600d:c:b0:493:8391:919a with SMTP id 5b1f17b1804b1-493c2b433dbmr16095845e9.16.1782903157864; Wed, 01 Jul 2026 03:52:37 -0700 (PDT) Message-ID: <05173913-e6e0-4602-a75d-96ce134bd2ec@gmail.com> Date: Wed, 1 Jul 2026 12:52:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 18/25] xen/riscv: introduce (de)initialization helpers for vINTC To: Jan Beulich Cc: Romain Caritey , Baptiste Le Duc , Alistair Francis , Connor Davis , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , xen-devel@lists.xenproject.org References: <109135cb-7ad6-49f4-88c7-49ffb33e0068@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <109135cb-7ad6-49f4-88c7-49ffb33e0068@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-ID: tlsNG-d62444/1782903158-826C31E0-C7E57116/10/73395122804 X-purgate-type: spam X-purgate-size: 1234 On 6/29/26 5:07 PM, Jan Beulich wrote: > On 26.06.2026 17:46, Oleksii Kurochko wrote: >> Add common helpers domain_vintc_init() and domain_vintc_deinit() to >> allocate and deallocate a virtual interrupt controller (vINTC) >> structure and initialize basic virtual interrupt controller registers. >> >> domain_vintc_deinit() isn't called at the moment as arch_domain_destroy() >> is implemented as stub at the moment. >> >> Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich Thanks. > with one more suggestion: > >> @@ -83,3 +84,37 @@ int __init make_intc_domU_node(struct kernel_info *kinfo) >> >> return vintc->init_ops->make_domu_dt_node(kinfo); >> } >> + >> +int domain_vintc_init(struct domain *d) >> +{ >> + int ret = -EOPNOTSUPP; >> + const enum intc_variant variant = intc_hw_ops->info->hw_variant; >> + >> + switch ( variant ) >> + { >> + case INTC_APLIC: >> + ret = domain_vaplic_init(d); >> + break; >> + >> + default: >> + printk("vintc (variant:%d) isn't implemented\n", variant); > > printk_once() maybe? It makes sense. I will apply your suggestions. ~ Oleksii