From: Matt Spinler <mspinler@linux.ibm.com>
To: Wim Vervoorn <wvervoorn@eltan.com>, Lei YU <mine260309@gmail.com>
Cc: Matthew Barth <msbarth@linux.ibm.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: using phosphor-dbus-monitor
Date: Thu, 11 Apr 2019 11:26:44 -0500 [thread overview]
Message-ID: <051affae-335d-37f6-35c4-544caecdd1c8@linux.ibm.com> (raw)
In-Reply-To: <39cdf20b2c8e4b528109b88bb16d3274@Eltsrv03.Eltan.local>
On 4/11/2019 8:05 AM, Wim Vervoorn wrote:
> I just found filed an issue because phosphor-dbus-monitor doesn't support "double" values this is required to make it work when dbus-sensors is used.
>
> I also made 2 pull requests to resolve this.
That's great!.
Note that OpenBMC doesn't use pull requests - we do our reviews all on
gerrit.
https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md has the details.
>
> Best regards,
>
> Wim Vervoorn
>
> -----Original Message-----
> From: Lei YU [mailto:mine260309@gmail.com]
> Sent: Thursday, April 11, 2019 2:38 PM
> To: Wim Vervoorn <wvervoorn@eltan.com>
> Cc: Matthew Barth <msbarth@linux.ibm.com>; Matt Spinler <mspinler@linux.ibm.com>; openbmc@lists.ozlabs.org
> Subject: Re: using phosphor-dbus-monitor
>
>> I just found the reason why this wasn’t working. I overlooked a typo in the interface : Sensors instead of Sensor.
> This is the sign of what needs to be improved. Either make it report error at compile time, or at least have a tool to verify the yaml.
>
>
prev parent reply other threads:[~2019-04-11 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 13:42 using phosphor-dbus-monitor Wim Vervoorn
2019-04-09 3:44 ` Lei YU
2019-04-09 7:23 ` Wim Vervoorn
2019-04-09 13:50 ` Matt Spinler
2019-04-09 13:59 ` Wim Vervoorn
2019-04-09 14:12 ` Matthew Barth
2019-04-09 14:22 ` Wim Vervoorn
2019-04-10 14:27 ` Wim Vervoorn
2019-04-11 12:38 ` Lei YU
2019-04-11 13:05 ` Wim Vervoorn
2019-04-11 16:26 ` Matt Spinler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=051affae-335d-37f6-35c4-544caecdd1c8@linux.ibm.com \
--to=mspinler@linux.ibm.com \
--cc=mine260309@gmail.com \
--cc=msbarth@linux.ibm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=wvervoorn@eltan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.