From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1993CC6FD18 for ; Tue, 25 Apr 2023 07:32:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D32B0860FC; Tue, 25 Apr 2023 09:32:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="SN7gVPej"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8F7D086172; Tue, 25 Apr 2023 09:32:11 +0200 (CEST) Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D65D78564D for ; Tue, 25 Apr 2023 09:32:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-francis@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33P7VwWR093750; Tue, 25 Apr 2023 02:31:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682407918; bh=OZsZ1eg8yk86BwM+5m9saXlnl1QchVFsbr/oNCJjLyU=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=SN7gVPejxfoDhiX2AJRjN9S6jsWzNxrofA9wzMpcXaqGUXsbWN7/qjyIm+IjKnMEW 0ivJYdAsJfLbTkKkbLBs3wWzYcSQqtSiYI4H4GqM+1qdmkXzFC2Sx57oRqHPRI4MLn 2unKG+/IOUQ3lVSb3g6aiwOw2PzNBCZubljDBqLY= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33P7Vvh5034831 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Apr 2023 02:31:57 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 25 Apr 2023 02:31:57 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 25 Apr 2023 02:31:57 -0500 Received: from [172.24.145.195] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33P7VsYj105819; Tue, 25 Apr 2023 02:31:54 -0500 Message-ID: <05206f93-9873-7bf4-7910-1892bb227253@ti.com> Date: Tue, 25 Apr 2023 13:01:53 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 11/19] am64x: dts: binman: Package tiboot3.bin, tispl.bin u-boot.img Content-Language: en-US To: Simon Glass CC: , , , , , , , , References: <20230421123203.1315330-1-n-francis@ti.com> <20230421123203.1315330-12-n-francis@ti.com> From: Neha Malcom Francis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon On 25/04/23 01:12, Simon Glass wrote: > Hi Neha, > > On Fri, 21 Apr 2023 at 06:32, Neha Malcom Francis wrote: >> >> Support added for HS and GP boot binaries for AM64x. >> >> tiboot3.bin, tispl.bin and u-boot.img: For HS-SE devices >> tiboot3.bin_fs, tispl.bin and u-boot.img: For HS-FS devices >> tiboot3.bin_unsigned, tispl.bin_unsigned, u-boot.img_unsigned: For GP >> devices >> >> Note that the bootflow followed by AM64x requires: >> >> tiboot3.bin: >> * R5 SPL >> * R5 SPL dtbs >> * sysfw >> * board-cfg >> * pm-cfg >> * sec-cfg >> * rm-cfg >> >> tispl.bin: >> * ATF >> * OPTEE >> * A53 SPL >> * A53 SPL dtbs >> >> u-boot.img: >> * A53 U-Boot >> * A53 U-Boot dtbs >> >> Signed-off-by: Neha Malcom Francis >> --- >> arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 + >> arch/arm/dts/k3-am642-r5-evm.dts | 1 + >> arch/arm/dts/k3-am64x-binman.dtsi | 569 ++++++++++++++++++++++++++ >> board/ti/am64x/Kconfig | 2 + >> 4 files changed, 574 insertions(+) >> create mode 100644 arch/arm/dts/k3-am64x-binman.dtsi > > Reviewed-by: Simon Glass > > I notice that some of the entries are optional. Do you actual make use > of this (i.e. that when they are missing binman removes the entries)? > So right now the build generates binaries for all three types: HS-FS, HS-SE and GP devices. It's not necessary for the user to provide component binaries for all three of them, say they only have GP SYSFW binaries available with them. So that was the reasoning behind putting those binaries as optional, we should not have a failed build in those cases. However binaries like DM and board-config binaries that are common between all three needs to be there so it's not optional. > Regards, > Simon -- Thanking You Neha Malcom Francis