From: Jens Axboe <axboe@kernel.dk>
To: Martin Dev <mrturtledev@gmail.com>, fio@vger.kernel.org
Subject: Re: Unlink after each loop in job
Date: Fri, 5 Aug 2016 07:50:53 -0600 [thread overview]
Message-ID: <0523eea4-0332-2b8e-a595-fd66cd6ae3de@kernel.dk> (raw)
In-Reply-To: <CAG6KGPSukQwdmfcJiE7CSHZf4hYV4niHm2QQcM1tyE=kBHBtzw@mail.gmail.com>
On 08/05/2016 01:31 AM, Martin Dev wrote:
> Hey Jens,
>
> I applied your patch, but it doesn't unlink the file as it continues
> at the !fio_file_open(f) in unlink_files(), run for 2 loops
>
> Clear State: 0
> Clear State: 1
> Doing unlink
> Starting file loop
> File is not open!
>
> I assume it's OK to flip it and check if the file is open then
> continue (so not to unlink files that are potentially still in use)
>
> I'll update the readme/docs and fio.1 as suggested.
The file_open() should just be removed, at best, or at least we should
flip the check, it doesn't make a lot of sense to only unlink if it's
open. In any case, it doesn't really matter if it's open or not, last
user will drop it.
So I'd just drop that check.
--
Jens Axboe
next prev parent reply other threads:[~2016-08-05 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 6:21 Unlink after each loop in job Martin Dev
2016-08-03 15:38 ` Jens Axboe
[not found] ` <CAG6KGPSthqs28GTQYSnFGcs_XzQWdALQ8knUS7ook2-_wurcmw@mail.gmail.com>
[not found] ` <4ac1a598-480e-bfa6-3704-929c909be5da@kernel.dk>
[not found] ` <b67f4217-97f3-f9f9-46a1-92c9b43ba9b9@kernel.dk>
2016-08-05 7:31 ` Martin Dev
2016-08-05 13:50 ` Jens Axboe [this message]
2016-08-08 7:19 ` Erwan Velu
2016-08-08 13:50 ` Jens Axboe
2016-08-08 14:14 ` Erwan Velu
2016-08-08 14:18 ` Jens Axboe
2016-08-08 15:33 ` Jens Axboe
2016-08-08 15:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0523eea4-0332-2b8e-a595-fd66cd6ae3de@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=mrturtledev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.