From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF5932ED845 for ; Mon, 15 Sep 2025 08:02:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757923363; cv=none; b=ebSaBHa9DDcNGmioiJPqdyMQYxFfsMmZqWfYswIYbFCAwbitSrCJIp0hkkSGkhd7rQrAXXfdCnzV+H4TYhQvYPvMaukp+3kYeiM5tnZFqjTk2XuWDalN9YVW9B/Iarjb4UuG/lfOCf3WKwsMsTIo0aevCLoAoBAFIWkzPZP+0Lg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757923363; c=relaxed/simple; bh=uPrvV8TuG3u939Wf7hmXkrHem12z6U2MUPYwEaSZ5IE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WYZhvlRFhofTVhyF6dY29aKHdHZm4rc4zs/5E4l8HrGbzEMeBw3Tv2RKg7SxEy/uuhCA3VwKfeOzHXJtoS6FOBdlE7whVMePLibqlmASdo/DvIUf7yAJxFtSzeWPggRHcR6hiZ5NvWimvlS0/w61QY1gqkLWjHD+YJVro5GMj6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b0qZ9GjH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b0qZ9GjH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757923359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NCGW5vXi3KzhsYVXIY0kjzcv0eF0LSLQelXGRAlgR0Q=; b=b0qZ9GjHLPnsuBU9vTjoBox9FmL9y/e91MAse325e33+x12rUWXp608wp8xS/WG2LcUC2Q CJrKlDW6pz/dyaNlHv4+uBtR2Ufvz85my1ruPQeMsZL/fwtRv1SoXhZ1jdJoqJgC2H4YIj owA21E4NaiYq56JtGDsjilDExYC8sf4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-bIpHpt_lPheGp_MU6AO8Lw-1; Mon, 15 Sep 2025 04:02:38 -0400 X-MC-Unique: bIpHpt_lPheGp_MU6AO8Lw-1 X-Mimecast-MFC-AGG-ID: bIpHpt_lPheGp_MU6AO8Lw_1757923357 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45de07b831dso20899585e9.1 for ; Mon, 15 Sep 2025 01:02:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757923357; x=1758528157; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NCGW5vXi3KzhsYVXIY0kjzcv0eF0LSLQelXGRAlgR0Q=; b=L8nf6dtBEK8u1j1jqTfZConWEizUcD5Y0eNNru6RLqG0oFDweFGsATXKHfKYCnmJuC djuMJhB88dqMGxcgO/P1L6eWt0uo7q+mb/4fENqVjm9G67j9zARVUpPCLj/EyoPwAJHL Y+JA9SMGjnI6oMkG3dA8Dr910s3N77HVoD5DD+Oeg1KKw4zsEE3L9TtK9Oo0SvM0SL26 UIitS1GRhbwC+SQDUnoTkL7slNyiuQ/XZwh2RxKgRH97OA9Vw1v55i8CbDg1cWFXGwyL WHuyltpvGWnrFFLNfLGDhVtQojWetjxjNZuydWse2uC+K+pP0U0jc+5E3fq7hkVtIstu wLzw== X-Gm-Message-State: AOJu0Yzoktgz0aalTr6eDZNzC2k4KF7wGAss4lLWt8GfLcTdBAPRpuFK uArOW/QYcyaMxo+6fD9X8H00xJxpv3ujmUNs94ZPQ6HlNZbsBJnkpDFBi5PNhlluNf1MeNK91JL HKfmnY0l5OLYlhmNfZyfTuhVtTEwVQXFaYINJXATDeYzvquaaxU8iSJBx X-Gm-Gg: ASbGncuCyi9HhkrpdhvQ1P/PeoZsIeF7Ki9r7mXvTaKaxHlRHGQaXgoPYgeTbDvdap6 wKsz28iFlSRe21z+URwJfHI4zSp0HkkZM0d8X8huCKdOGHwhfh1JHNYBarYkpLZx6jSJCPe7J7n 2YupBdo9gO6uFx+ATkA+ajqFtJPEU0FS5B/s2oIhpYycz+PiOr76Rr6piQhm7mB9CxMmh66IPpq Mz7dIAYtnBKprvOylcLiJkkJIr34t6t66lHj4VFmQoOY6MX9tJdrQz+PjOhoLNIfljOpwOOzbrp qBi1tVuwUf5s/SIV2s0WwO6gAatZm37jAryIkRq4Mf91VovSpnyyJdyvvStTx0zt3X5Z6ry3pTc lCJiYWb/KdrYsEiBiXWcgwmMpBskjsaJRNkNuVWKI3x28SDl97HYoZdLccVcVDzMCKfU= X-Received: by 2002:a5d:64e9:0:b0:3e7:6367:2bc6 with SMTP id ffacd0b85a97d-3e765a358a4mr10536463f8f.56.1757923357123; Mon, 15 Sep 2025 01:02:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6s+X3rp+DWpbnXK5djiT/Xw4QD8km1FPeMVJ/NnzfceueHx+G34YL2pTs/L+001A0RK0YgA== X-Received: by 2002:a5d:64e9:0:b0:3e7:6367:2bc6 with SMTP id ffacd0b85a97d-3e765a358a4mr10536396f8f.56.1757923356354; Mon, 15 Sep 2025 01:02:36 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:f900:e0ae:65d5:8bf8:8cfd? (p200300d82f18f900e0ae65d58bf88cfd.dip0.t-ipconnect.de. [2003:d8:2f18:f900:e0ae:65d5:8bf8:8cfd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e813eb46f3sm10069239f8f.23.2025.09.15.01.02.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Sep 2025 01:02:35 -0700 (PDT) Message-ID: <053aa2ec-c112-415b-94b6-e4677262d117@redhat.com> Date: Mon, 15 Sep 2025 10:02:32 +0200 Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v5 01/15] mm/zone_device: support large zone device private folios To: Balbir Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: damon@lists.linux.dev, dri-devel@lists.freedesktop.org, Andrew Morton , Zi Yan , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Oscar Salvador , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20250908000448.180088-1-balbirs@nvidia.com> <20250908000448.180088-2-balbirs@nvidia.com> <8c5267ec-cc85-4eff-b890-eb705472e2b2@redhat.com> <244005a2-4796-4985-853e-f916bdfd096a@redhat.com> <3674bdb2-0e59-4f0d-8adf-4794a6db546c@redhat.com> <227ee2b2-3c1f-449f-98f1-29bde663bfdf@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <227ee2b2-3c1f-449f-98f1-29bde663bfdf@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8EusAr0PiOi7if2Grzt5HVt4IwTuEGn5IS2jm1Wjr40_1757923357 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13.09.25 01:14, Balbir Singh wrote: > On 9/12/25 19:20, David Hildenbrand wrote: >> On 12.09.25 06:49, Balbir Singh wrote: >>> On 9/11/25 22:52, David Hildenbrand wrote: >>>> On 11.09.25 14:49, Balbir Singh wrote: >>>>> On 9/11/25 21:45, David Hildenbrand wrote: >>>>>> On 08.09.25 02:04, Balbir Singh wrote: >>>>>>> Add routines to support allocation of large order zone device folios >>>>>>> and helper functions for zone device folios, to check if a folio is >>>>>>> device private and helpers for setting zone device data. >>>>>>> >>>>>>> When large folios are used, the existing page_free() callback in >>>>>>> pgmap is called when the folio is freed, this is true for both >>>>>>> PAGE_SIZE and higher order pages. >>>>>>> >>>>>>> Zone device private large folios do not support deferred split and >>>>>>> scan like normal THP folios. >>>>>>> >>>>>>> Cc: Andrew Morton >>>>>>> Cc: David Hildenbrand >>>>>>> Cc: Zi Yan >>>>>>> Cc: Joshua Hahn >>>>>>> Cc: Rakie Kim >>>>>>> Cc: Byungchul Park >>>>>>> Cc: Gregory Price >>>>>>> Cc: Ying Huang >>>>>>> Cc: Alistair Popple >>>>>>> Cc: Oscar Salvador >>>>>>> Cc: Lorenzo Stoakes >>>>>>> Cc: Baolin Wang >>>>>>> Cc: "Liam R. Howlett" >>>>>>> Cc: Nico Pache >>>>>>> Cc: Ryan Roberts >>>>>>> Cc: Dev Jain >>>>>>> Cc: Barry Song >>>>>>> Cc: Lyude Paul >>>>>>> Cc: Danilo Krummrich >>>>>>> Cc: David Airlie >>>>>>> Cc: Simona Vetter >>>>>>> Cc: Ralph Campbell >>>>>>> Cc: Mika Penttilä >>>>>>> Cc: Matthew Brost >>>>>>> Cc: Francois Dugast >>>>>>> >>>>>>> Signed-off-by: Balbir Singh >>>>>>> --- >>>>>> >>>>>> You missed my comments of this patch in v3. >>>>>> >>>>> >>>>> Hi, David >>>>> >>>>> Looks I missed your comments, just checked those were largely about alignment and >>>>> integrating the code for DEVICE_COHERENT and DEVICE_PRIVATE cases into similar looking >>>>> bits for zone device folio free and code-alignment. I'll take a look and update as needed. >>>> >>>> Yes, and the confusing folio->mapping = NULL that I cannot connect to THP support. >>>> >>> >>> I can remove that, let me reunify those bits, seems relatively straight forward >> >> BTW, I was wondering when we invalidate folio_test_anon() by clearing folio->mapping int he current code flow? >> >> I mean, this must happen at some point when freeing device folios. >> > > The free_zone_device_folio() code does that. Lines 434 onwards there is a comment that explains it Ah okay. So it's not required at all in your case because MEMORY_DEVICE_PRIVATE is handled through if (pgmap->type != MEMORY_DEVICE_FS_DAX && pgmap->type != MEMORY_DEVICE_GENERIC) folio->mapping = NULL; You using "folio->page.mapping" instead of "folio->mapping" added a bit more confusion :) -- Cheers David / dhildenb