All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs: tree-log: use symbolic name for first replay stage
Date: Fri, 2 Aug 2019 11:50:26 +0800	[thread overview]
Message-ID: <053e458d-fffb-e483-0880-62a49ccda990@oracle.com> (raw)
In-Reply-To: <5e7f207680bb5e16c0ef4f8499b060bff308a8f5.1564663765.git.dsterba@suse.com>


For whole series.

Reviewed-by: Anand Jain <anand.jain@oracle.com>

One nit below.

On 8/1/19 8:50 PM, David Sterba wrote:
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
>   fs/btrfs/tree-log.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
> index 5513e76cc336..f48c8b9b513b 100644
> --- a/fs/btrfs/tree-log.c
> +++ b/fs/btrfs/tree-log.c
> @@ -6237,7 +6237,7 @@ int btrfs_recover_log_trees(struct btrfs_root *log_root_tree)
>   	struct btrfs_fs_info *fs_info = log_root_tree->fs_info;
>   	struct walk_control wc = {
>   		.process_func = process_one_buffer,
> -		.stage = 0,
> +		.stage = LOG_WALK_PIN_ONLY,

  Why this isn't enum?


>   	};
>   
>   	path = btrfs_alloc_path();
> 


  reply	other threads:[~2019-08-02  3:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 12:50 [PATCH 0/3] Define/enum conversions David Sterba
2019-08-01 12:50 ` [PATCH 1/3] btrfs: tree-log: convert defines to enums David Sterba
2019-08-01 12:50 ` [PATCH 2/3] btrsf: async-thread: " David Sterba
2019-08-01 12:50 ` [PATCH 3/3] btrfs: tree-log: use symbolic name for first replay stage David Sterba
2019-08-02  3:50   ` Anand Jain [this message]
2019-08-02 13:59     ` David Sterba
2019-08-01 13:33 ` [PATCH 0/3] Define/enum conversions Nikolay Borisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=053e458d-fffb-e483-0880-62a49ccda990@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.