From: Matthias Brugger <mbrugger@suse.com>
To: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ghennadi Procopciuc <Ghennadi.Procopciuc@oss.nxp.com>,
Chester Lin <chester62515@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
NXP S32 Linux Team <s32@nxp.com>,
Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>
Subject: Re: [PATCH 1/3] pinctrl: s32: add missing pins definitions
Date: Wed, 2 Oct 2024 13:58:13 +0200 [thread overview]
Message-ID: <054fd366-89fe-4ab8-b9db-88c5245cb719@suse.com> (raw)
In-Reply-To: <20240930132344.3001876-2-andrei.stefanescu@oss.nxp.com>
On 30/09/2024 15:23, Andrei Stefanescu wrote:
> Added definitions for some pins which were missing from the
> S32G2 SIUL2 pinctrl driver. These pins are used by the JTAG,
> PFE and LLCE hardware modules.
>
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
> drivers/pinctrl/nxp/pinctrl-s32g2.c | 52 +++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
>
> diff --git a/drivers/pinctrl/nxp/pinctrl-s32g2.c b/drivers/pinctrl/nxp/pinctrl-s32g2.c
> index 440ff1879424..c49d28793b69 100644
> --- a/drivers/pinctrl/nxp/pinctrl-s32g2.c
> +++ b/drivers/pinctrl/nxp/pinctrl-s32g2.c
> @@ -216,6 +216,12 @@ enum s32_pins {
> S32G_IMCR_CAN1_RXD = 631,
> S32G_IMCR_CAN2_RXD = 632,
> S32G_IMCR_CAN3_RXD = 633,
> +
> + /* JTAG IMCRs */
> + S32G_IMCR_JTAG_TMS = 562,
> + S32G_IMCR_JTAG_TCK = 572,
> + S32G_IMCR_JTAG_TDI = 573,
> +
> /* GMAC0 */
> S32G_IMCR_Ethernet_MDIO = 527,
> S32G_IMCR_Ethernet_CRS = 526,
> @@ -229,7 +235,21 @@ enum s32_pins {
> S32G_IMCR_Ethernet_RX_DV = 530,
> S32G_IMCR_Ethernet_TX_CLK = 538,
> S32G_IMCR_Ethernet_REF_CLK = 535,
> +
> /* PFE EMAC 0 MII */
> + S32G_IMCR_PFE_EMAC_0_MDIO = 837,
> + S32G_IMCR_PFE_EMAC_0_CRS = 836,
> + S32G_IMCR_PFE_EMAC_0_COL = 835,
> + S32G_IMCR_PFE_EMAC_0_RX_D0 = 841,
> + S32G_IMCR_PFE_EMAC_0_RX_D1 = 842,
> + S32G_IMCR_PFE_EMAC_0_RX_D2 = 843,
> + S32G_IMCR_PFE_EMAC_0_RX_D3 = 844,
> + S32G_IMCR_PFE_EMAC_0_RX_ER = 840,
> + S32G_IMCR_PFE_EMAC_0_RX_CLK = 839,
> + S32G_IMCR_PFE_EMAC_0_RX_DV = 845,
> + S32G_IMCR_PFE_EMAC_0_TX_CLK = 846,
> + S32G_IMCR_PFE_EMAC_0_REF_CLK = 838,
> +
> /* PFE EMAC 1 MII */
> S32G_IMCR_PFE_EMAC_1_MDIO = 857,
> S32G_IMCR_PFE_EMAC_1_CRS = 856,
> @@ -317,6 +337,13 @@ enum s32_pins {
> S32G_IMCR_LLCE_CAN13_RXD = 758,
> S32G_IMCR_LLCE_CAN14_RXD = 759,
> S32G_IMCR_LLCE_CAN15_RXD = 760,
> + S32G_IMCR_LLCE_UART0_RXD = 790,
> + S32G_IMCR_LLCE_UART1_RXD = 791,
> + S32G_IMCR_LLCE_UART2_RXD = 792,
> + S32G_IMCR_LLCE_UART3_RXD = 793,
> + S32G_IMCR_LLCE_LPSPI2_PCS0 = 811,
> + S32G_IMCR_LLCE_LPSPI2_SCK = 816,
> + S32G_IMCR_LLCE_LPSPI2_SIN = 817,
> S32G_IMCR_USB_CLK = 895,
> S32G_IMCR_USB_DATA0 = 896,
> S32G_IMCR_USB_DATA1 = 897,
> @@ -503,6 +530,12 @@ static const struct pinctrl_pin_desc s32_pinctrl_pads_siul2[] = {
> S32_PINCTRL_PIN(S32G_IMCR_USDHC_DAT7),
> S32_PINCTRL_PIN(S32G_IMCR_USDHC_DQS),
> S32_PINCTRL_PIN(S32G_IMCR_CAN0_RXD),
> +
> + /* JTAG IMCRs */
> + S32_PINCTRL_PIN(S32G_IMCR_JTAG_TMS),
> + S32_PINCTRL_PIN(S32G_IMCR_JTAG_TCK),
> + S32_PINCTRL_PIN(S32G_IMCR_JTAG_TDI),
> +
> /* GMAC0 */
> S32_PINCTRL_PIN(S32G_IMCR_Ethernet_MDIO),
> S32_PINCTRL_PIN(S32G_IMCR_Ethernet_CRS),
> @@ -638,6 +671,13 @@ static const struct pinctrl_pin_desc s32_pinctrl_pads_siul2[] = {
> S32_PINCTRL_PIN(S32G_IMCR_LLCE_CAN13_RXD),
> S32_PINCTRL_PIN(S32G_IMCR_LLCE_CAN14_RXD),
> S32_PINCTRL_PIN(S32G_IMCR_LLCE_CAN15_RXD),
> + S32_PINCTRL_PIN(S32G_IMCR_LLCE_UART0_RXD),
> + S32_PINCTRL_PIN(S32G_IMCR_LLCE_UART1_RXD),
> + S32_PINCTRL_PIN(S32G_IMCR_LLCE_UART2_RXD),
> + S32_PINCTRL_PIN(S32G_IMCR_LLCE_UART3_RXD),
> + S32_PINCTRL_PIN(S32G_IMCR_LLCE_LPSPI2_PCS0),
> + S32_PINCTRL_PIN(S32G_IMCR_LLCE_LPSPI2_SCK),
> + S32_PINCTRL_PIN(S32G_IMCR_LLCE_LPSPI2_SIN),
> S32_PINCTRL_PIN(S32G_IMCR_CAN1_RXD),
> S32_PINCTRL_PIN(S32G_IMCR_CAN2_RXD),
> S32_PINCTRL_PIN(S32G_IMCR_CAN3_RXD),
> @@ -652,6 +692,18 @@ static const struct pinctrl_pin_desc s32_pinctrl_pads_siul2[] = {
> S32_PINCTRL_PIN(S32G_IMCR_USB_DATA7),
> S32_PINCTRL_PIN(S32G_IMCR_USB_DIR),
> S32_PINCTRL_PIN(S32G_IMCR_USB_NXT),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_MDIO),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_CRS),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_COL),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_RX_D0),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_RX_D1),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_RX_D2),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_RX_D3),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_RX_ER),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_RX_CLK),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_RX_DV),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_TX_CLK),
> + S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_0_REF_CLK),
> S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_1_MDIO),
> S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_1_CRS),
> S32_PINCTRL_PIN(S32G_IMCR_PFE_EMAC_1_COL),
next prev parent reply other threads:[~2024-10-02 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 13:23 [PATCH 0/3] pinctrl: s32: add missing pins and an S32G3 compatible Andrei Stefanescu
2024-09-30 13:23 ` [PATCH 1/3] pinctrl: s32: add missing pins definitions Andrei Stefanescu
2024-10-02 11:58 ` Matthias Brugger [this message]
2024-09-30 13:23 ` [PATCH 2/3] dt-bindings: pinctrl: add S32G3 compatible for the SIUL2 driver Andrei Stefanescu
2024-09-30 13:40 ` Krzysztof Kozlowski
2024-09-30 14:46 ` Andrei Stefanescu
2024-10-01 6:20 ` Krzysztof Kozlowski
2024-09-30 13:23 ` [PATCH 3/3] arm64: dts: S32G3: add S32G3 compatible for the pinctrl node Andrei Stefanescu
2024-10-02 12:00 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=054fd366-89fe-4ab8-b9db-88c5245cb719@suse.com \
--to=mbrugger@suse.com \
--cc=Ghennadi.Procopciuc@oss.nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=andrei.stefanescu@oss.nxp.com \
--cc=aruizrui@redhat.com \
--cc=chester62515@gmail.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.