From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAFB2C5AE59 for ; Thu, 5 Jun 2025 07:24:29 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1006338.1385526 (Exim 4.92) (envelope-from ) id 1uN4xT-00037H-1X; Thu, 05 Jun 2025 07:24:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1006338.1385526; Thu, 05 Jun 2025 07:24:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uN4xS-00037A-VB; Thu, 05 Jun 2025 07:24:14 +0000 Received: by outflank-mailman (input) for mailman id 1006338; Thu, 05 Jun 2025 07:24:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uN4xR-000374-Og for xen-devel@lists.xenproject.org; Thu, 05 Jun 2025 07:24:13 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 144bc67f-41de-11f0-a300-13f23c93f187; Thu, 05 Jun 2025 09:24:12 +0200 (CEST) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3a361b8a664so598702f8f.3 for ; Thu, 05 Jun 2025 00:24:12 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506bd931bsm114360555ad.90.2025.06.05.00.24.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 00:24:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 144bc67f-41de-11f0-a300-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1749108252; x=1749713052; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=XvRCYzjYvWqqwHfKJcG6SenOHCxqn+OwugGlJt4Vnwg=; b=JYL84nh6g9MOfSgGzYTNxZnXInWmt25ICoU2T6x24y5Pe0UywdYiZWYxDB02XguQcz RFVNDh02iTd3G1mKm+39R/5KKHG78rzoJBgaMIbR+XwgYYQJipPpZv/AEqZ4rn6GhfUp +T6PNkUF3TAiRJciMC/lSPt857gHnlufmtgIuK+HB7JaBOmVC7yiKl1XzbdWptJ3L1yR eRcnQAwfwtlWaFwVhXeTioEaRbyqYdyY5OdNTu1k1gPAov8ehu2YKXQV/seOn4Y2TgZf d7m+a4IM9O+LGfaSDJ3FrXWl9M7Rd/XAn3HuYuAhE24FVPCDkg9Ai7ORUxRsqYkSwlcX ivwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749108252; x=1749713052; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XvRCYzjYvWqqwHfKJcG6SenOHCxqn+OwugGlJt4Vnwg=; b=hmVBoEq4FcuT0UK4Uxpw5CApfMr7pf92NAc0qZI4mQ1T/BS59D3wkyfdUX20PqYysi yo7S37njRMyW+7mdRYGXR4ZGzHItHbidWesHTecSwObih4knXOLuV3DSQP7bEqkDE0fJ q4vh9MCy/qSA0lyfVPDzO1JfUebpqaGSePJ4QbQOUMxF/JO71GjCMM7wdN7ACyF7ux9m IzxZ+wk63vnRsk+eYt0EqluPdYepX9bFndfFWcvT5ztKcNU8R+3P/K52UaogLfih9yMU ojCuaP4QS63bXuqtC/AvO3to4gZbnWYV8vtutQZ0sPPdheQWgnN+IF2d9iqOsr7T+30v Sp4w== X-Forwarded-Encrypted: i=1; AJvYcCXXf53EK4Z6xU3Vpude8C+tmCqDinfhXbywI68q7Gzs40YiWShY9zzear8Vvx6B7nNe8cMuUPbIIAM=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy9hYbGaU1G+nLd1PjnvHkdL/q2qeatSNr2ZlGzzXF3+/imJ+iu mXUr7oZwdPxUr+t06+h4BPHniRSk1v6EcoIUtupAek5vWCsFHx2yWC5ozblP0vDqzQ== X-Gm-Gg: ASbGncu5VDzcm005HmSw4U7qfCCpjOWfLohZMkkWQ2+uvGB2y07nU0rWuPd+OKzutv4 GkD6glZFhM01D+e1BTPAvRhkrvDV/xRGopR2FkgGUUyq7EaQ7lR8XSUxHYLopBWCVHgMbAzeI4E 2pElp9uXAZ/H3pECUN8uSlwk4Tjw+9WkokZdplNgF47nHS9qxrj75Wpl/V0bdF09gC4LJZPjz7H rh1EoPKNWCZA+dnBbkNw87jfWH/kuOfhPmVTUPPSzbCq0KWuzCwn3i4ltYlhYjS+y9xH+lEsPSz boBkwhPSbCVVTIm5UAMzrdmopY/1bpyLd+rjCJ04Mr4oUwb9dVk9PlR2EvaoeXPp5cD1ZOlxDYX XPargHoqxfPldDlG/tWGZkQbuBhJPgKymmeRqSjpCjHoJSjwdu7KzyI0ZfA== X-Google-Smtp-Source: AGHT+IF2cJ2PnImVsJX5pubmpSxSUJb9SkCT5OnxRxLNUr9Ghv7gmKaX9fEAg60oqLsHU3zROGayjA== X-Received: by 2002:a05:6000:2004:b0:3a4:e841:ee76 with SMTP id ffacd0b85a97d-3a51d968a7emr4272078f8f.37.1749108252133; Thu, 05 Jun 2025 00:24:12 -0700 (PDT) Message-ID: <0575e9d0-ff37-4f66-8ee3-e8c3675f9cc4@suse.com> Date: Thu, 5 Jun 2025 09:24:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] xen/x86: add missing noreturn attributes To: victorm.lira@amd.com Cc: Nicola Vetrini , Andrew Cooper , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?B?Um9nZXIgUGF1IE1vbm7Dg8Kp?= , Stefano Stabellini , Federico Serafini , Bertrand Marquis , xen-devel@lists.xenproject.org References: <20250604235034.1595881-1-victorm.lira@amd.com> <20250604235034.1595881-2-victorm.lira@amd.com> <20250604235034.1595881-3-victorm.lira@amd.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20250604235034.1595881-3-victorm.lira@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05.06.2025 01:49, victorm.lira@amd.com wrote: > From: Nicola Vetrini > > The marked functions never return to their caller, but > lack the `noreturn' attribute, therefore causing a violation > of MISRA C Rule 2.1: "A project shall not contain unreachable code". > > No functional change. > > Signed-off-by: Nicola Vetrini > Signed-off-by: Victor Lira I expect the comment on patch 1 applies to some or all of the cases here, too. For example, I expect that even if efi_arch_halt() wasn't inlined into its sole caller, the compiler would also be able to infer noreturn from the infinite loop there. Jan