RE: [PATCH] kexec: sh: Fixed command line management.

[Angelo CASTELLO <angelo.castello@st.com>]

> -----Original Message-----
> From: kexec-bounces@lists.infradead.org [mailto:kexec-
> bounces@lists.infradead.org] On Behalf Of Simon Horman
> Sent: martedì 6 settembre 2011 0.30
> To: Angelo CASTELLO
> Cc: kexec@lists.infradead.org
> Subject: Re: [PATCH] kexec: sh: Fixed command line management.
> 
> On Mon, Sep 05, 2011 at 05:02:24PM +0200, Angelo CASTELLO wrote:
> > This fixes the command line management to be rightly used by
> > elf-sh and zImage-sh type formats. Basically, the issue was on use
> > of --append option for both set and append the STRING at the cmdline.
> > With this patch we correctly manage the cmdline by means of:
> >   --append=STRING           Append STRING to the current kernel
> command line
> >   --command-line=STRING     Set the kernel command line to STRING
> > Kexec by default gets and runs new kernel using the current
> > kernel command line. Running kexec -h you will see its default
> options.
> 
> Hi Angelo,
> 
> I don't believe that the changes to the processing of command-line
> that you have made are consistent with the implementation on
> other architectures.

Hi Simon,
To be consistent with the concepts of --append and --command-line,
can I use the guide line implemented by the x86_64 ? 
Where we have:
                { "command-line",       1, NULL, OPT_APPEND },
                { "append",             1, NULL, OPT_APPEND },
                { "reuse-cmdline",      0, NULL, OPT_REUSE_CMDLINE },

But from my point of view, one of them is redundant. 
Could be appropriate to change the meant of '--append' from 'set' to
'append',
for all architectures.
What do you think ?

> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec