From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0235CE6C616 for ; Tue, 3 Dec 2024 08:15:25 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Y2YP81YYfz30Bj for ; Tue, 3 Dec 2024 19:15:24 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=115.124.30.112 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1733213722; cv=none; b=Nflf5eOe06kkCg6LxoJ3vIn9QWbEP+qBkptGRE4xoRsJYxV1U1MVjgW5qi1/36hGdeCa8yN1Y9xOu1Xd2ofIvS+OyuLFPMfZQueKINl4dOpiUDK2/AvG7RIWddKUvLwOQ541NUcCouxPpjojUKuRkzeX9OtnCKBpozhNxyTZShCcTdN+z0URYZ001wO+XNsq6JB0bSZNR3SpUHI+AgL1kWR77mJjMelVz1rqhwr8j/Ac5LkApO1493wXx8gYOytsfyRzXXXF5QCs8HUErBtLAeAbZfNdta41tc8/dZeDcrYPb+QdKQELAvm0lbom3pZ6XhMdn9qjvppKmibKCMevrQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1733213722; c=relaxed/relaxed; bh=P9bXSc8Mw7fyXPHQ8KEsd7SMB95kevoVh98GxRCDL0w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M6n+KzcT35AjMiKO8fHr7m24IfyyzsGgb+RBKBqObmWDBPoABGzVw3Qn3l+enntZN6y7McoAxIKOUt8S5PHgWhUFyG5Wyujr+AlIjZK3LOtIoP1sZQwQd5W6x3ozHOgEtIkKh/uouslYFjBLeeNoSWjNlnqa0jQXqdnCFjvcVSjeq9SVWF8Ey65CTwvY6RFOGcNAW65U4xc8ZFhE1mQCrygusr12s8ZBBWC7CmQAPfEg5ybYcAbiV2X6h1apSGTntZ74JqnSRLT2u0U8jV0xjWddw1bfqsiwdHKfgoFnu0VPf6s5OdUBPQ1J1AJOHJa63yP6VsmrN5Bx9G3ZATZSYA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=aHtMFiHE; dkim-atps=neutral; spf=pass (client-ip=115.124.30.112; helo=out30-112.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=aHtMFiHE; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.112; helo=out30-112.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Y2YNy5VJHz2xgQ for ; Tue, 3 Dec 2024 19:15:12 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1733213706; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=P9bXSc8Mw7fyXPHQ8KEsd7SMB95kevoVh98GxRCDL0w=; b=aHtMFiHEbFDhGu1ihTWcEnnXR3Z2oQIYqsF7Z9J0LXbc8ln0+qlXss/Zb5snHJR3aCtijv/+mruE11RtNfSyIimXQacaLo+pURKz0m/pxy1gNL5Zex5tsbz82iqh9fAsn7PPxPJSfEVysLR8oyTZThYo3fSn8C05mfUXkQin398= Received: from 30.221.129.129(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WKm.qCN_1733213705 cluster:ay36) by smtp.aliyun-inc.com; Tue, 03 Dec 2024 16:15:05 +0800 Message-ID: <0584d334-4e75-4d35-be33-03d6ff7a0aba@linux.alibaba.com> Date: Tue, 3 Dec 2024 16:15:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] erofs: fix PSI memstall accounting To: Max Kellermann References: <20241127085236.3538334-1-hsiangkao@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-erofs@lists.ozlabs.org, LKML Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2024/12/3 16:02, Max Kellermann via Linux-erofs wrote: > On Tue, Dec 3, 2024 at 2:42 AM Gao Xiang wrote: >> I think at least this patch resolves a recent regression, >> I guess we'd better to address it first. > > Certainly your patch is an improvement, but maybe this just wasn't the > bug I was experiencing. > >> As for your reports, I think we might need more information >> about this, since I don't find more clues from the EROFS >> codebase itself. > > What kind of information do you need? I posted some high-level > information about my setup here: > https://lore.kernel.org/lkml/CAKPOu+-_X9cc723v_f_BW4CwfHJe_mi=+cbUBP2tZO-kEcyoMA@mail.gmail.com/ > What else do you want to know? > This triggers pretty often now - can we improve Suren's patch to > record and dump more information when this happens? > > Right now, we don't even know if this is an erofs problem (and if this > ever was). It is just one of several candidates. I have no idea since I'm not working on PSI stuffs. But I guess you could record more frame addresses to get the caller of readahead_expand()? e.g. __builtin_return_address(1)? Also btw, is _RET_IP_ stable among all cases as readahead_expand()? Thanks, Gao Xiang > > Max