From: Krzysztof Kozlowski <krzk@kernel.org>
To: Parthiban Nallathambi <parthiban@linumiz.com>,
Frank Binns <frank.binns@imgtec.com>,
Matt Coster <matt.coster@imgtec.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: gpu: add reset control property
Date: Tue, 26 Nov 2024 10:32:46 +0100 [thread overview]
Message-ID: <05a4fd39-d53a-49c3-b236-01ba16fb193e@kernel.org> (raw)
In-Reply-To: <20241125-pvr-reset-v1-1-b437b8052948@linumiz.com>
On 25/11/2024 17:37, Parthiban Nallathambi wrote:
> GE8300 in Allwinner A133 have reset control from the ccu.
> Add the resets property as optional one to control it.
>
> Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>
> ---
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Missing prefix for the device. You are not adding reset to all GPU devices.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-26 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 16:37 [PATCH 0/2] drm/imagination: add reset handling Parthiban Nallathambi
2024-11-25 16:37 ` [PATCH 1/2] dt-bindings: gpu: add reset control property Parthiban Nallathambi
2024-11-25 18:07 ` Conor Dooley
2024-11-26 3:46 ` Parthiban
2024-11-26 9:32 ` Krzysztof Kozlowski
2024-11-26 9:42 ` Parthiban
2024-11-26 9:32 ` Krzysztof Kozlowski [this message]
2024-11-25 16:37 ` [PATCH 2/2] drm/imagination: add reset control support Parthiban Nallathambi
2024-11-26 9:29 ` Philipp Zabel
2024-11-26 9:48 ` Parthiban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05a4fd39-d53a-49c3-b236-01ba16fb193e@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.binns@imgtec.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt.coster@imgtec.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=parthiban@linumiz.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.