From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3916C4332F for ; Fri, 4 Nov 2022 14:18:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231182AbiKDOSg (ORCPT ); Fri, 4 Nov 2022 10:18:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231238AbiKDOSP (ORCPT ); Fri, 4 Nov 2022 10:18:15 -0400 Received: from relay08.th.seeweb.it (relay08.th.seeweb.it [IPv6:2001:4b7a:2000:18::169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FAEA63F4 for ; Fri, 4 Nov 2022 07:17:58 -0700 (PDT) Received: from [192.168.31.208] (unknown [194.29.137.22]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 295BD3F6DD; Fri, 4 Nov 2022 15:17:56 +0100 (CET) Message-ID: <05f5cd8a-7908-c69b-33bb-fb75220403a9@somainline.org> Date: Fri, 4 Nov 2022 15:17:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v1 4/5] arm64: dts: qcom: sm8450-hdk: Add LT9611uxc HDMI bridge To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski Cc: Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Vinod Koul References: <20221104131358.1025987-1-dmitry.baryshkov@linaro.org> <20221104131358.1025987-5-dmitry.baryshkov@linaro.org> From: Konrad Dybcio In-Reply-To: <20221104131358.1025987-5-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 04/11/2022 14:13, Dmitry Baryshkov wrote: > From: Vinod Koul > > Add the LT9611uxc DSI-HDMI bridge and supplies > > Signed-off-by: Vinod Koul > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 61 +++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > index e1a4cf1ee51d..9522dd29a38a 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > @@ -20,6 +20,28 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > + lt9611_1v2: lt9611-vdd12-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "LT9611_1V2"; > + > + vin-supply = <&vph_pwr>; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + gpio = <&tlmm 9 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + lt9611_3v3: lt9611-3v3 { The previous node has -regulator, this one doesn't, please keep it consistent. > + compatible = "regulator-fixed"; > + regulator-name = "LT9611_3V3"; > + > + vin-supply = <&vreg_bob>; > + gpio = <&tlmm 109 GPIO_ACTIVE_HIGH>; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + enable-active-high; > + }; > + > vph_pwr: vph-pwr-regulator { > compatible = "regulator-fixed"; > regulator-name = "vph_pwr"; > @@ -349,6 +371,27 @@ vreg_l7e_2p8: ldo7 { > }; > }; > > +&i2c9 { > + status = "okay"; > + clock-frequency = <400000>; Status last, please. With these fixes: Reviewed-by: Konrad Dybcio Konrad > + > + lt9611_codec: hdmi-bridge@2b { > + compatible = "lontium,lt9611uxc"; > + reg = <0x2b>; > + > + interrupts-extended = <&tlmm 44 IRQ_TYPE_EDGE_FALLING>; > + > + reset-gpios = <&tlmm 107 GPIO_ACTIVE_HIGH>; > + > + vdd-supply = <<9611_1v2>; > + vcc-supply = <<9611_3v3>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <<9611_irq_pin <9611_rst_pin>; > + > + }; > +}; > + > &pcie0 { > status = "okay"; > max-link-speed = <2>; > @@ -394,8 +437,26 @@ &qupv3_id_0 { > status = "okay"; > }; > > +&qupv3_id_1 { > + status = "okay"; > +}; > + > &tlmm { > gpio-reserved-ranges = <28 4>, <36 4>; > + > + lt9611_irq_pin: lt9611-irq { > + pins = "gpio44"; > + function = "gpio"; > + bias-disable; > + }; > + > + lt9611_rst_pin: lt9611-rst-state { > + pins = "gpio107"; > + function = "normal"; > + > + output-high; > + input-disable; > + }; > }; > > &uart7 { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71436C43219 for ; Fri, 4 Nov 2022 14:18:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0933D10E7F8; Fri, 4 Nov 2022 14:18:02 +0000 (UTC) Received: from relay05.th.seeweb.it (relay05.th.seeweb.it [5.144.164.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5700F10E7F7; Fri, 4 Nov 2022 14:17:58 +0000 (UTC) Received: from [192.168.31.208] (unknown [194.29.137.22]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 295BD3F6DD; Fri, 4 Nov 2022 15:17:56 +0100 (CET) Message-ID: <05f5cd8a-7908-c69b-33bb-fb75220403a9@somainline.org> Date: Fri, 4 Nov 2022 15:17:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v1 4/5] arm64: dts: qcom: sm8450-hdk: Add LT9611uxc HDMI bridge To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski References: <20221104131358.1025987-1-dmitry.baryshkov@linaro.org> <20221104131358.1025987-5-dmitry.baryshkov@linaro.org> From: Konrad Dybcio In-Reply-To: <20221104131358.1025987-5-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , Vinod Koul , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 04/11/2022 14:13, Dmitry Baryshkov wrote: > From: Vinod Koul > > Add the LT9611uxc DSI-HDMI bridge and supplies > > Signed-off-by: Vinod Koul > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 61 +++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > index e1a4cf1ee51d..9522dd29a38a 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > @@ -20,6 +20,28 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > + lt9611_1v2: lt9611-vdd12-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "LT9611_1V2"; > + > + vin-supply = <&vph_pwr>; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + gpio = <&tlmm 9 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + lt9611_3v3: lt9611-3v3 { The previous node has -regulator, this one doesn't, please keep it consistent. > + compatible = "regulator-fixed"; > + regulator-name = "LT9611_3V3"; > + > + vin-supply = <&vreg_bob>; > + gpio = <&tlmm 109 GPIO_ACTIVE_HIGH>; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + enable-active-high; > + }; > + > vph_pwr: vph-pwr-regulator { > compatible = "regulator-fixed"; > regulator-name = "vph_pwr"; > @@ -349,6 +371,27 @@ vreg_l7e_2p8: ldo7 { > }; > }; > > +&i2c9 { > + status = "okay"; > + clock-frequency = <400000>; Status last, please. With these fixes: Reviewed-by: Konrad Dybcio Konrad > + > + lt9611_codec: hdmi-bridge@2b { > + compatible = "lontium,lt9611uxc"; > + reg = <0x2b>; > + > + interrupts-extended = <&tlmm 44 IRQ_TYPE_EDGE_FALLING>; > + > + reset-gpios = <&tlmm 107 GPIO_ACTIVE_HIGH>; > + > + vdd-supply = <<9611_1v2>; > + vcc-supply = <<9611_3v3>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <<9611_irq_pin <9611_rst_pin>; > + > + }; > +}; > + > &pcie0 { > status = "okay"; > max-link-speed = <2>; > @@ -394,8 +437,26 @@ &qupv3_id_0 { > status = "okay"; > }; > > +&qupv3_id_1 { > + status = "okay"; > +}; > + > &tlmm { > gpio-reserved-ranges = <28 4>, <36 4>; > + > + lt9611_irq_pin: lt9611-irq { > + pins = "gpio44"; > + function = "gpio"; > + bias-disable; > + }; > + > + lt9611_rst_pin: lt9611-rst-state { > + pins = "gpio107"; > + function = "normal"; > + > + output-high; > + input-disable; > + }; > }; > > &uart7 {