From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcHNH-0003Co-QA for ath11k@lists.infradead.org; Fri, 22 May 2020 23:46:49 +0000 MIME-Version: 1.0 Date: Fri, 22 May 2020 16:46:45 -0700 From: Pradeep Kumar Chitrapu Subject: Re: [PATCH v2 1/9] cfg80211: Add new channel flag to identify 6GHz PSC channel In-Reply-To: References: <20200522072431.27601-1-pradeepc@codeaurora.org> <20200522072431.27601-2-pradeepc@codeaurora.org> Message-ID: <05fcfc43f2d59dd549a65a83ab60df60@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org T24gMjAyMC0wNS0yMiAxMzozOCwgSm9oYW5uZXMgQmVyZyB3cm90ZToKPiBPbiBGcmksIDIwMjAt MDUtMjIgYXQgMDA6MjQgLTA3MDAsIFByYWRlZXAgS3VtYXIgQ2hpdHJhcHUgd3JvdGU6Cj4+IDZH SHogY2hhbm5lbHMgYXJlIGRpdmlkZWQgaW50byBwcmVmZXJyZWQgc2Nhbm5pbmcgY2hhbm5lbHMo UFNDKQo+PiBhbmQgbm9uLVBTQyBjaGFubmVscy4gT25lIGluIGV2ZXJ5IGZvdXIgMjBNSHogY2hh bm5lbHMgaXMgYSBQU0MuCj4+IFNwZWMgbWFuZGF0ZXMgdG8gdXNlIG9ubHkgUFNDIGNoYW5uZWxz IGFzIHByaW1hcnkgY2hhbm5lbHMgZm9yCj4+IHNldHRpbmcgdXAgQlNTIG9uIDZHSHogb25seSBB UC4KPj4gCj4+IFRoZSBzZXQgb2YgMjAgTUh6IGNoYW5uZWxzIGluIHRoZSA2IEdIeiBiYW5kLCB3 aXRoIGNoYW5uZWwgY2VudGVyCj4+IGZyZXF1ZW5jeSwgY2hfYSA9IENoYW5uZWwgc3RhcnRpbmcg ZnJlcXVlbmN5IOKAkyA1NSArIDgwIMOXIG4gKE1IeikKPj4gYXJlIHJlZmVycmVkIHRvIGFzIHBy ZWZlcnJlZCBzY2FubmluZyBjaGFubmVscyAoUFNDcykgd2hlcmUsCj4+IG4gPSAxLCDigKYsIDE1 IGFzIHBlciBJRUVFIFA4MDIuMTFheC9ENi4wLgo+PiAKPj4gVGhpcyBmbGFnIGFsc28gd2lsbCBi ZSB1c2VkIHdoZW4gbWFraW5nIHNjYW5uaW5nIGRlY2lzaW9uIG9uCj4+IDZHSHogY2hhbm5lbHMu Cj4gCj4gSXMgdGhlcmUgbXVjaCB2YWx1ZSBpbiBleHBvc2luZyB0aGlzIGFzIGEgKmZsYWcqPwo+ IAo+IFdlIGhhdmUgYSBzaW1pbGFyIHBhdGNoLCBidXQgaXQganVzdCBhZGRzIHRoZSBmdW5jdGlv biBhbmQgZXZlcnlvbmUgd2hvCj4gY2FyZXMgY2FuIGNhbGwgaXQuIERvIHdlIHJlYWxseSBuZWVk IHRvIHByZWNhbGN1bGF0ZSB0aGF0Pwo+IAo+IGpvaGFubmVzClRoYW5rcyBKb2hhbm5lcyBmb3Ig dGhlIHJldmlldy4uCgpJTU8sIGFjY2Vzc2luZyBmbGFnIHdvdWxkIGJlIGZhc3RlciBpbnN0ZWFk IG9mIGNvbXB1dGF0aW9uLCBhcyB0aGlzIGluZm8KaXMgaGFuZHkgKGFscmVhZHkgaW4gY2FjaGUp IHdoZW4gYWNjZXNzaW5nIGllZWU4MDIxMV9jaGFubmVsLgpIb3dldmVyLCBjb25zaWRlcmluZyBn ZW5lcmFsIHVzYWdlIGZvciB0aGlzIGluZm8gd291bGQgYmUgb25seSBmb3IgCmNvbnRyb2wKcGF0 aCwgaXQgc2hvdWxkIGJlIG9rIHRvIGV4cG9zZSBmdW5jdGlvbiBpbnN0ZWFkIG9mIG1haW50YWlu aW5nIHNlcGFyYXRlIApmbGFnLgpQbGVhc2UgbGV0IG1lIGtub3cgeW91ciBzdWdnZXN0aW9uLi4K CgpUaGFua3MKUHJhZGVlcAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KYXRoMTFrIG1haWxpbmcgbGlzdAphdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDExawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA237C433DF for ; Fri, 22 May 2020 23:47:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 644BA20723 for ; Fri, 22 May 2020 23:47:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="kN+e7WrC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387403AbgEVXrD (ORCPT ); Fri, 22 May 2020 19:47:03 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:23827 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726546AbgEVXrD (ORCPT ); Fri, 22 May 2020 19:47:03 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590191222; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Gx02i5Yb6v30cf4xupak+zCn9HyVT81kHQxKTCg+eZM=; b=kN+e7WrCXr5LXYQk7EinOlzC3rD/vL8G2YBuVBUSSI0GH1W9JHmTArn+RnCxPljKyPdeMZDR npUQ/jg+vOOyQ8DYDiozRbrdHDPa4zL0fibHXYSBKa9t8zOPECt/1sfmB9FItj0eB4i1q0cO dlacpslu2T/sMxfTegPP39Q86lk= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ec86465.7f542c9a1730-smtp-out-n01; Fri, 22 May 2020 23:46:45 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 47B27C433C9; Fri, 22 May 2020 23:46:45 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: pradeepc) by smtp.codeaurora.org (Postfix) with ESMTPSA id 10425C433C8; Fri, 22 May 2020 23:46:45 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 22 May 2020 16:46:45 -0700 From: Pradeep Kumar Chitrapu To: Johannes Berg Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 1/9] cfg80211: Add new channel flag to identify 6GHz PSC channel In-Reply-To: References: <20200522072431.27601-1-pradeepc@codeaurora.org> <20200522072431.27601-2-pradeepc@codeaurora.org> Message-ID: <05fcfc43f2d59dd549a65a83ab60df60@codeaurora.org> X-Sender: pradeepc@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-05-22 13:38, Johannes Berg wrote: > On Fri, 2020-05-22 at 00:24 -0700, Pradeep Kumar Chitrapu wrote: >> 6GHz channels are divided into preferred scanning channels(PSC) >> and non-PSC channels. One in every four 20MHz channels is a PSC. >> Spec mandates to use only PSC channels as primary channels for >> setting up BSS on 6GHz only AP. >> >> The set of 20 MHz channels in the 6 GHz band, with channel center >> frequency, ch_a = Channel starting frequency – 55 + 80 × n (MHz) >> are referred to as preferred scanning channels (PSCs) where, >> n = 1, …, 15 as per IEEE P802.11ax/D6.0. >> >> This flag also will be used when making scanning decision on >> 6GHz channels. > > Is there much value in exposing this as a *flag*? > > We have a similar patch, but it just adds the function and everyone who > cares can call it. Do we really need to precalculate that? > > johannes Thanks Johannes for the review.. IMO, accessing flag would be faster instead of computation, as this info is handy (already in cache) when accessing ieee80211_channel. However, considering general usage for this info would be only for control path, it should be ok to expose function instead of maintaining separate flag. Please let me know your suggestion.. Thanks Pradeep