AW: [PATCH 1/7] dt-bindings: interrupt-controller: realtek,rtl-intc: Allow 2 interrupt cells

["Markus Stockhausen" <markus.stockhausen@gmx.de>]

Hi,

> Von: sashiko-bot@kernel.org <sashiko-bot@kernel.org> 
> Gesendet: Freitag, 5. Juni 2026 23:26
> An: Markus Stockhausen <markus.stockhausen@gmx.de>
> Cc: devicetree@vger.kernel.org; robh@kernel.org; conor+dt@kernel.org
> Betreff: Re: [PATCH 1/7] dt-bindings: interrupt-controller: realtek,rtl-intc: Allow 2 interrupt cells
> 
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The cell-count property `#interrupt-cells` uses an `enum` constraint instead of a `const` constraint, violating dt-bindings subsystem rules.
> --
>
> commit 11a7c1b034a74e6212dca3ea81cd1ec7e513c49c
> Author: Markus Stockhausen <markus.stockhausen@gmx.de>
>
> dt-bindings: interrupt-controller: realtek,rtl-intc: Allow 2 interrupt cells
>
> This commit updates the #interrupt-cells property to accept either 1 or 2
> cells to support explicit hardware interrupt routing to multiple parent CPU
> interrupt lines.
>
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml
> > --- a/Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.yaml
> > @@ -32,8 +32,9 @@ properties:
> >  
> >    "#interrupt-cells":
> >      description:
> > -      SoC interrupt line index.
> > -    const: 1
> > +      First cell is the SoC interrupt line index. Optional second cell
> > +      specifies the parent interrupt index to route to.
> > +    enum: [1, 2]
>
> [Severity: Medium]
> Does this change violate the subsystem requirements for cell-count properties?

Is switching form const:1 to const: 2 the right way here?
Even if the driver changes handle the old 1 cell syntax 
gracefully?

Markus