All of lore.kernel.org
 help / color / mirror / Atom feed
From: <markus.stockhausen@gmx.de>
To: "'Jonas Jelonek'" <jelonek.jonas@gmail.com>,
	"'Chris Packham'" <chris.packham@alliedtelesis.co.nz>,
	"'Andi Shyti'" <andi.shyti@kernel.org>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"'Sven Eckelmann'" <sven@narfation.org>,
	"'Harshal Gohel'" <hg@simonwunderlich.de>,
	"'Wolfram Sang'" <wsa+renesas@sang-engineering.com>
Subject: AW: [PATCH v6 00/12] i2c: fix, rework and extend RTL9300 I2C driver
Date: Mon, 25 Aug 2025 21:33:44 +0200	[thread overview]
Message-ID: <064c01dc15f7$2cfce970$86f6bc50$@gmx.de> (raw)
In-Reply-To: <20250824113348.263475-1-jelonek.jonas@gmail.com>

> Von: Jonas Jelonek <jelonek.jonas@gmail.com> 
> Gesendet: Sonntag, 24. August 2025 13:34
> Betreff: [PATCH v6 00/12] i2c: fix, rework and extend RTL9300 I2C driver
>
> This patch series for the RTL9300 I2C driver:
>     - fixes issues, one of them in some cases causing data corruption
>     - reworks significant parts of the current implementation
>     - add support for the (quite similar) RTL9310 series
>
> Goal of this is to fix critical issues, improve overall code quality and
> simplify maintainance and further extension of the driver. Moreover, it
> should be brought on par feature-wise with OpenWrt's downstream driver
> to be able to drop the downstream version.
>
> The first three patches address bugs in the current implementation, on
> of them being critical and causing data corruption under certain
> circumstances. Although the hardware doesn't support SMBus Quick Write,
> the driver claims to support it with a broken implementation. This
> causes to execute a 16-byte Write instead of a Quick Write, e.g. causing
> corruption on not-write-protected SFP EEPROMs and soft-bricking them.
> These three patches are also sent to 'stable' because they fix critical
> issues.
>
> Subsequent patches introduce various smaller and bigger enhancements.
> These include:
>     - use regmap_field + its API instead of macros + GENMASK + shifts
>     - refactor xfer handling
>     - variable renaming to avoid confusion
>     - move some register operations, calling them somewhere else and
>       less frequently
>     - use guarded mutex instead of explicit mutex_lock/_unlock to
>       simplify control flow
>
> Finally, the last two patches add support for RTL9310 (mango) series to
> the driver and adjust the dt-bindings accordingly.
>
> Simple operations have been tested successfully on:
>     - Zyxel XGS1210-12 (RTL9302B)
>     - TP-Link TL-ST1008F v2.0 (RTL9303)
>     - Netgear MS510TXM (RTL9313)
>
> with Byte-Read, Word-Read and I2C-Block-Read. Other operations need
> testing from people with devices available.
>
> Compile-tested with Linux, run-tested as backport in OpenWrt on the
> aforementioned devices.

Repeated the downstream tests with this series backported to 6.12. 
Successfully tested on Linksys LGS328C (RTL9301) and LGS352C (RTL9311)

Tested-by: Markus Stockhausen <markus.stockhausen@gmx.de


      parent reply	other threads:[~2025-08-25 19:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-24 11:33 [PATCH v6 00/12] i2c: fix, rework and extend RTL9300 I2C driver Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 01/12] i2c: rtl9300: fix channel number bound check Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 02/12] i2c: rtl9300: ensure data length is within supported range Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 03/12] i2c: rtl9300: remove broken SMBus Quick operation support Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 04/12] i2c: rtl9300: use regmap fields and API for registers Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 05/12] dt-bindings: i2c: realtek,rtl9301-i2c: fix wording and typos Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 06/12] i2c: rtl9300: rename internal sda_pin to sda_num Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 07/12] i2c: rtl9300: move setting SCL frequency to config_io Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 08/12] i2c: rtl9300: do not set read mode on every transfer Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 09/12] i2c: rtl9300: separate xfer configuration and execution Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 10/12] i2c: rtl9300: use scoped guard instead of explicit lock/unlock Jonas Jelonek
2025-08-24 14:12   ` Markus Elfring
2025-08-24 17:44     ` Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 11/12] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9310 support Jonas Jelonek
2025-08-24 11:33 ` [PATCH v6 12/12] i2c: rtl9300: add support for RTL9310 I2C controller Jonas Jelonek
2025-08-24 21:31 ` [PATCH v6 00/12] i2c: fix, rework and extend RTL9300 I2C driver Chris Packham
2025-08-25 19:33 ` markus.stockhausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='064c01dc15f7$2cfce970$86f6bc50$@gmx.de' \
    --to=markus.stockhausen@gmx.de \
    --cc=andi.shyti@kernel.org \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=hg@simonwunderlich.de \
    --cc=jelonek.jonas@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sven@narfation.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.