Re: [PATCH] block: use writeback_iter

[Hannes Reinecke <hare@suse.de>]

On 4/24/25 10:27, Christoph Hellwig wrote:
> Use writeback_iter instead of the deprecated write_cache_pages wrapper
> in blkdev_writepages.  This removes an indirect call per folio.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   block/fops.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/block/fops.c b/block/fops.c
> index be9f1dbea9ce..f073ef6d3f27 100644
> --- a/block/fops.c
> +++ b/block/fops.c
> @@ -451,12 +451,13 @@ static int blkdev_get_block(struct inode *inode, sector_t iblock,
>   static int blkdev_writepages(struct address_space *mapping,
>   		struct writeback_control *wbc)
>   {
> +	struct folio *folio = NULL;
>   	struct blk_plug plug;
>   	int err;
>   
>   	blk_start_plug(&plug);
> -	err = write_cache_pages(mapping, wbc, block_write_full_folio,
> -			blkdev_get_block);
> +	while ((folio = writeback_iter(mapping, wbc, folio, &err)))
> +		err = block_write_full_folio(folio, wbc, blkdev_get_block);
>   	blk_finish_plug(&plug);
>   
>   	return err;

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich