From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: "André Draszik" <andre.draszik@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dan.carpenter@linaro.org,
kernel-team@android.com, willmcvicker@google.com, arnd@arndb.de
Subject: Re: [PATCH 1/2] dt-bindings: soc: samsung: exynos-pmu: remove syscon for google,gs101-pmu
Date: Wed, 12 Nov 2025 11:23:47 +0100 [thread overview]
Message-ID: <065678f2-3fbe-448e-83ae-e8b3e7ba96b3@kernel.org> (raw)
In-Reply-To: <20251112-naughty-romantic-hamster-e213eb@kuoka>
On 12/11/2025 11:22, Krzysztof Kozlowski wrote:
>> oneOf:
>> + - items:
>
> I expect new version (see other comment), so also please change items
> into enum and drop const from below. items is redundant for one entry in
> compatible (by convention) and having it as enum already makes it ready
> for growing the enumeration for future devices.
>
>> + - const: google,gs101-pmu
>
Ah, and there is also checkpatch warning about length of commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-12 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 8:03 [PATCH 0/2] Remove syscon compatible from google,gs101-pmu node Peter Griffin
2025-11-03 8:03 ` [PATCH 1/2] dt-bindings: soc: samsung: exynos-pmu: remove syscon for google,gs101-pmu Peter Griffin
2025-11-05 8:55 ` Krzysztof Kozlowski
2025-11-11 10:18 ` Peter Griffin
2025-11-12 10:20 ` Krzysztof Kozlowski
2025-11-12 10:22 ` Krzysztof Kozlowski
2025-11-12 10:23 ` Krzysztof Kozlowski [this message]
2025-11-14 12:01 ` Peter Griffin
2025-11-03 8:03 ` [PATCH 2/2] arm64: dts: exynos: gs101: remove syscon compatible from pmu node Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=065678f2-3fbe-448e-83ae-e8b3e7ba96b3@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.