From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6850C41DED4; Wed, 29 Jul 2026 07:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785311870; cv=none; b=DK96iJlwYJYLvKhPqry/0Rxq1XWVmqdwQ+se9bo24rIzvPwea6XMt9o2WBWzgIkt3v5X+y9BqgNtwzgA91uXpzMYdlp0RMG6z3SQhZV0qqjArxZxjaDR9IdlZJQxA+JHZmbIC9Z627HBuTKL3Ch3cfiGLW/rNTJFQrYRAbnd5Qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785311870; c=relaxed/simple; bh=+euLKluyMF3W2+sQ67r8Zdp3MRXfRlsaoFs+3+JbtqM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EphRI2HUevEJ/LP5s5WOkd2jD+gsYKViQgNLSfNaoyzN74CYT06L7siMvGAlr/khou+jPg3DdQv8JERHDT6mSXcMudec7TPN//NFy/XvvwhAuDpDLvmm3+oab60cQpNFhoV5WwEaGooVYK0+IcpjmYh/lHQq7qCXcJzpVR2tW6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TW+0/X40; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TW+0/X40" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC6AE1F00A3A; Wed, 29 Jul 2026 07:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785311869; bh=JMQmjlizXD/vT0oZoSHqAMCq37tvcQYBTm+Tf/IEZkI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=TW+0/X40160A54H8+WMDBafVx4WJPTeDJisTe+42eYL60jOtT8wD4IBCg+pD3piCS vqm01f/91+GIZnO3KBUjuqkj434r3F8+AB6VPOsOO5c+IIUV96N6qE3/rOrhuLsUop PY+b5tPB1f5nSG46dv9vbah30Z7SAQPZzcORt03I9S5+qoc6H4jQAZF5QJRtH/cYt/ RwxJMWkB1Rs7WBirvcIWfJhrcsSzp038SAV2YBkcykxZQu1JzD0uxuH5mWz4Admwne lwMP2kpc2ogleJYvSJINzv41J9eAf31+JW0xEVwCIa3sl96R/iastnL8W97V9hwIPO ZNXR9Hg3942fg== Message-ID: <065a229b-e6a8-4cce-8725-9c2e19c8f463@kernel.org> Date: Wed, 29 Jul 2026 09:57:40 +0200 Precedence: bulk X-Mailing-List: spacemit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu To: Baihui Liang Cc: Frank Binns , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , dri-devel , devicetree , linux-kernel , linux-riscv , spacemit References: From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 29/07/2026 09:46, Baihui Liang wrote: > On Tue, Jul 28, 2026, Krzysztof Kozlowski wrote: > > > [...] > > > spacemit,k3-gpu is added to the existing ti,am62-gpu/ti,am62p-gpu/ > > > ti,j721s2-gpu "if" block that restricts clocks to a single entry, > > > since K3 has the same single-clock requirement. It does not match any > > > "if" block that constrains power-domains, so that property falls back > > > > I don't get this explanation. Are you explaining what the patch is doing > > or explaining WHY you did this that way? > > > That paragraph was describing schema mechanics, which does not belong in > a commit message. v4 will drop it and state only the hardware facts: the > K3 integration of the BXM-4-64 has a single "core" clock, and it has no > software-controllable GPU power domain. > > > > > to this schema's general constraints, where it is optional. This > > > leaves room for a power-domains provider to be added later without a > > > further binding change, should one ever be modelled in Linux for this > > > SoC. > > > > No, you need to provide constraints now. Please read carefully > > writing-bindings. > > > Understood. spacemit,k3-gpu currently matches no power-domains "if" > block, so it falls back to the top-level 1-2 domains with > power-domain-names "a"/"b". That would let a K3 DT with two power > domains pass validation, which does not describe this hardware. v4 will > add an explicit "if" block: > > >     - if: >         properties: >           compatible: >             contains: >               const: spacemit,k3-gpu >       then: >         properties: >           power-domains: false >           power-domain-names: false I understand only half of this. Please fix your email client. And why this reply misses reply-to header which connects it to proper thread? How am I supposed to find the thread now, among 200 I received yesterday? So your name is presented here as "Baihui Liang" then why do you use some fake company name? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C002C54F51 for ; Wed, 29 Jul 2026 07:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PXoWENmOMG5MInHSsQHrmiaF1qKm9CW5cmkqfqro1KU=; b=Jv+5MWH0kOkcu4 0lSwq8z91hC+nCuBxgt8LYH/0gFtHumAw00d8n7eMkA0xAwqitFz3qX/H32oP+bp+WIh3IR+fdrJW OIJZOAlzyNJbc+dME7l/7DHIckLaP2otwQytW4L52z8q5ZXaD4CImcF62PWrBzXEA/KDgJ2NZuk53 EG96c3Q6ATYjD+VSRnepNSY5IOg3uERXxvZaF/R1Z1PemCSXtvR2U0XhxGbbsJanoLKHW8dVaiRub jF09k/w2x5WOUc2AooKOpChUQOakFwccW8d1puRWIRUpoxTyBuLYVmR+o9Ogbx4kd7pl8fxKX7BB/ UnROw50Cu63sNJiaWZiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wozAl-00000007B4X-06I8; Wed, 29 Jul 2026 07:57:51 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wozAj-00000007B4Q-49vs for linux-riscv@lists.infradead.org; Wed, 29 Jul 2026 07:57:50 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 63B8643FAE; Wed, 29 Jul 2026 07:57:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC6AE1F00A3A; Wed, 29 Jul 2026 07:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785311869; bh=JMQmjlizXD/vT0oZoSHqAMCq37tvcQYBTm+Tf/IEZkI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=TW+0/X40160A54H8+WMDBafVx4WJPTeDJisTe+42eYL60jOtT8wD4IBCg+pD3piCS vqm01f/91+GIZnO3KBUjuqkj434r3F8+AB6VPOsOO5c+IIUV96N6qE3/rOrhuLsUop PY+b5tPB1f5nSG46dv9vbah30Z7SAQPZzcORt03I9S5+qoc6H4jQAZF5QJRtH/cYt/ RwxJMWkB1Rs7WBirvcIWfJhrcsSzp038SAV2YBkcykxZQu1JzD0uxuH5mWz4Admwne lwMP2kpc2ogleJYvSJINzv41J9eAf31+JW0xEVwCIa3sl96R/iastnL8W97V9hwIPO ZNXR9Hg3942fg== Message-ID: <065a229b-e6a8-4cce-8725-9c2e19c8f463@kernel.org> Date: Wed, 29 Jul 2026 09:57:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu To: Baihui Liang Cc: Frank Binns , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , dri-devel , devicetree , linux-kernel , linux-riscv , spacemit References: From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 29/07/2026 09:46, Baihui Liang wrote: > On Tue, Jul 28, 2026, Krzysztof Kozlowski wrote: > > > [...] > > > spacemit,k3-gpu is added to the existing ti,am62-gpu/ti,am62p-gpu/ > > > ti,j721s2-gpu "if" block that restricts clocks to a single entry, > > > since K3 has the same single-clock requirement. It does not match any > > > "if" block that constrains power-domains, so that property falls back > > > > I don't get this explanation. Are you explaining what the patch is doing > > or explaining WHY you did this that way? > > > That paragraph was describing schema mechanics, which does not belong in > a commit message. v4 will drop it and state only the hardware facts: the > K3 integration of the BXM-4-64 has a single "core" clock, and it has no > software-controllable GPU power domain. > > > > > to this schema's general constraints, where it is optional. This > > > leaves room for a power-domains provider to be added later without a > > > further binding change, should one ever be modelled in Linux for this > > > SoC. > > > > No, you need to provide constraints now. Please read carefully > > writing-bindings. > > > Understood. spacemit,k3-gpu currently matches no power-domains "if" > block, so it falls back to the top-level 1-2 domains with > power-domain-names "a"/"b". That would let a K3 DT with two power > domains pass validation, which does not describe this hardware. v4 will > add an explicit "if" block: > > >     - if: >         properties: >           compatible: >             contains: >               const: spacemit,k3-gpu >       then: >         properties: >           power-domains: false >           power-domain-names: false I understand only half of this. Please fix your email client. And why this reply misses reply-to header which connects it to proper thread? How am I supposed to find the thread now, among 200 I received yesterday? So your name is presented here as "Baihui Liang" then why do you use some fake company name? Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv