Re: [PATCH] x86: kexec is PV-only

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 30/06/2026 2:35 pm, Jan Beulich wrote:
> Kexec is of no use without its hypercall, and that hypercall is wired up
> only for PV. Allowing that code to be built when !PV therefore results in
> a lot of unreachable code, violating Misra C:2012 rule 2.1.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -22,7 +22,7 @@ config X86
>  	select HAS_EX_TABLE
>  	select HAS_FAST_MULTIPLY
>  	select HAS_IOPORTS
> -	select HAS_KEXEC
> +	select HAS_KEXEC if PV
>  	select HAS_NS16550
>  	select HAS_PASSTHROUGH
>  	select HAS_PCI

This might be true, but it's wrong.  kexec should be wired up for PVH
too, and I don't see any reason why it can't be.

~Andrew