From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC8EFC83F14 for ; Wed, 30 Aug 2023 10:25:47 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.592827.925661 (Exim 4.92) (envelope-from ) id 1qbIO8-0003vm-VN; Wed, 30 Aug 2023 10:25:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 592827.925661; Wed, 30 Aug 2023 10:25:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qbIO8-0003vf-Sg; Wed, 30 Aug 2023 10:25:28 +0000 Received: by outflank-mailman (input) for mailman id 592827; Wed, 30 Aug 2023 10:25:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qbIO8-0003vZ-7D for xen-devel@lists.xenproject.org; Wed, 30 Aug 2023 10:25:28 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85642d4f-471f-11ee-9b0d-b553b5be7939; Wed, 30 Aug 2023 12:25:21 +0200 (CEST) Received: from [192.168.8.109] (unknown [151.82.72.120]) by support.bugseng.com (Postfix) with ESMTPSA id C895C4EE0738; Wed, 30 Aug 2023 12:25:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85642d4f-471f-11ee-9b0d-b553b5be7939 Message-ID: <065c5b97-88b2-644b-8267-2e2f5958a9db@bugseng.com> Date: Wed, 30 Aug 2023 12:25:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 02/13] automation/eclair: add text-based deviation for empty headers Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein References: <96e9ca524ed8191bfd5ee1230e8d581c50e299f5.1693228255.git.simone.ballarin@bugseng.com> From: Simone Ballarin Organization: BUGSENG In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/08/23 00:00, Stefano Stabellini wrote: > On Mon, 28 Aug 2023, Simone Ballarin wrote: >> This patch adds a text-based deviation for Directive 4.10: >> "Precautions shall be taken in order to prevent the contents of >> a header file being included more than once" >> >> Headers starting with the following comment are not supposed to >> comply with the directive: >> "/* empty */" >> >> These headers should be empty, therefore they pose no risk if included >> more than once. >> >> Signed-off-by: Simone Ballarin > > Acked-by: Stefano Stabellini > > However I think we should also update rules.rst and/or update > docs/misra/safe.json I will do it in the next submission. > > >> --- >> automation/eclair_analysis/ECLAIR/deviations.ecl | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.ecl >> index 5f068377fa..2681a4cff5 100644 >> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl >> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl >> @@ -80,6 +80,7 @@ inline functions." >> >> -doc_begin="This header file is autogenerated or empty, therefore it poses no >> risk if included more than once." >> +-config=MC3R1.D4.10,reports+={safe, "first_area(text(^/\\* empty \\*/$, begin-1))"} >> -file_tag+={empty_header, "^xen/arch/arm/efi/runtime\\.h$"} >> -file_tag+={autogen_headers, "^xen/include/xen/compile\\.h$||^xen/include/generated/autoconf.h$||^xen/include/xen/hypercall-defs.h$"} >> -config=MC3R1.D4.10,reports+={safe, "all_area(all_loc(file(empty_header||autogen_headers)))"} >> -- >> 2.34.1 >> > -- Simone Ballarin, M.Sc. Field Application Engineer, BUGSENG (https://bugseng.com)