All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: hev <r@hev.cc>
Cc: Peter Xu <peterx@redhat.com>,
	Anatoly Pugachev <matorola@gmail.com>,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	Sparc kernel list <sparclinux@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Subject: Re: Test case for "mm/thp: carry over dirty bit when thp splits on pmd"
Date: Fri, 25 Nov 2022 12:17:27 +0100	[thread overview]
Message-ID: <06b0a108-0496-ad28-a88c-a4d2fd554ca8@redhat.com> (raw)
In-Reply-To: <CAHirt9gKYojqqj3ty1+kLwxOc9DbjPj_WzLvOvx0SnWaWFGc4g@mail.gmail.com>

On 25.11.22 12:15, hev wrote:
> Hi, David,
> 
>>
>> Just to ask again,
>>
>> is code like
>>          maybe_mkwrite(pte_mkdirty(entry), vma);
>>
>> Like we have in copy_present_page(), wp_page_reuse(), wp_page_copy() ...
>> broken on LoongArch of the VMA lacks VM_WRITE?
> 
> Sorry for the late reply. In this test case, The VMA doesn't lack VM_WRITE.
> 

Let me ask again: is this a problem in all of the functions I mentioned 
above were we *could* lack VM_WRITE?

Because that needs fixing independently of this issue here.

-- 
Thanks,

David / dhildenb


  reply	other threads:[~2022-11-25 11:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAHirt9gr7oL87co3y1hCs3Ux4utzFP5oj6GFOFMZuJR2Vv8+rA@mail.gmail.com>
2022-11-16 10:45 ` Test case for "mm/thp: carry over dirty bit when thp splits on pmd" Anatoly Pugachev
2022-11-16 11:28   ` David Hildenbrand
2022-11-16 16:25   ` Peter Xu
2022-11-17  2:29     ` hev
2022-11-17 18:28       ` Peter Xu
2022-11-19 14:06         ` hev
2022-11-21 19:57           ` David Hildenbrand
2022-11-25 11:15             ` hev
2022-11-25 11:17               ` David Hildenbrand [this message]
2022-11-25 11:35                 ` hev
2022-11-21 18:55   ` Peter Xu
2022-11-25 11:38     ` hev
2022-11-25 18:42       ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06b0a108-0496-ad28-a88c-a4d2fd554ca8@redhat.com \
    --to=david@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=matorola@gmail.com \
    --cc=peterx@redhat.com \
    --cc=r@hev.cc \
    --cc=regressions@leemhuis.info \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.