From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 23 Sep 2016 14:23:06 +0000 Subject: Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Message-Id: <06b207e3-88e7-8d8a-be2f-7ea7b2b7f218@users.sourceforge.net> List-Id: References: <20160922100257.GN13620@mwanda> <45c2ad6e-fadc-8d4a-f6bd-ddf8604ec622@users.sourceforge.net> <20160922202419.GP13620@mwanda> <65f2917b-4264-01a3-2441-367d1e3a313b@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Emil Velikov Cc: Bhaktipriya Shridhar , kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Julia Lawall , Daniel Vetter , Tejun Heo , Thierry Reding , Dan Carpenter >> I am trying to improve various open issues also in Linux source files. >> > That the fact that you see issues (in these particular cases) while > others do not I guess that the discussed "story" affects more challenges in communication and different opinions about where to invest software development attention. > indicates that the commit summary could be explained better. I imagine that there are a few improvement possibilities left over. > A good commit summary should provide enough information to do that This advice is generally fine. > and make people _want_ the patch. I guess that this expectation can become a research topic for some knowledge fields, can't it? There are update suggestion where the probability for acceptance is higher than for others. Some maintainers have got their own difficulties with changes when they categorise them as "ordinary clean-up". > From my limited experience through your patches (just skimmed a few) Thanks for your general interest. > you seems to be describing what the patch does My collection of update suggestions is evolving over some source code search patterns. I find that this approach fits to the recommended imperative wording style according to document "SubmittingPatches", doesn't it? I dared also some deviations or variations already. > as opposed to why it does it and why should one find it interesting/wanted. I am trying to express also this information to some degree. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() Date: Fri, 23 Sep 2016 16:23:06 +0200 Message-ID: <06b207e3-88e7-8d8a-be2f-7ea7b2b7f218@users.sourceforge.net> References: <20160922100257.GN13620@mwanda> <45c2ad6e-fadc-8d4a-f6bd-ddf8604ec622@users.sourceforge.net> <20160922202419.GP13620@mwanda> <65f2917b-4264-01a3-2441-367d1e3a313b@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mout.web.de (mout.web.de [212.227.15.3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9EF1E6EAA3 for ; Fri, 23 Sep 2016 14:23:32 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: Bhaktipriya Shridhar , kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Julia Lawall , Daniel Vetter , Tejun Heo , Thierry Reding , Dan Carpenter List-Id: dri-devel@lists.freedesktop.org Pj4gSSBhbSB0cnlpbmcgdG8gaW1wcm92ZSB2YXJpb3VzIG9wZW4gaXNzdWVzIGFsc28gaW4gTGlu dXggc291cmNlIGZpbGVzLgo+Pgo+IFRoYXQgdGhlIGZhY3QgdGhhdCB5b3Ugc2VlIGlzc3VlcyAo aW4gdGhlc2UgcGFydGljdWxhciBjYXNlcykgd2hpbGUKPiBvdGhlcnMgZG8gbm90CgpJIGd1ZXNz IHRoYXQgdGhlIGRpc2N1c3NlZCAic3RvcnkiIGFmZmVjdHMgbW9yZSBjaGFsbGVuZ2VzIGluIGNv bW11bmljYXRpb24KYW5kIGRpZmZlcmVudCBvcGluaW9ucyBhYm91dCB3aGVyZSB0byBpbnZlc3Qg c29mdHdhcmUgZGV2ZWxvcG1lbnQgYXR0ZW50aW9uLgoKCj4gaW5kaWNhdGVzIHRoYXQgdGhlIGNv bW1pdCBzdW1tYXJ5IGNvdWxkIGJlIGV4cGxhaW5lZCBiZXR0ZXIuCgpJIGltYWdpbmUgdGhhdCB0 aGVyZSBhcmUgYSBmZXcgaW1wcm92ZW1lbnQgcG9zc2liaWxpdGllcyBsZWZ0IG92ZXIuCgoKPiBB IGdvb2QgY29tbWl0IHN1bW1hcnkgc2hvdWxkIHByb3ZpZGUgZW5vdWdoIGluZm9ybWF0aW9uIHRv IGRvIHRoYXQKClRoaXMgYWR2aWNlIGlzIGdlbmVyYWxseSBmaW5lLgoKCj4gYW5kIG1ha2UgcGVv cGxlIF93YW50XyB0aGUgcGF0Y2guCgpJIGd1ZXNzIHRoYXQgdGhpcyBleHBlY3RhdGlvbiBjYW4g YmVjb21lIGEgcmVzZWFyY2ggdG9waWMgZm9yIHNvbWUga25vd2xlZGdlIGZpZWxkcywKY2FuJ3Qg aXQ/CgpUaGVyZSBhcmUgdXBkYXRlIHN1Z2dlc3Rpb24gd2hlcmUgdGhlIHByb2JhYmlsaXR5IGZv ciBhY2NlcHRhbmNlIGlzIGhpZ2hlcgp0aGFuIGZvciBvdGhlcnMuCgpTb21lIG1haW50YWluZXJz IGhhdmUgZ290IHRoZWlyIG93biBkaWZmaWN1bHRpZXMgd2l0aCBjaGFuZ2VzIHdoZW4gdGhleSBj YXRlZ29yaXNlCnRoZW0gYXMgIm9yZGluYXJ5IGNsZWFuLXVwIi4KCgo+IEZyb20gbXkgbGltaXRl ZCBleHBlcmllbmNlIHRocm91Z2ggeW91ciBwYXRjaGVzIChqdXN0IHNraW1tZWQgYSBmZXcpCgpU aGFua3MgZm9yIHlvdXIgZ2VuZXJhbCBpbnRlcmVzdC4KCgo+IHlvdSBzZWVtcyB0byBiZSBkZXNj cmliaW5nIHdoYXQgdGhlIHBhdGNoIGRvZXMKCk15IGNvbGxlY3Rpb24gb2YgdXBkYXRlIHN1Z2dl c3Rpb25zIGlzIGV2b2x2aW5nIG92ZXIgc29tZSBzb3VyY2UgY29kZSBzZWFyY2ggcGF0dGVybnMu CgpJIGZpbmQgdGhhdCB0aGlzIGFwcHJvYWNoIGZpdHMgdG8gdGhlIHJlY29tbWVuZGVkIGltcGVy YXRpdmUgd29yZGluZyBzdHlsZQphY2NvcmRpbmcgdG8gZG9jdW1lbnQgIlN1Ym1pdHRpbmdQYXRj aGVzIiwgZG9lc24ndCBpdD8KCkkgZGFyZWQgYWxzbyBzb21lIGRldmlhdGlvbnMgb3IgdmFyaWF0 aW9ucyBhbHJlYWR5LgoKCj4gYXMgb3Bwb3NlZCB0byB3aHkgaXQgZG9lcyBpdCBhbmQgd2h5IHNo b3VsZCBvbmUgZmluZCBpdCBpbnRlcmVzdGluZy93YW50ZWQuCgpJIGFtIHRyeWluZyB0byBleHBy ZXNzIGFsc28gdGhpcyBpbmZvcm1hdGlvbiB0byBzb21lIGRlZ3JlZS4KClJlZ2FyZHMsCk1hcmt1 cwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760240AbcIWOXq (ORCPT ); Fri, 23 Sep 2016 10:23:46 -0400 Received: from mout.web.de ([212.227.15.3]:57018 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759866AbcIWOXj (ORCPT ); Fri, 23 Sep 2016 10:23:39 -0400 Subject: Re: GPU-DRM-QXL: Move three assignments in qxl_device_init() To: Emil Velikov References: <20160922100257.GN13620@mwanda> <45c2ad6e-fadc-8d4a-f6bd-ddf8604ec622@users.sourceforge.net> <20160922202419.GP13620@mwanda> <65f2917b-4264-01a3-2441-367d1e3a313b@users.sourceforge.net> Cc: Dave Airlie , Bhaktipriya Shridhar , kernel-janitors@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org, Julia Lawall , Daniel Vetter , Tejun Heo , Thierry Reding , Dan Carpenter From: SF Markus Elfring Message-ID: <06b207e3-88e7-8d8a-be2f-7ea7b2b7f218@users.sourceforge.net> Date: Fri, 23 Sep 2016 16:23:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:DoYFPcsorhAfoL74RV/t799h5jPbGuaJ0w/9IcJLdC1UMptwwY0 YQXlrvvF8skYcHA6AyLbvq27QyDqv55lCJ94tsZy+vsEdnqJBg+gRtsFfx0eeL9VU9c7Fkq RcdDJOzmL415C/CbKUZgJh09zyl5lNAEzQfHnUmVI3yWJD2zAA10+ZEjvUrzBEZyPpKO9Hk zOOCri1If70M8zFXJIBNw== X-UI-Out-Filterresults: notjunk:1;V01:K0:oaKiESh3S4o=:qPmCZxCg4ZyhcVDTsCyTGW fWltz5tvevDNCtYzXoblf/Ro1d+RR9k4u2sEgJV+dYWpWa4RDW08Rdus9PYt+sxxLTfClz/we /v/S31kReiLUnUiVArJjnCicvxZ+Z1MErXudOsqbtjoNiO1IGQj166y9TQahGmSM7BbS2Yhbl rXqnmCIsMakUZFeI+O457EYdAPXYZBoZscDNe/BxjhF7c4LUj6VPyyP7bxpBGXpoMpcBGetiJ O4jMPyMse669dYILwasfFSvIXYeHhPHl5ACsW/8A9C2i9XZ149mkMHQ3ggqN+uQFErdTq+Mt0 P4BD9MkLbe2JdUpeEhlDI4Sw64cExiIbzQxX0vbrR/Jk+YJa3/fxbieh1+fqR/P+crDdz6+sU YqZ+6YgeLHQ/we/nRB8xaf/tpRDLwOiuT/Od+yHw/7hE0wPS6Vt8c6RC/MLuWI3IZbpJwPw7H FpYmM80pXROHEVesKEKK0aQkWJfqsdlSqmlNwgjoVEn7LoissGVX85rqY0GlfNP+o1qZLfjZ7 zXSv/0aEdQeZTc9PoFivrIVutyUuKFvjhmoByA5jQKx2tS9Zgc5tqWXOgmCmsiOe0IG+EIv3Z Xsp+Y1YNPiHhpOxQZvIzwoNVfjuU7W7f1GKfTy/IAECI7geNF5VePxpyfACXsNQlWhjpJdC4U C4vjpFkt3QyYB9qCtvH148MEn7Od2laBkdUSo19wJZnBhC6uvOpHUddfnQY+94XWbAmFvK6tH OgMnkS6xIAcRdF2UaVy1OEzcnObi8duakiIc+DImM5V/YBvDvvqTsHCKTmiB5Ul76EUlPsf2q 30O21In Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I am trying to improve various open issues also in Linux source files. >> > That the fact that you see issues (in these particular cases) while > others do not I guess that the discussed "story" affects more challenges in communication and different opinions about where to invest software development attention. > indicates that the commit summary could be explained better. I imagine that there are a few improvement possibilities left over. > A good commit summary should provide enough information to do that This advice is generally fine. > and make people _want_ the patch. I guess that this expectation can become a research topic for some knowledge fields, can't it? There are update suggestion where the probability for acceptance is higher than for others. Some maintainers have got their own difficulties with changes when they categorise them as "ordinary clean-up". > From my limited experience through your patches (just skimmed a few) Thanks for your general interest. > you seems to be describing what the patch does My collection of update suggestions is evolving over some source code search patterns. I find that this approach fits to the recommended imperative wording style according to document "SubmittingPatches", doesn't it? I dared also some deviations or variations already. > as opposed to why it does it and why should one find it interesting/wanted. I am trying to express also this information to some degree. Regards, Markus