From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE2F6C433E7 for ; Thu, 15 Oct 2020 13:57:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96B112080A for ; Thu, 15 Oct 2020 13:57:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rWAhsjFj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96B112080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 431AF6ED18; Thu, 15 Oct 2020 13:57:27 +0000 (UTC) Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BBA56ECF2; Thu, 15 Oct 2020 13:57:26 +0000 (UTC) Received: by mail-ej1-x642.google.com with SMTP id lw21so3762680ejb.6; Thu, 15 Oct 2020 06:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=eqy7Jg2fPCw6JKPfho3FMkiXLNsZ2vOMeF3B2A8Mojc=; b=rWAhsjFjxNV2tSGmRZgmV07f7lkrurQgCx9bPljwSM5dlr+cFdfNcNP8TqDYr6RpmV kJKrteO6A0BWcah5RksBap2thah0f3FCug6g9rOyet2tvKS6wLurIXPy+sSprVRdDpXO IOnftXETFpeSKiWgWdWvXjoSMVSdBSpoxhozwHThiDlqjFFzd9Q9u5Oejc6caqTfdyr4 wAOCXRStBQxEeLEOZzM3R4MwjLF5LE07MQ+q90DEXSJbdui7Ftt93dj8CphKOBSXE/1U TA9yRTGiIYdnvyfGyrO3NxXvENUg3bN9B4wUskFws67k2dcY70IkWJVmV0uurT9DwBTX hYoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=eqy7Jg2fPCw6JKPfho3FMkiXLNsZ2vOMeF3B2A8Mojc=; b=TLqMbZPU6GlxmoK50on3Qocg2Q1qbTb1njCkpw7q+Ua8X0vi+8wZvEGd2Fkw8hCKFT zgYb2YACgGZZ544vnnbnHltZoUXClCdAtlensz5m1Y4wRaQoyI3p9bKSW00NHEXvZBvJ 2Vs2blfKaelPQfz2XPanEDJeGVL21MsgFtDdPA6Dm/ZzmWxc8PL8SQyPHfJyjiYe3qdL HFrahaKKUXC9wppWMT29Uq/vEyQkn0i6D3fSp3oBo1TO3y8GrStQKdxOR66ZEBpZkqro svdoyCe4eEhP38d5tuPpyxk0LxnQbItAokQ5UH+dQ9KGAFhcsRLEnLb7eyVj4+kHKEnT supQ== X-Gm-Message-State: AOAM533+RDjsB8V7/QfGbSlt26j75OlAg8O5v7PifDiYzs44AL6Qtzlk 9wv4kuNpxdsKld4dC/NoUtU= X-Google-Smtp-Source: ABdhPJzF6r3Ll5i0gnC5JVk814gY1eCy0pl3+e4WV+JpVGbNy1VCb75/aaDOiQbf2OJV/MzOqd48ag== X-Received: by 2002:a17:906:f4f:: with SMTP id h15mr4501249ejj.17.1602770245105; Thu, 15 Oct 2020 06:57:25 -0700 (PDT) Received: from [192.168.137.56] (tmo-123-114.customers.d1-online.com. [80.187.123.114]) by smtp.gmail.com with ESMTPSA id i8sm1619354ejg.84.2020.10.15.06.57.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2020 06:57:24 -0700 (PDT) Subject: Re: [PATCH v4 01/10] drm/vram-helper: Remove invariant parameters from internal kmap function To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, alexander.deucher@amd.com, christian.koenig@amd.com, kraxel@redhat.com, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, christian.gmeiner@gmail.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, yuq825@gmail.com, bskeggs@redhat.com, robh@kernel.org, tomeu.vizoso@collabora.com, steven.price@arm.com, alyssa.rosenzweig@collabora.com, hjc@rock-chips.com, heiko@sntech.de, hdegoede@redhat.com, sean@poorly.run, eric@anholt.net, oleksandr_andrushchenko@epam.com, ray.huang@amd.com, sumit.semwal@linaro.org, emil.velikov@collabora.com, luben.tuikov@amd.com, apaneers@amd.com, linus.walleij@linaro.org, melissa.srw@gmail.com, chris@chris-wilson.co.uk, miaoqinglang@huawei.com References: <20201015123806.32416-1-tzimmermann@suse.de> <20201015123806.32416-2-tzimmermann@suse.de> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <06cab96a-5224-46dc-dbd2-8eb4950946cc@gmail.com> Date: Thu, 15 Oct 2020 15:57:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201015123806.32416-2-tzimmermann@suse.de> Content-Language: en-US X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, spice-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, etnaviv@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, Daniel Vetter , xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" QW0gMTUuMTAuMjAgdW0gMTQ6Mzcgc2NocmllYiBUaG9tYXMgWmltbWVybWFubjoKPiBUaGUgcGFy YW1ldGVycyBtYXAgYW5kIGlzX2lvbWVtIGFyZSBhbHdheXMgb2YgdGhlIHNhbWUgdmFsdWUuIFJl bW92ZWQgdGhlbQo+IHRvIHByZXBhcmVzIHRoZSBmdW5jdGlvbiBmb3IgY29udmVyc2lvbiB0byBz dHJ1Y3QgZG1hX2J1Zl9tYXAuCj4KPiB2NDoKPiAJKiBkb24ndCBjaGVjayBmb3IgIWttYXAtPnZp cnR1YWw7IHdpbGwgYWx3YXlzIGJlIGZhbHNlCj4KPiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgWmlt bWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KClJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmln IDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2Ry bV9nZW1fdnJhbV9oZWxwZXIuYyB8IDE4ICsrKystLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNo YW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZ2VtX3ZyYW1faGVscGVyLmMKPiBpbmRleCAzMjEzNDI5Zjg0NDQuLjJkNWVkMzA1MThmMSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV92cmFtX2hlbHBlci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYwo+IEBAIC0zODIsMzIgKzM4 MiwyMiBAQCBpbnQgZHJtX2dlbV92cmFtX3VucGluKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0 ICpnYm8pCj4gICB9Cj4gICBFWFBPUlRfU1lNQk9MKGRybV9nZW1fdnJhbV91bnBpbik7Cj4gICAK PiAtc3RhdGljIHZvaWQgKmRybV9nZW1fdnJhbV9rbWFwX2xvY2tlZChzdHJ1Y3QgZHJtX2dlbV92 cmFtX29iamVjdCAqZ2JvLAo+IC0JCQkJICAgICAgYm9vbCBtYXAsIGJvb2wgKmlzX2lvbWVtKQo+ ICtzdGF0aWMgdm9pZCAqZHJtX2dlbV92cmFtX2ttYXBfbG9ja2VkKHN0cnVjdCBkcm1fZ2VtX3Zy YW1fb2JqZWN0ICpnYm8pCj4gICB7Cj4gICAJaW50IHJldDsKPiAgIAlzdHJ1Y3QgdHRtX2JvX2tt YXBfb2JqICprbWFwID0gJmdiby0+a21hcDsKPiArCWJvb2wgaXNfaW9tZW07Cj4gICAKPiAgIAlp ZiAoZ2JvLT5rbWFwX3VzZV9jb3VudCA+IDApCj4gICAJCWdvdG8gb3V0Owo+ICAgCj4gLQlpZiAo a21hcC0+dmlydHVhbCB8fCAhbWFwKQo+IC0JCWdvdG8gb3V0Owo+IC0KPiAgIAlyZXQgPSB0dG1f Ym9fa21hcCgmZ2JvLT5ibywgMCwgZ2JvLT5iby5udW1fcGFnZXMsIGttYXApOwo+ICAgCWlmIChy ZXQpCj4gICAJCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gICAKPiAgIG91dDoKPiAtCWlmICgha21h cC0+dmlydHVhbCkgewo+IC0JCWlmIChpc19pb21lbSkKPiAtCQkJKmlzX2lvbWVtID0gZmFsc2U7 Cj4gLQkJcmV0dXJuIE5VTEw7IC8qIG5vdCBtYXBwZWQ7IGRvbid0IGluY3JlbWVudCByZWYgKi8K PiAtCX0KPiAgIAkrK2diby0+a21hcF91c2VfY291bnQ7Cj4gLQlpZiAoaXNfaW9tZW0pCj4gLQkJ cmV0dXJuIHR0bV9rbWFwX29ial92aXJ0dWFsKGttYXAsIGlzX2lvbWVtKTsKPiAtCXJldHVybiBr bWFwLT52aXJ0dWFsOwo+ICsJcmV0dXJuIHR0bV9rbWFwX29ial92aXJ0dWFsKGttYXAsICZpc19p b21lbSk7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2b2lkIGRybV9nZW1fdnJhbV9rdW5tYXBfbG9j a2VkKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0ICpnYm8pCj4gQEAgLTQ1Miw3ICs0NDIsNyBA QCB2b2lkICpkcm1fZ2VtX3ZyYW1fdm1hcChzdHJ1Y3QgZHJtX2dlbV92cmFtX29iamVjdCAqZ2Jv KQo+ICAgCXJldCA9IGRybV9nZW1fdnJhbV9waW5fbG9ja2VkKGdibywgMCk7Cj4gICAJaWYgKHJl dCkKPiAgIAkJZ290byBlcnJfdHRtX2JvX3VucmVzZXJ2ZTsKPiAtCWJhc2UgPSBkcm1fZ2VtX3Zy YW1fa21hcF9sb2NrZWQoZ2JvLCB0cnVlLCBOVUxMKTsKPiArCWJhc2UgPSBkcm1fZ2VtX3ZyYW1f a21hcF9sb2NrZWQoZ2JvKTsKPiAgIAlpZiAoSVNfRVJSKGJhc2UpKSB7Cj4gICAJCXJldCA9IFBU Ul9FUlIoYmFzZSk7Cj4gICAJCWdvdG8gZXJyX2RybV9nZW1fdnJhbV91bnBpbl9sb2NrZWQ7Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1h aWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D16C433DF for ; Thu, 15 Oct 2020 13:57:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA9C72080A for ; Thu, 15 Oct 2020 13:57:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jq0TWXAb"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rWAhsjFj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA9C72080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MWPqfOKu9JecvuGvTdE+LJvZudmuc7wqZiUxEaAtCek=; b=jq0TWXAbMI01vx /IxopNzgSiQbNtR7t/ZHHzSyDyECnWG2xnkQCmjiyTmMM2xAL3g7YYU414KvDROyTeVoD5ybIPACz VT9vsz7p/pfOLtFYwED8kv8LO/Oa0eycpgfV6U8E+98qn1GARALq9jyYrbCTcAMqeNYQgKsEZHqNy RrTg2G4rmi7eaKQP4SsnQ4QZDmjs7n7BRQKrATZFih75Hpix/dLXl1hg7pgdWv+cpbNssPIxBLpRG Rq3gNzxRZ4r5Z9qodE6IJ3TaWEmwsNwZ1LCh/BxUSCw8vPtICL0JVT0hpjK/JT3ZBwMw6TZiV4SQJ hrlhAD7RjVlJy6ZD3VHg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kT3l4-0000LF-3x; Thu, 15 Oct 2020 13:57:30 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kT3l2-0000KF-5j; Thu, 15 Oct 2020 13:57:28 +0000 Received: by mail-ej1-x642.google.com with SMTP id dt13so3722417ejb.12; Thu, 15 Oct 2020 06:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=eqy7Jg2fPCw6JKPfho3FMkiXLNsZ2vOMeF3B2A8Mojc=; b=rWAhsjFjxNV2tSGmRZgmV07f7lkrurQgCx9bPljwSM5dlr+cFdfNcNP8TqDYr6RpmV kJKrteO6A0BWcah5RksBap2thah0f3FCug6g9rOyet2tvKS6wLurIXPy+sSprVRdDpXO IOnftXETFpeSKiWgWdWvXjoSMVSdBSpoxhozwHThiDlqjFFzd9Q9u5Oejc6caqTfdyr4 wAOCXRStBQxEeLEOZzM3R4MwjLF5LE07MQ+q90DEXSJbdui7Ftt93dj8CphKOBSXE/1U TA9yRTGiIYdnvyfGyrO3NxXvENUg3bN9B4wUskFws67k2dcY70IkWJVmV0uurT9DwBTX hYoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=eqy7Jg2fPCw6JKPfho3FMkiXLNsZ2vOMeF3B2A8Mojc=; b=HWuFurlSMfCWAYVTh3nodt7ZLsfct+fBABCmaYjJl+p0tGA9+a5KVL+tdlDIC/BDRg finsw5gpRQ3KzxJKUwuTzakbf21+fbIgZ4k1iiom7z3aGh5EUIdCG7md8UOyyvSAlLs1 w8BnwBoNykWlnahaP3tpHaJ2MeRjXrxqtg8zzJUcfJJm7gomuNQGaDB9gPmGIdzjOTiM PZLP8x9c/Br0JE+siv/b14555jBy+WLQeEw+F5Fp7jM1tRCRaOPDt+1k1iPfhZhGCQzj orMYpT3WGxABWLDD8LwDwFTdQqB4ptPCRalyFN/Wg2RyujL5GZk0Z1AReYJyXG3E8cEw wgKA== X-Gm-Message-State: AOAM533ykd5Agg7d5CoUNxO2zimDA146lIum2HV9tno8RMVprMRr7FPG +kwELsxuUrxlo0gR1iK7W4E= X-Google-Smtp-Source: ABdhPJzF6r3Ll5i0gnC5JVk814gY1eCy0pl3+e4WV+JpVGbNy1VCb75/aaDOiQbf2OJV/MzOqd48ag== X-Received: by 2002:a17:906:f4f:: with SMTP id h15mr4501249ejj.17.1602770245105; Thu, 15 Oct 2020 06:57:25 -0700 (PDT) Received: from [192.168.137.56] (tmo-123-114.customers.d1-online.com. [80.187.123.114]) by smtp.gmail.com with ESMTPSA id i8sm1619354ejg.84.2020.10.15.06.57.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2020 06:57:24 -0700 (PDT) Subject: Re: [PATCH v4 01/10] drm/vram-helper: Remove invariant parameters from internal kmap function To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, alexander.deucher@amd.com, christian.koenig@amd.com, kraxel@redhat.com, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, christian.gmeiner@gmail.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, yuq825@gmail.com, bskeggs@redhat.com, robh@kernel.org, tomeu.vizoso@collabora.com, steven.price@arm.com, alyssa.rosenzweig@collabora.com, hjc@rock-chips.com, heiko@sntech.de, hdegoede@redhat.com, sean@poorly.run, eric@anholt.net, oleksandr_andrushchenko@epam.com, ray.huang@amd.com, sumit.semwal@linaro.org, emil.velikov@collabora.com, luben.tuikov@amd.com, apaneers@amd.com, linus.walleij@linaro.org, melissa.srw@gmail.com, chris@chris-wilson.co.uk, miaoqinglang@huawei.com References: <20201015123806.32416-1-tzimmermann@suse.de> <20201015123806.32416-2-tzimmermann@suse.de> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <06cab96a-5224-46dc-dbd2-8eb4950946cc@gmail.com> Date: Thu, 15 Oct 2020 15:57:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201015123806.32416-2-tzimmermann@suse.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201015_095728_231675_50676E5D X-CRM114-Status: GOOD ( 19.63 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, spice-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, etnaviv@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, Daniel Vetter , xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW0gMTUuMTAuMjAgdW0gMTQ6Mzcgc2NocmllYiBUaG9tYXMgWmltbWVybWFubjoKPiBUaGUgcGFy YW1ldGVycyBtYXAgYW5kIGlzX2lvbWVtIGFyZSBhbHdheXMgb2YgdGhlIHNhbWUgdmFsdWUuIFJl bW92ZWQgdGhlbQo+IHRvIHByZXBhcmVzIHRoZSBmdW5jdGlvbiBmb3IgY29udmVyc2lvbiB0byBz dHJ1Y3QgZG1hX2J1Zl9tYXAuCj4KPiB2NDoKPiAJKiBkb24ndCBjaGVjayBmb3IgIWttYXAtPnZp cnR1YWw7IHdpbGwgYWx3YXlzIGJlIGZhbHNlCj4KPiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgWmlt bWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KClJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmln IDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2Ry bV9nZW1fdnJhbV9oZWxwZXIuYyB8IDE4ICsrKystLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNo YW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZ2VtX3ZyYW1faGVscGVyLmMKPiBpbmRleCAzMjEzNDI5Zjg0NDQuLjJkNWVkMzA1MThmMSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV92cmFtX2hlbHBlci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYwo+IEBAIC0zODIsMzIgKzM4 MiwyMiBAQCBpbnQgZHJtX2dlbV92cmFtX3VucGluKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0 ICpnYm8pCj4gICB9Cj4gICBFWFBPUlRfU1lNQk9MKGRybV9nZW1fdnJhbV91bnBpbik7Cj4gICAK PiAtc3RhdGljIHZvaWQgKmRybV9nZW1fdnJhbV9rbWFwX2xvY2tlZChzdHJ1Y3QgZHJtX2dlbV92 cmFtX29iamVjdCAqZ2JvLAo+IC0JCQkJICAgICAgYm9vbCBtYXAsIGJvb2wgKmlzX2lvbWVtKQo+ ICtzdGF0aWMgdm9pZCAqZHJtX2dlbV92cmFtX2ttYXBfbG9ja2VkKHN0cnVjdCBkcm1fZ2VtX3Zy YW1fb2JqZWN0ICpnYm8pCj4gICB7Cj4gICAJaW50IHJldDsKPiAgIAlzdHJ1Y3QgdHRtX2JvX2tt YXBfb2JqICprbWFwID0gJmdiby0+a21hcDsKPiArCWJvb2wgaXNfaW9tZW07Cj4gICAKPiAgIAlp ZiAoZ2JvLT5rbWFwX3VzZV9jb3VudCA+IDApCj4gICAJCWdvdG8gb3V0Owo+ICAgCj4gLQlpZiAo a21hcC0+dmlydHVhbCB8fCAhbWFwKQo+IC0JCWdvdG8gb3V0Owo+IC0KPiAgIAlyZXQgPSB0dG1f Ym9fa21hcCgmZ2JvLT5ibywgMCwgZ2JvLT5iby5udW1fcGFnZXMsIGttYXApOwo+ICAgCWlmIChy ZXQpCj4gICAJCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gICAKPiAgIG91dDoKPiAtCWlmICgha21h cC0+dmlydHVhbCkgewo+IC0JCWlmIChpc19pb21lbSkKPiAtCQkJKmlzX2lvbWVtID0gZmFsc2U7 Cj4gLQkJcmV0dXJuIE5VTEw7IC8qIG5vdCBtYXBwZWQ7IGRvbid0IGluY3JlbWVudCByZWYgKi8K PiAtCX0KPiAgIAkrK2diby0+a21hcF91c2VfY291bnQ7Cj4gLQlpZiAoaXNfaW9tZW0pCj4gLQkJ cmV0dXJuIHR0bV9rbWFwX29ial92aXJ0dWFsKGttYXAsIGlzX2lvbWVtKTsKPiAtCXJldHVybiBr bWFwLT52aXJ0dWFsOwo+ICsJcmV0dXJuIHR0bV9rbWFwX29ial92aXJ0dWFsKGttYXAsICZpc19p b21lbSk7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2b2lkIGRybV9nZW1fdnJhbV9rdW5tYXBfbG9j a2VkKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0ICpnYm8pCj4gQEAgLTQ1Miw3ICs0NDIsNyBA QCB2b2lkICpkcm1fZ2VtX3ZyYW1fdm1hcChzdHJ1Y3QgZHJtX2dlbV92cmFtX29iamVjdCAqZ2Jv KQo+ICAgCXJldCA9IGRybV9nZW1fdnJhbV9waW5fbG9ja2VkKGdibywgMCk7Cj4gICAJaWYgKHJl dCkKPiAgIAkJZ290byBlcnJfdHRtX2JvX3VucmVzZXJ2ZTsKPiAtCWJhc2UgPSBkcm1fZ2VtX3Zy YW1fa21hcF9sb2NrZWQoZ2JvLCB0cnVlLCBOVUxMKTsKPiArCWJhc2UgPSBkcm1fZ2VtX3ZyYW1f a21hcF9sb2NrZWQoZ2JvKTsKPiAgIAlpZiAoSVNfRVJSKGJhc2UpKSB7Cj4gICAJCXJldCA9IFBU Ul9FUlIoYmFzZSk7Cj4gICAJCWdvdG8gZXJyX2RybV9nZW1fdnJhbV91bnBpbl9sb2NrZWQ7CgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9j a2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA5C3C433DF for ; Thu, 15 Oct 2020 13:57:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52ADC2223F for ; Thu, 15 Oct 2020 13:57:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rWAhsjFj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730026AbgJON52 (ORCPT ); Thu, 15 Oct 2020 09:57:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729498AbgJON52 (ORCPT ); Thu, 15 Oct 2020 09:57:28 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C941EC061755; Thu, 15 Oct 2020 06:57:26 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id p15so3766179ejm.7; Thu, 15 Oct 2020 06:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=eqy7Jg2fPCw6JKPfho3FMkiXLNsZ2vOMeF3B2A8Mojc=; b=rWAhsjFjxNV2tSGmRZgmV07f7lkrurQgCx9bPljwSM5dlr+cFdfNcNP8TqDYr6RpmV kJKrteO6A0BWcah5RksBap2thah0f3FCug6g9rOyet2tvKS6wLurIXPy+sSprVRdDpXO IOnftXETFpeSKiWgWdWvXjoSMVSdBSpoxhozwHThiDlqjFFzd9Q9u5Oejc6caqTfdyr4 wAOCXRStBQxEeLEOZzM3R4MwjLF5LE07MQ+q90DEXSJbdui7Ftt93dj8CphKOBSXE/1U TA9yRTGiIYdnvyfGyrO3NxXvENUg3bN9B4wUskFws67k2dcY70IkWJVmV0uurT9DwBTX hYoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=eqy7Jg2fPCw6JKPfho3FMkiXLNsZ2vOMeF3B2A8Mojc=; b=ZiRcefnAtWU4dqlUXuA72SMS54KcNm9aDkHtBjGQ9wCyuupkluZilFFh9TPHScwi7W 8SNTDOl3RRuW0maYrpOkuoPfbsNSAyynIRpVjOSya1l/T141p/mrQAiLc2PZE4tJAbrU PleDCY9lCIE/DiKkDK7b7d2It09OVTbrp5U/rctufoJPrD0/PaiNA5G0oOy7lSpEssYx 7nEj37bRSbsFYvcr33mCDlzy8Xb8O3ySkSSFEyW99X046CBWXWhXEqDZwv5pISg0SAhl j9tN9Se8jtuS4nfAW0ng/bCHH2xFes9YFBOvwEqUQQ4z9n5S4zItP/rPLienkMstxwLF 4lIg== X-Gm-Message-State: AOAM531e1OGsbHjXTFwdukCBri7/gXbcXu0222VzyM8SPB1JANOeaDwZ yHzFWCYirDcl6Gd88uEenJwcObVYidNAaw== X-Google-Smtp-Source: ABdhPJzF6r3Ll5i0gnC5JVk814gY1eCy0pl3+e4WV+JpVGbNy1VCb75/aaDOiQbf2OJV/MzOqd48ag== X-Received: by 2002:a17:906:f4f:: with SMTP id h15mr4501249ejj.17.1602770245105; Thu, 15 Oct 2020 06:57:25 -0700 (PDT) Received: from [192.168.137.56] (tmo-123-114.customers.d1-online.com. [80.187.123.114]) by smtp.gmail.com with ESMTPSA id i8sm1619354ejg.84.2020.10.15.06.57.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2020 06:57:24 -0700 (PDT) Reply-To: christian.koenig@amd.com Subject: Re: [PATCH v4 01/10] drm/vram-helper: Remove invariant parameters from internal kmap function To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, alexander.deucher@amd.com, christian.koenig@amd.com, kraxel@redhat.com, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, christian.gmeiner@gmail.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, yuq825@gmail.com, bskeggs@redhat.com, robh@kernel.org, tomeu.vizoso@collabora.com, steven.price@arm.com, alyssa.rosenzweig@collabora.com, hjc@rock-chips.com, heiko@sntech.de, hdegoede@redhat.com, sean@poorly.run, eric@anholt.net, oleksandr_andrushchenko@epam.com, ray.huang@amd.com, sumit.semwal@linaro.org, emil.velikov@collabora.com, luben.tuikov@amd.com, apaneers@amd.com, linus.walleij@linaro.org, melissa.srw@gmail.com, chris@chris-wilson.co.uk, miaoqinglang@huawei.com Cc: linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, nouveau@lists.freedesktop.org, Daniel Vetter , etnaviv@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, spice-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org References: <20201015123806.32416-1-tzimmermann@suse.de> <20201015123806.32416-2-tzimmermann@suse.de> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <06cab96a-5224-46dc-dbd2-8eb4950946cc@gmail.com> Date: Thu, 15 Oct 2020 15:57:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201015123806.32416-2-tzimmermann@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Am 15.10.20 um 14:37 schrieb Thomas Zimmermann: > The parameters map and is_iomem are always of the same value. Removed them > to prepares the function for conversion to struct dma_buf_map. > > v4: > * don't check for !kmap->virtual; will always be false > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Daniel Vetter Reviewed-by: Christian König > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 18 ++++-------------- > 1 file changed, 4 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c > index 3213429f8444..2d5ed30518f1 100644 > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > @@ -382,32 +382,22 @@ int drm_gem_vram_unpin(struct drm_gem_vram_object *gbo) > } > EXPORT_SYMBOL(drm_gem_vram_unpin); > > -static void *drm_gem_vram_kmap_locked(struct drm_gem_vram_object *gbo, > - bool map, bool *is_iomem) > +static void *drm_gem_vram_kmap_locked(struct drm_gem_vram_object *gbo) > { > int ret; > struct ttm_bo_kmap_obj *kmap = &gbo->kmap; > + bool is_iomem; > > if (gbo->kmap_use_count > 0) > goto out; > > - if (kmap->virtual || !map) > - goto out; > - > ret = ttm_bo_kmap(&gbo->bo, 0, gbo->bo.num_pages, kmap); > if (ret) > return ERR_PTR(ret); > > out: > - if (!kmap->virtual) { > - if (is_iomem) > - *is_iomem = false; > - return NULL; /* not mapped; don't increment ref */ > - } > ++gbo->kmap_use_count; > - if (is_iomem) > - return ttm_kmap_obj_virtual(kmap, is_iomem); > - return kmap->virtual; > + return ttm_kmap_obj_virtual(kmap, &is_iomem); > } > > static void drm_gem_vram_kunmap_locked(struct drm_gem_vram_object *gbo) > @@ -452,7 +442,7 @@ void *drm_gem_vram_vmap(struct drm_gem_vram_object *gbo) > ret = drm_gem_vram_pin_locked(gbo, 0); > if (ret) > goto err_ttm_bo_unreserve; > - base = drm_gem_vram_kmap_locked(gbo, true, NULL); > + base = drm_gem_vram_kmap_locked(gbo); > if (IS_ERR(base)) { > ret = PTR_ERR(base); > goto err_drm_gem_vram_unpin_locked; From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v4 01/10] drm/vram-helper: Remove invariant parameters from internal kmap function Date: Thu, 15 Oct 2020 15:57:14 +0200 Message-ID: <06cab96a-5224-46dc-dbd2-8eb4950946cc@gmail.com> References: <20201015123806.32416-1-tzimmermann@suse.de> <20201015123806.32416-2-tzimmermann@suse.de> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20201015123806.32416-2-tzimmermann@suse.de> Content-Language: en-US To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, alexander.deucher@amd.com, christian.koenig@amd.com, kraxel@redhat.com, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, christian.gmeiner@gmail.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, yuq825@gmail.com, bskeggs@redhat.com, robh@kernel.org, tomeu.vizoso@collabora.com, steven.price@arm.com, alyssa.rosenzweig@collabora.com, hjc@rock-chips.com, heiko@sntech.de, hdegoede@redhat.com, sean@poorly.run, eric@anholt.net, oleksandr_andrushchenko@epam.com, ray.huang@amd.com, sumit.semwal@linaro.org, emil.velikov@collabora.com, luben.tuik Cc: linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, nouveau@lists.freedesktop.org, Daniel Vetter , etnaviv@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, spice-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: nouveau.vger.kernel.org Am 15.10.20 um 14:37 schrieb Thomas Zimmermann: > The parameters map and is_iomem are always of the same value. Removed them > to prepares the function for conversion to struct dma_buf_map. > > v4: > * don't check for !kmap->virtual; will always be false > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Daniel Vetter Reviewed-by: Christian König > --- > drivers/gpu/drm/drm_gem_vram_helper.c | 18 ++++-------------- > 1 file changed, 4 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c > index 3213429f8444..2d5ed30518f1 100644 > --- a/drivers/gpu/drm/drm_gem_vram_helper.c > +++ b/drivers/gpu/drm/drm_gem_vram_helper.c > @@ -382,32 +382,22 @@ int drm_gem_vram_unpin(struct drm_gem_vram_object *gbo) > } > EXPORT_SYMBOL(drm_gem_vram_unpin); > > -static void *drm_gem_vram_kmap_locked(struct drm_gem_vram_object *gbo, > - bool map, bool *is_iomem) > +static void *drm_gem_vram_kmap_locked(struct drm_gem_vram_object *gbo) > { > int ret; > struct ttm_bo_kmap_obj *kmap = &gbo->kmap; > + bool is_iomem; > > if (gbo->kmap_use_count > 0) > goto out; > > - if (kmap->virtual || !map) > - goto out; > - > ret = ttm_bo_kmap(&gbo->bo, 0, gbo->bo.num_pages, kmap); > if (ret) > return ERR_PTR(ret); > > out: > - if (!kmap->virtual) { > - if (is_iomem) > - *is_iomem = false; > - return NULL; /* not mapped; don't increment ref */ > - } > ++gbo->kmap_use_count; > - if (is_iomem) > - return ttm_kmap_obj_virtual(kmap, is_iomem); > - return kmap->virtual; > + return ttm_kmap_obj_virtual(kmap, &is_iomem); > } > > static void drm_gem_vram_kunmap_locked(struct drm_gem_vram_object *gbo) > @@ -452,7 +442,7 @@ void *drm_gem_vram_vmap(struct drm_gem_vram_object *gbo) > ret = drm_gem_vram_pin_locked(gbo, 0); > if (ret) > goto err_ttm_bo_unreserve; > - base = drm_gem_vram_kmap_locked(gbo, true, NULL); > + base = drm_gem_vram_kmap_locked(gbo); > if (IS_ERR(base)) { > ret = PTR_ERR(base); > goto err_drm_gem_vram_unpin_locked; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E0A1C4363A for ; Thu, 15 Oct 2020 13:57:30 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08A9F2080A for ; Thu, 15 Oct 2020 13:57:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rWAhsjFj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08A9F2080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 726D1880BB; Thu, 15 Oct 2020 13:57:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25C0KSeCWgRY; Thu, 15 Oct 2020 13:57:28 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id D2D3F87FAF; Thu, 15 Oct 2020 13:57:28 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B40C8C0052; Thu, 15 Oct 2020 13:57:28 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id D95A0C0051 for ; Thu, 15 Oct 2020 13:57:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id BD54E880BB for ; Thu, 15 Oct 2020 13:57:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A0qOUBpX32jF for ; Thu, 15 Oct 2020 13:57:27 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by hemlock.osuosl.org (Postfix) with ESMTPS id CF73687FAF for ; Thu, 15 Oct 2020 13:57:26 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id t25so3713898ejd.13 for ; Thu, 15 Oct 2020 06:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=eqy7Jg2fPCw6JKPfho3FMkiXLNsZ2vOMeF3B2A8Mojc=; b=rWAhsjFjxNV2tSGmRZgmV07f7lkrurQgCx9bPljwSM5dlr+cFdfNcNP8TqDYr6RpmV kJKrteO6A0BWcah5RksBap2thah0f3FCug6g9rOyet2tvKS6wLurIXPy+sSprVRdDpXO IOnftXETFpeSKiWgWdWvXjoSMVSdBSpoxhozwHThiDlqjFFzd9Q9u5Oejc6caqTfdyr4 wAOCXRStBQxEeLEOZzM3R4MwjLF5LE07MQ+q90DEXSJbdui7Ftt93dj8CphKOBSXE/1U TA9yRTGiIYdnvyfGyrO3NxXvENUg3bN9B4wUskFws67k2dcY70IkWJVmV0uurT9DwBTX hYoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=eqy7Jg2fPCw6JKPfho3FMkiXLNsZ2vOMeF3B2A8Mojc=; b=r4WbPAAsk/MjqAZo9Vk4ssYkzF4vrgeg4xCnik1lbQV1fJJwwqyV0RWsy6/8OvdoqW sddxhBGXvsWZfeLZNOgW6GIcGKNN9AbayXIDqCBuA6nRuFC6GSkicqpc8Kr8ngYiRr/n I8RuV6jRemm+cv7nv/SaPLbEWkwUJKIWcWfkrVsAHzlsdYnsMmyxM+gL4RCTQYDiUPqN EnOZ2S7Pp05ApxG7tBUveTw1hLz5fyqRVmq9dPUEK0wtba18AApgkoHAMalliD4sIyd3 1EmgYTyeVlmaPJSrByZBb/OkNEeaic3+tpohYYcGXg/AZ1ZKI2MZKlYgWfTifmDwM6q0 2YQw== X-Gm-Message-State: AOAM532xt9DwGqs8pXWOeIg61mssct0/0nhUwm2/6nfD+bnaSNzq2gwp NVqv724RkdaK6HRn48wVkqI= X-Google-Smtp-Source: ABdhPJzF6r3Ll5i0gnC5JVk814gY1eCy0pl3+e4WV+JpVGbNy1VCb75/aaDOiQbf2OJV/MzOqd48ag== X-Received: by 2002:a17:906:f4f:: with SMTP id h15mr4501249ejj.17.1602770245105; Thu, 15 Oct 2020 06:57:25 -0700 (PDT) Received: from [192.168.137.56] (tmo-123-114.customers.d1-online.com. [80.187.123.114]) by smtp.gmail.com with ESMTPSA id i8sm1619354ejg.84.2020.10.15.06.57.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2020 06:57:24 -0700 (PDT) Subject: Re: [PATCH v4 01/10] drm/vram-helper: Remove invariant parameters from internal kmap function To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, alexander.deucher@amd.com, christian.koenig@amd.com, kraxel@redhat.com, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, christian.gmeiner@gmail.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, yuq825@gmail.com, bskeggs@redhat.com, robh@kernel.org, tomeu.vizoso@collabora.com, steven.price@arm.com, alyssa.rosenzweig@collabora.com, hjc@rock-chips.com, heiko@sntech.de, hdegoede@redhat.com, sean@poorly.run, eric@anholt.net, oleksandr_andrushchenko@epam.com, ray.huang@amd.com, sumit.semwal@linaro.org, emil.velikov@collabora.com, luben.tuikov@amd.com, apaneers@amd.com, linus.walleij@linaro.org, melissa.srw@gmail.com, chris@chris-wilson.co.uk, miaoqinglang@huawei.com References: <20201015123806.32416-1-tzimmermann@suse.de> <20201015123806.32416-2-tzimmermann@suse.de> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <06cab96a-5224-46dc-dbd2-8eb4950946cc@gmail.com> Date: Thu, 15 Oct 2020 15:57:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201015123806.32416-2-tzimmermann@suse.de> Content-Language: en-US Cc: linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, spice-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, etnaviv@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, Daniel Vetter , xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" QW0gMTUuMTAuMjAgdW0gMTQ6Mzcgc2NocmllYiBUaG9tYXMgWmltbWVybWFubjoKPiBUaGUgcGFy YW1ldGVycyBtYXAgYW5kIGlzX2lvbWVtIGFyZSBhbHdheXMgb2YgdGhlIHNhbWUgdmFsdWUuIFJl bW92ZWQgdGhlbQo+IHRvIHByZXBhcmVzIHRoZSBmdW5jdGlvbiBmb3IgY29udmVyc2lvbiB0byBz dHJ1Y3QgZG1hX2J1Zl9tYXAuCj4KPiB2NDoKPiAJKiBkb24ndCBjaGVjayBmb3IgIWttYXAtPnZp cnR1YWw7IHdpbGwgYWx3YXlzIGJlIGZhbHNlCj4KPiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgWmlt bWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KClJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmln IDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2Ry bV9nZW1fdnJhbV9oZWxwZXIuYyB8IDE4ICsrKystLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNo YW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZ2VtX3ZyYW1faGVscGVyLmMKPiBpbmRleCAzMjEzNDI5Zjg0NDQuLjJkNWVkMzA1MThmMSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV92cmFtX2hlbHBlci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYwo+IEBAIC0zODIsMzIgKzM4 MiwyMiBAQCBpbnQgZHJtX2dlbV92cmFtX3VucGluKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0 ICpnYm8pCj4gICB9Cj4gICBFWFBPUlRfU1lNQk9MKGRybV9nZW1fdnJhbV91bnBpbik7Cj4gICAK PiAtc3RhdGljIHZvaWQgKmRybV9nZW1fdnJhbV9rbWFwX2xvY2tlZChzdHJ1Y3QgZHJtX2dlbV92 cmFtX29iamVjdCAqZ2JvLAo+IC0JCQkJICAgICAgYm9vbCBtYXAsIGJvb2wgKmlzX2lvbWVtKQo+ ICtzdGF0aWMgdm9pZCAqZHJtX2dlbV92cmFtX2ttYXBfbG9ja2VkKHN0cnVjdCBkcm1fZ2VtX3Zy YW1fb2JqZWN0ICpnYm8pCj4gICB7Cj4gICAJaW50IHJldDsKPiAgIAlzdHJ1Y3QgdHRtX2JvX2tt YXBfb2JqICprbWFwID0gJmdiby0+a21hcDsKPiArCWJvb2wgaXNfaW9tZW07Cj4gICAKPiAgIAlp ZiAoZ2JvLT5rbWFwX3VzZV9jb3VudCA+IDApCj4gICAJCWdvdG8gb3V0Owo+ICAgCj4gLQlpZiAo a21hcC0+dmlydHVhbCB8fCAhbWFwKQo+IC0JCWdvdG8gb3V0Owo+IC0KPiAgIAlyZXQgPSB0dG1f Ym9fa21hcCgmZ2JvLT5ibywgMCwgZ2JvLT5iby5udW1fcGFnZXMsIGttYXApOwo+ICAgCWlmIChy ZXQpCj4gICAJCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gICAKPiAgIG91dDoKPiAtCWlmICgha21h cC0+dmlydHVhbCkgewo+IC0JCWlmIChpc19pb21lbSkKPiAtCQkJKmlzX2lvbWVtID0gZmFsc2U7 Cj4gLQkJcmV0dXJuIE5VTEw7IC8qIG5vdCBtYXBwZWQ7IGRvbid0IGluY3JlbWVudCByZWYgKi8K PiAtCX0KPiAgIAkrK2diby0+a21hcF91c2VfY291bnQ7Cj4gLQlpZiAoaXNfaW9tZW0pCj4gLQkJ cmV0dXJuIHR0bV9rbWFwX29ial92aXJ0dWFsKGttYXAsIGlzX2lvbWVtKTsKPiAtCXJldHVybiBr bWFwLT52aXJ0dWFsOwo+ICsJcmV0dXJuIHR0bV9rbWFwX29ial92aXJ0dWFsKGttYXAsICZpc19p b21lbSk7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2b2lkIGRybV9nZW1fdnJhbV9rdW5tYXBfbG9j a2VkKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0ICpnYm8pCj4gQEAgLTQ1Miw3ICs0NDIsNyBA QCB2b2lkICpkcm1fZ2VtX3ZyYW1fdm1hcChzdHJ1Y3QgZHJtX2dlbV92cmFtX29iamVjdCAqZ2Jv KQo+ICAgCXJldCA9IGRybV9nZW1fdnJhbV9waW5fbG9ja2VkKGdibywgMCk7Cj4gICAJaWYgKHJl dCkKPiAgIAkJZ290byBlcnJfdHRtX2JvX3VucmVzZXJ2ZTsKPiAtCWJhc2UgPSBkcm1fZ2VtX3Zy YW1fa21hcF9sb2NrZWQoZ2JvLCB0cnVlLCBOVUxMKTsKPiArCWJhc2UgPSBkcm1fZ2VtX3ZyYW1f a21hcF9sb2NrZWQoZ2JvKTsKPiAgIAlpZiAoSVNfRVJSKGJhc2UpKSB7Cj4gICAJCXJldCA9IFBU Ul9FUlIoYmFzZSk7Cj4gICAJCWdvdG8gZXJyX2RybV9nZW1fdnJhbV91bnBpbl9sb2NrZWQ7Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXph dGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5v cmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmly dHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F295C43467 for ; Thu, 15 Oct 2020 13:57:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C09C12080A for ; Thu, 15 Oct 2020 13:57:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rWAhsjFj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C09C12080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F2076ED19; Thu, 15 Oct 2020 13:57:27 +0000 (UTC) Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BBA56ECF2; Thu, 15 Oct 2020 13:57:26 +0000 (UTC) Received: by mail-ej1-x642.google.com with SMTP id lw21so3762680ejb.6; Thu, 15 Oct 2020 06:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=eqy7Jg2fPCw6JKPfho3FMkiXLNsZ2vOMeF3B2A8Mojc=; b=rWAhsjFjxNV2tSGmRZgmV07f7lkrurQgCx9bPljwSM5dlr+cFdfNcNP8TqDYr6RpmV kJKrteO6A0BWcah5RksBap2thah0f3FCug6g9rOyet2tvKS6wLurIXPy+sSprVRdDpXO IOnftXETFpeSKiWgWdWvXjoSMVSdBSpoxhozwHThiDlqjFFzd9Q9u5Oejc6caqTfdyr4 wAOCXRStBQxEeLEOZzM3R4MwjLF5LE07MQ+q90DEXSJbdui7Ftt93dj8CphKOBSXE/1U TA9yRTGiIYdnvyfGyrO3NxXvENUg3bN9B4wUskFws67k2dcY70IkWJVmV0uurT9DwBTX hYoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=eqy7Jg2fPCw6JKPfho3FMkiXLNsZ2vOMeF3B2A8Mojc=; b=TLqMbZPU6GlxmoK50on3Qocg2Q1qbTb1njCkpw7q+Ua8X0vi+8wZvEGd2Fkw8hCKFT zgYb2YACgGZZ544vnnbnHltZoUXClCdAtlensz5m1Y4wRaQoyI3p9bKSW00NHEXvZBvJ 2Vs2blfKaelPQfz2XPanEDJeGVL21MsgFtDdPA6Dm/ZzmWxc8PL8SQyPHfJyjiYe3qdL HFrahaKKUXC9wppWMT29Uq/vEyQkn0i6D3fSp3oBo1TO3y8GrStQKdxOR66ZEBpZkqro svdoyCe4eEhP38d5tuPpyxk0LxnQbItAokQ5UH+dQ9KGAFhcsRLEnLb7eyVj4+kHKEnT supQ== X-Gm-Message-State: AOAM533+RDjsB8V7/QfGbSlt26j75OlAg8O5v7PifDiYzs44AL6Qtzlk 9wv4kuNpxdsKld4dC/NoUtU= X-Google-Smtp-Source: ABdhPJzF6r3Ll5i0gnC5JVk814gY1eCy0pl3+e4WV+JpVGbNy1VCb75/aaDOiQbf2OJV/MzOqd48ag== X-Received: by 2002:a17:906:f4f:: with SMTP id h15mr4501249ejj.17.1602770245105; Thu, 15 Oct 2020 06:57:25 -0700 (PDT) Received: from [192.168.137.56] (tmo-123-114.customers.d1-online.com. [80.187.123.114]) by smtp.gmail.com with ESMTPSA id i8sm1619354ejg.84.2020.10.15.06.57.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2020 06:57:24 -0700 (PDT) Subject: Re: [PATCH v4 01/10] drm/vram-helper: Remove invariant parameters from internal kmap function To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, alexander.deucher@amd.com, christian.koenig@amd.com, kraxel@redhat.com, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, christian.gmeiner@gmail.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, yuq825@gmail.com, bskeggs@redhat.com, robh@kernel.org, tomeu.vizoso@collabora.com, steven.price@arm.com, alyssa.rosenzweig@collabora.com, hjc@rock-chips.com, heiko@sntech.de, hdegoede@redhat.com, sean@poorly.run, eric@anholt.net, oleksandr_andrushchenko@epam.com, ray.huang@amd.com, sumit.semwal@linaro.org, emil.velikov@collabora.com, luben.tuikov@amd.com, apaneers@amd.com, linus.walleij@linaro.org, melissa.srw@gmail.com, chris@chris-wilson.co.uk, miaoqinglang@huawei.com References: <20201015123806.32416-1-tzimmermann@suse.de> <20201015123806.32416-2-tzimmermann@suse.de> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <06cab96a-5224-46dc-dbd2-8eb4950946cc@gmail.com> Date: Thu, 15 Oct 2020 15:57:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201015123806.32416-2-tzimmermann@suse.de> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: linux-samsung-soc@vger.kernel.org, lima@lists.freedesktop.org, spice-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, etnaviv@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linaro-mm-sig@lists.linaro.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, Daniel Vetter , xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" QW0gMTUuMTAuMjAgdW0gMTQ6Mzcgc2NocmllYiBUaG9tYXMgWmltbWVybWFubjoKPiBUaGUgcGFy YW1ldGVycyBtYXAgYW5kIGlzX2lvbWVtIGFyZSBhbHdheXMgb2YgdGhlIHNhbWUgdmFsdWUuIFJl bW92ZWQgdGhlbQo+IHRvIHByZXBhcmVzIHRoZSBmdW5jdGlvbiBmb3IgY29udmVyc2lvbiB0byBz dHJ1Y3QgZG1hX2J1Zl9tYXAuCj4KPiB2NDoKPiAJKiBkb24ndCBjaGVjayBmb3IgIWttYXAtPnZp cnR1YWw7IHdpbGwgYWx3YXlzIGJlIGZhbHNlCj4KPiBTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgWmlt bWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KClJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmln IDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2Ry bV9nZW1fdnJhbV9oZWxwZXIuYyB8IDE4ICsrKystLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNo YW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZ2VtX3ZyYW1faGVscGVyLmMKPiBpbmRleCAzMjEzNDI5Zjg0NDQuLjJkNWVkMzA1MThmMSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV92cmFtX2hlbHBlci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fdnJhbV9oZWxwZXIuYwo+IEBAIC0zODIsMzIgKzM4 MiwyMiBAQCBpbnQgZHJtX2dlbV92cmFtX3VucGluKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0 ICpnYm8pCj4gICB9Cj4gICBFWFBPUlRfU1lNQk9MKGRybV9nZW1fdnJhbV91bnBpbik7Cj4gICAK PiAtc3RhdGljIHZvaWQgKmRybV9nZW1fdnJhbV9rbWFwX2xvY2tlZChzdHJ1Y3QgZHJtX2dlbV92 cmFtX29iamVjdCAqZ2JvLAo+IC0JCQkJICAgICAgYm9vbCBtYXAsIGJvb2wgKmlzX2lvbWVtKQo+ ICtzdGF0aWMgdm9pZCAqZHJtX2dlbV92cmFtX2ttYXBfbG9ja2VkKHN0cnVjdCBkcm1fZ2VtX3Zy YW1fb2JqZWN0ICpnYm8pCj4gICB7Cj4gICAJaW50IHJldDsKPiAgIAlzdHJ1Y3QgdHRtX2JvX2tt YXBfb2JqICprbWFwID0gJmdiby0+a21hcDsKPiArCWJvb2wgaXNfaW9tZW07Cj4gICAKPiAgIAlp ZiAoZ2JvLT5rbWFwX3VzZV9jb3VudCA+IDApCj4gICAJCWdvdG8gb3V0Owo+ICAgCj4gLQlpZiAo a21hcC0+dmlydHVhbCB8fCAhbWFwKQo+IC0JCWdvdG8gb3V0Owo+IC0KPiAgIAlyZXQgPSB0dG1f Ym9fa21hcCgmZ2JvLT5ibywgMCwgZ2JvLT5iby5udW1fcGFnZXMsIGttYXApOwo+ICAgCWlmIChy ZXQpCj4gICAJCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gICAKPiAgIG91dDoKPiAtCWlmICgha21h cC0+dmlydHVhbCkgewo+IC0JCWlmIChpc19pb21lbSkKPiAtCQkJKmlzX2lvbWVtID0gZmFsc2U7 Cj4gLQkJcmV0dXJuIE5VTEw7IC8qIG5vdCBtYXBwZWQ7IGRvbid0IGluY3JlbWVudCByZWYgKi8K PiAtCX0KPiAgIAkrK2diby0+a21hcF91c2VfY291bnQ7Cj4gLQlpZiAoaXNfaW9tZW0pCj4gLQkJ cmV0dXJuIHR0bV9rbWFwX29ial92aXJ0dWFsKGttYXAsIGlzX2lvbWVtKTsKPiAtCXJldHVybiBr bWFwLT52aXJ0dWFsOwo+ICsJcmV0dXJuIHR0bV9rbWFwX29ial92aXJ0dWFsKGttYXAsICZpc19p b21lbSk7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2b2lkIGRybV9nZW1fdnJhbV9rdW5tYXBfbG9j a2VkKHN0cnVjdCBkcm1fZ2VtX3ZyYW1fb2JqZWN0ICpnYm8pCj4gQEAgLTQ1Miw3ICs0NDIsNyBA QCB2b2lkICpkcm1fZ2VtX3ZyYW1fdm1hcChzdHJ1Y3QgZHJtX2dlbV92cmFtX29iamVjdCAqZ2Jv KQo+ICAgCXJldCA9IGRybV9nZW1fdnJhbV9waW5fbG9ja2VkKGdibywgMCk7Cj4gICAJaWYgKHJl dCkKPiAgIAkJZ290byBlcnJfdHRtX2JvX3VucmVzZXJ2ZTsKPiAtCWJhc2UgPSBkcm1fZ2VtX3Zy YW1fa21hcF9sb2NrZWQoZ2JvLCB0cnVlLCBOVUxMKTsKPiArCWJhc2UgPSBkcm1fZ2VtX3ZyYW1f a21hcF9sb2NrZWQoZ2JvKTsKPiAgIAlpZiAoSVNfRVJSKGJhc2UpKSB7Cj4gICAJCXJldCA9IFBU Ul9FUlIoYmFzZSk7Cj4gICAJCWdvdG8gZXJyX2RybV9nZW1fdnJhbV91bnBpbl9sb2NrZWQ7Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK