From: Heiner Kallweit <hkallweit1@gmail.com>
To: Realtek linux nic maintainers <nic_swsd@realtek.com>,
David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Chun-Hao Lin <hau@realtek.com>
Subject: [PATCH net-next v2 2/9] r8169: restrict rtl_is_8168evl_up to RTL8168 chip versions
Date: Wed, 28 Aug 2019 22:24:54 +0200 [thread overview]
Message-ID: <06dccc41-712f-0eec-3304-8f82c296aa4b@gmail.com> (raw)
In-Reply-To: <8181244b-24ac-73e2-bac7-d01f644ebb3f@gmail.com>
Extend helper rtl_is_8168evl_up to properly work once we add
mac version numbers >51 for RTL8125.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index bf00c3d8f..e9d900c11 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -730,7 +730,8 @@ static void rtl_tx_performance_tweak(struct rtl8169_private *tp, u16 force)
static bool rtl_is_8168evl_up(struct rtl8169_private *tp)
{
return tp->mac_version >= RTL_GIGA_MAC_VER_34 &&
- tp->mac_version != RTL_GIGA_MAC_VER_39;
+ tp->mac_version != RTL_GIGA_MAC_VER_39 &&
+ tp->mac_version <= RTL_GIGA_MAC_VER_51;
}
static bool rtl_supports_eee(struct rtl8169_private *tp)
--
2.23.0
next prev parent reply other threads:[~2019-08-28 20:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 20:23 [PATCH net-next v2 0/9] r8169: add support for RTL8125 Heiner Kallweit
2019-08-28 20:24 ` [PATCH net-next v2 1/9] r8169: change interrupt mask type to u32 Heiner Kallweit
2019-08-28 20:24 ` Heiner Kallweit [this message]
2019-08-28 20:25 ` [PATCH net-next v2 3/9] r8169: factor out reading MAC address from registers Heiner Kallweit
2019-08-28 20:26 ` [PATCH net-next v2 4/9] r8169: move disabling interrupt coalescing to RTL8169/RTL8168 init Heiner Kallweit
2019-08-28 20:26 ` [PATCH net-next v2 5/9] r8169: read common register for PCI commit Heiner Kallweit
2019-08-28 20:27 ` [PATCH net-next v2 6/9] r8169: don't use bit LastFrag in tx descriptor after send Heiner Kallweit
2019-08-29 0:29 ` Jakub Kicinski
2019-08-28 20:28 ` [PATCH net-next v2 7/9] r8169: add support for RTL8125 Heiner Kallweit
2019-08-28 20:28 ` [PATCH net-next v2 8/9] r8169: add RTL8125 PHY initialization Heiner Kallweit
2019-08-28 20:29 ` [PATCH net-next v2 9/9] r8169: add support for EEE on RTL8125 Heiner Kallweit
2019-08-30 0:47 ` [PATCH net-next v2 0/9] r8169: add support for RTL8125 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06dccc41-712f-0eec-3304-8f82c296aa4b@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=hau@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.