Re: [PATCH v3 bpf-next 1/3] bpf: Verify BTF_KIND_LOC_PARAM vlen, flags

[Alan Maguire <alan.maguire@oracle.com>]

On 29/09/2026 11:43, Alexei Starovoitov wrote:
> On Sat, Sep 26, 2026 at 06:51 PM Alan Maguire <alan.maguire@oracle.com> wrote:
>> +	case BTF_LOC_PARAM_CONST | BTF_LOC_PARAM_ADDR | BTF_LOC_PARAM_SIGNED:
>> +		if (vlen > 2)
>> +			goto invalid_vlen;
>> +		/* Ensure size/vlen are consistent */
>> +		if (size > sizeof(__u32) && vlen != 2)
>> +			goto invalid_vlen;
>> +		if (size > sizeof(__u64))
>> +			goto invalid_vlen;
>> +		break;
> 
> size <= 4 with vlen == 2 is still accepted.
> For size=4 values={1, 2} bpftool prints 'const 0x200000001'
> and 'const 0x1' when SIGNED is set.
> pahole emits one word for size <= 4 and two otherwise.
> Should it be
> 	if (vlen != (size > 4 ? 2 : 1))
> ?
> 
> Applied anyway, but pls followup.
> 

good catch, will do. thanks!