From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] ipv6: anycast: use call_rcu_hurry() in aca_put()
Date: Mon, 29 Apr 2024 12:51:59 -0600 [thread overview]
Message-ID: <06e75c94-1015-404b-ae41-2ef3bfa34352@kernel.org> (raw)
In-Reply-To: <20240429183643.2029108-1-edumazet@google.com>
On 4/29/24 12:36 PM, Eric Dumazet wrote:
> This is a followup of commit b5327b9a300e ("ipv6: use
> call_rcu_hurry() in fib6_info_release()").
>
> I had another pmtu.sh failure, and found another lazy
> call_rcu() causing this failure.
>
> aca_free_rcu() calls fib6_info_release() which releases
> devices references.
>
> We must not delay it too much or risk unregister_netdevice/ref_tracker
> traces because references to netdev are not released in time.
>
> This should speedup device/netns dismantles when CONFIG_RCU_LAZY=y
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> net/ipv6/anycast.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2024-04-29 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 18:36 [PATCH net-next] ipv6: anycast: use call_rcu_hurry() in aca_put() Eric Dumazet
2024-04-29 18:51 ` David Ahern [this message]
2024-05-01 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06e75c94-1015-404b-ae41-2ef3bfa34352@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.