From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B2FC4727E for ; Tue, 22 Sep 2020 10:56:00 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20E16208A9 for ; Tue, 22 Sep 2020 10:56:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="Ib38aDSC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20E16208A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKfxd-0002Ux-BF; Tue, 22 Sep 2020 10:55:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKfxc-0002Ur-F4 for xen-devel@lists.xenproject.org; Tue, 22 Sep 2020 10:55:48 +0000 X-Inumbo-ID: 2f66a6df-e2bb-40a4-8785-e7a52fe459dc Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f66a6df-e2bb-40a4-8785-e7a52fe459dc; Tue, 22 Sep 2020 10:55:47 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1600772147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WsxmnTpJ9ra2LqLMu+0tjkgsk1No9arrjJKBn1aKa5U=; b=Ib38aDSCYPGFatbr7j7I0ST8VSA/iL+1IQfq0ZFeIVDbYB6KUk7Uc9Rz65Wr6bI/Lrx6Dk 1SqV7fMDCrnrSiP7h33Vfqr62JNPC4raCUR8rigqwzoYQDzFQnqAZirtJ4hNY+3p5pc7OA GJ3qVVtPGa2tbrxrnNOIKnFsWNYoipw= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A50B7B234; Tue, 22 Sep 2020 10:56:23 +0000 (UTC) Subject: Re: Ping: [PATCH 1/9] build: use if_changed more consistently (and correctly) for prelink*.o To: Julien Grall Cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: <75d94bf1-b419-8a82-2d15-fb02e56109d8@suse.com> <43a4240c-baba-ca52-0a9f-a884c0f297be@xen.org> <0a0ab7a6-e448-3ffe-3818-4b97edbffb72@xen.org> From: Jan Beulich Message-ID: <070a7b89-28c7-a709-660e-97c3a8a93c94@suse.com> Date: Tue, 22 Sep 2020 12:55:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <0a0ab7a6-e448-3ffe-3818-4b97edbffb72@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 22.09.2020 11:24, Julien Grall wrote: > On 22/09/2020 09:28, Jan Beulich wrote: >> On 21.09.2020 13:39, Julien Grall wrote: >>> On 21/09/2020 11:17, Jan Beulich wrote: >>>> On 14.09.2020 12:15, Jan Beulich wrote: >>>>> Switch to $(call if_changed,ld) where possible; presumably not doing so >>>>> in e321576f4047 ("xen/build: start using if_changed") right away was an >>>>> oversight, as it did for Arm in (just) one case. It failed to add >>>>> prelink.o to $(targets), though, causing - judging from the observed >>>>> behavior on x86 - undue rebuilds of the final binary (because of >>>>> prelink.o getting rebuild for $(cmd_prelink.o) being empty, in turn >>>>> because of .prelink.o.cmd not getting read) during "make install-xen". >>>>> >>>>> Signed-off-by: Jan Beulich >>>>> --- >>>>> xen/arch/arm/Makefile | 4 +++- >>>>> xen/arch/x86/Makefile | 18 ++++++++++-------- >>>>> 2 files changed, 13 insertions(+), 9 deletions(-) >>>> >>>> May I ask for an Arm-side ack (or otherwise) here, please? >>> >>> Acked-by: Julien Grall >> >> Thanks. On the Arm side this is actually addressing a (minor) bug, > > Just to confirm, the bug is: Xen will be rebuilt when it is not > necessary, right? Yes. When building as non-root but installing as root, this would typically involve an owner change of some of the involved files. That's how I did notice the issue on x86 (after switching to if_changed) in the first place. Jan