All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guopeng Zhang <guopeng.zhang@linux.dev>
To: Michal Hocko <mhocko@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>,
	Muchun Song <muchun.song@linux.dev>,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Guopeng Zhang <zhangguopeng@kylinos.cn>
Subject: Re: [PATCH] mm: memcg: stop reclaim when a limit update is superseded
Date: Thu, 30 Jul 2026 09:48:44 +0800	[thread overview]
Message-ID: <0710df28-5870-4d33-aba1-085756290856@linux.dev> (raw)
In-Reply-To: <ammzjkUIADCxO2mP@tiehlicka>



在 2026/7/29 16:02, Michal Hocko 写道:
> On Wed 29-07-26 14:15:25, Guopeng Zhang wrote:
>>
>>
>> 在 2026/7/27 21:58, Michal Hocko 写道:
>>> On Mon 27-07-26 20:59:23, Guopeng Zhang wrote:
>>>>
>>>>
>>>> 在 2026/7/27 16:16, Michal Hocko 写道:
>>>>> On Fri 24-07-26 10:18:05, Guopeng Zhang wrote:
> [...]
>>> Is this trying to replicate any real workload? One would expect that
>>> writers to limit do some sort of coordination otherwise the exact
>>> behavior is not really well defined.
>>>
>>
>> No, this was not motivated by a reported production workload. We found
>> it through automated randomized testing for our cgroup observability
>> work and reduced it to the reproducer above.
> 
> This is an important detail to be mentioned in the changelog. Describing
> motivation for a change is really important, especially if it has direct
> impact in user interface behavior.

Thanks for the guidance. I will take the feedback from this patch into 
account when preparing similar changes in the future.


      parent reply	other threads:[~2026-07-30  1:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  2:18 [PATCH] mm: memcg: stop reclaim when a limit update is superseded Guopeng Zhang
2026-07-24  3:32 ` Tao Cui
2026-07-24  6:53   ` Guopeng Zhang
2026-07-26  3:42 ` Andrew Morton
2026-07-26  5:57   ` Guopeng Zhang
2026-07-27  8:16 ` Michal Hocko
2026-07-27 12:59   ` Guopeng Zhang
2026-07-27 13:58     ` Michal Hocko
2026-07-29  6:15       ` Guopeng Zhang
2026-07-29  8:02         ` Michal Hocko
2026-07-29 19:11           ` Andrew Morton
2026-07-29 19:36             ` Johannes Weiner
2026-07-30  1:48           ` Guopeng Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0710df28-5870-4d33-aba1-085756290856@linux.dev \
    --to=guopeng.zhang@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=zhangguopeng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.