From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from m42-4.mailgun.net ([69.72.42.4]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdAFz-0000N8-Df for ath10k@lists.infradead.org; Thu, 12 Nov 2020 10:55:13 +0000 MIME-Version: 1.0 Date: Thu, 12 Nov 2020 18:55:08 +0800 From: Wen Gong Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable In-Reply-To: <20170308132022.4216-1-johannes@sipsolutions.net> (sfid-20170308_142122_587641_AAD67C42) References: <20170308132022.4216-1-johannes@sipsolutions.net> (sfid-20170308_142122_587641_AAD67C42) Message-ID: <07179008e9369bc81e152009ca85191d@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: Johannes Berg , kirtika@google.com, linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org T24gMjAxNy0wMy0wOCAyMToyMCwgSm9oYW5uZXMgQmVyZyB3cm90ZToKPiBGcm9tOiBKb2hhbm5l cyBCZXJnIDxqb2hhbm5lcy5iZXJnQGludGVsLmNvbT4KPiAKPiBJZiB0aGUgdXNlciByYXRlIG1h c2sgcmVzdWx0cyBpbiBubyAoYmFzaWMpIHJhdGVzIGJlaW5nIHVzYWJsZSwKPiBjbGVhciBpdC4g QWxzbywgaWYgd2UncmUgYWxyZWFkeSBvcGVyYXRpbmcgd2hlbiBpdCdzIHNldCwgcmVqZWN0Cj4g aXQgaW5zdGVhZC4KPiAKPiBUZWNobmljYWxseSwgc2VsZWN0aW5nIGJhc2ljIHJhdGVzIGFzIHRo ZSBjcml0ZXJpb24gaXMgYSBiaXQgdG9vCj4gcmVzdHJpY3RpdmUsIGJ1dCBjYWxjdWxhdGluZyB0 aGUgdXNhYmxlIHJhdGVzIG92ZXIgYWxsIHN0YXRpb25zCj4gKGUuZy4gaW4gQVAgbW9kZSkgaXMg aGFyZGVyLCBhbmQgYWxsIHN0YXRpb25zIG11c3Qgc3VwcG9ydCB0aGUKPiBiYXNpYyByYXRlcy4g U2ltaWxhcmx5LCBpbiBjbGllbnQgbW9kZSwgdGhlIGJhc2ljIHJhdGVzIHdpbGwgYmUKPiB1c2Vk IGFueXdheSBmb3IgY29udHJvbCBmcmFtZXMuCj4gCj4gVGhpcyBmaXhlcyB0aGUgIm5vIHN1cHBv cnRlZCByYXRlcyAoLi4uKSBpbiByYXRlX21hc2sgLi4uIiB3YXJuaW5nCj4gdGhhdCBvY2N1cnMg b24gVFggd2hlbiB5b3UndmUgc2VsZWN0ZWQgYSByYXRlIG1hc2sgdGhhdCdzIG5vdAo+IGNvbXBh dGlibGUgd2l0aCB0aGUgY29ubmVjdGlvbiAoZS5nLiBhbiBBUCB0aGF0IGVuYWJsZXMgb25seSB0 aGUKPiByYXRlcyAzNiwgNDgsIDU0IGFuZCB5b3UndmUgc2VsZWN0ZWQgb25seSA2LCA5LCAxMi4p Cj4gCj4gUmVwb3J0ZWQtYnk6IEtpcnRpa2EgUnVjaGFuZGFuaSA8a2lydGlrYUBnb29nbGUuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IEpvaGFubmVzIEJlcmcgPGpvaGFubmVzLmJlcmdAaW50ZWwuY29t Pgo+IC0tLQo+ICBuZXQvbWFjODAyMTEvY2ZnLmMgIHwgMTggKysrKysrKysrKysrKysrKystCj4g IG5ldC9tYWM4MDIxMS9tbG1lLmMgfCAgMiArKwo+ICBuZXQvbWFjODAyMTEvcmF0ZS5jIHwgMjcg KysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIG5ldC9tYWM4MDIxMS9yYXRlLmggfCAgMiAr Kwo+ICA0IGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAK PiBkaWZmIC0tZ2l0IGEvbmV0L21hYzgwMjExL2NmZy5jIGIvbmV0L21hYzgwMjExL2NmZy5jCj4g aW5kZXggOWM3NDkwY2IyMjQzLi44YmMzZDM2NjkzNDggMTAwNjQ0Cj4gLS0tIGEvbmV0L21hYzgw MjExL2NmZy5jCj4gKysrIGIvbmV0L21hYzgwMjExL2NmZy5jCj4gQEAgLTMsNyArMyw3IEBACj4g ICAqCj4gICAqIENvcHlyaWdodCAyMDA2LTIwMTAJSm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lw c29sdXRpb25zLm5ldD4KPiAgICogQ29weXJpZ2h0IDIwMTMtMjAxNSAgSW50ZWwgTW9iaWxlIENv bW11bmljYXRpb25zIEdtYkgKPiAtICogQ29weXJpZ2h0IChDKSAyMDE1LTIwMTYgSW50ZWwgRGV1 dHNjaGxhbmQgR21iSAo+ICsgKiBDb3B5cmlnaHQgKEMpIDIwMTUtMjAxNyBJbnRlbCBEZXV0c2No bGFuZCBHbWJICj4gICAqCj4gICAqIFRoaXMgZmlsZSBpcyBHUEx2MiBhcyBmb3VuZCBpbiBDT1BZ SU5HLgo+ICAgKi8KPiBAQCAtMjA0Miw2ICsyMDQyLDcgQEAgc3RhdGljIGludCBpZWVlODAyMTFf Y2hhbmdlX2JzcyhzdHJ1Y3Qgd2lwaHkgCj4gKndpcGh5LAo+ICAJCQkJCSBwYXJhbXMtPmJhc2lj X3JhdGVzX2xlbiwKPiAgCQkJCQkgJnNkYXRhLT52aWYuYnNzX2NvbmYuYmFzaWNfcmF0ZXMpOwo+ ICAJCWNoYW5nZWQgfD0gQlNTX0NIQU5HRURfQkFTSUNfUkFURVM7Cj4gKwkJaWVlZTgwMjExX2No ZWNrX3JhdGVfbWFzayhzZGF0YSk7Cj4gIAl9Cj4gCj4gIAlpZiAocGFyYW1zLT5hcF9pc29sYXRl ID49IDApIHsKPiBAQCAtMjY4NSw2ICsyNjg2LDIxIEBAIHN0YXRpYyBpbnQgaWVlZTgwMjExX3Nl dF9iaXRyYXRlX21hc2soc3RydWN0Cj4gd2lwaHkgKndpcGh5LAo+ICAJCQlyZXR1cm4gcmV0Owo+ ICAJfQo+IAo+ICsJLyoKPiArCSAqIElmIGFjdGl2ZSB2YWxpZGF0ZSB0aGUgc2V0dGluZyBhbmQg cmVqZWN0IGl0IGlmIGl0IGRvZXNuJ3QgbGVhdmUKPiArCSAqIGF0IGxlYXN0IG9uZSBiYXNpYyBy YXRlIHVzYWJsZSwgc2luY2Ugd2UgcmVhbGx5IGhhdmUgdG8gYmUgYWJsZQo+ICsJICogdG8gc2Vu ZCBzb21ldGhpbmcsIGFuZCBpZiB3ZSdyZSBhbiBBUCB3ZSBoYXZlIHRvIGJlIGFibGUgdG8gZG8K PiArCSAqIHNvIGF0IGEgYmFzaWMgcmF0ZSBzbyB0aGF0IGFsbCBjbGllbnRzIGNhbiByZWNlaXZl IGl0Lgo+ICsJICovCj4gKwlpZiAocmN1X2FjY2Vzc19wb2ludGVyKHNkYXRhLT52aWYuY2hhbmN0 eF9jb25mKSAmJgo+ICsJICAgIHNkYXRhLT52aWYuYnNzX2NvbmYuY2hhbmRlZi5jaGFuKSB7Cj4g KwkJdTMyIGJhc2ljX3JhdGVzID0gc2RhdGEtPnZpZi5ic3NfY29uZi5iYXNpY19yYXRlczsKPiAr CQllbnVtIG5sODAyMTFfYmFuZCBiYW5kID0gc2RhdGEtPnZpZi5ic3NfY29uZi5jaGFuZGVmLmNo YW4tPmJhbmQ7Cj4gKwo+ICsJCWlmICghKG1hc2stPmNvbnRyb2xbYmFuZF0ubGVnYWN5ICYgYmFz aWNfcmF0ZXMpKQo+ICsJCQlyZXR1cm4gLUVJTlZBTDsKSWYgdXNlciB3YW50IHRvIHVzZSDigJxp dyB3bGFuMCBzZXQgYml0cmF0ZXMgbGVnYWN5LTUgNTTigJ0gdG8gc2V0IGl0IHRvIApmaXhlZCBp biA1NE0gYW5kIDU0TSBpcwpub3QgYmFzaWMgcmF0ZSBpbiBBUCdzIGJlY2FvbiBhcyBleGFtcGxl IG9mIGJlbG93LCB0aGVuIHRoZSBpdyBjb21tYW5kIAp3aWxsIGZhaWwuCgpUYWc6IFN1cHBvcnRl ZCBSYXRlcyA2KEIpLCA5LCAxMihCKSwgMTgsIDI0KEIpLCAzNiwgNDgsIDU0LCBbTWJpdC9zZWNd CiAgICAgVGFnIE51bWJlcjogU3VwcG9ydGVkIFJhdGVzICgxKQogICAgIFRhZyBsZW5ndGg6IDgK ICAgICBTdXBwb3J0ZWQgUmF0ZXM6IDYoQikgKDB4OGMpCiAgICAgU3VwcG9ydGVkIFJhdGVzOiA5 ICgweDEyKQogICAgIFN1cHBvcnRlZCBSYXRlczogMTIoQikgKDB4OTgpCiAgICAgU3VwcG9ydGVk IFJhdGVzOiAxOCAoMHgyNCkKICAgICBTdXBwb3J0ZWQgUmF0ZXM6IDI0KEIpICgweGIwKQogICAg IFN1cHBvcnRlZCBSYXRlczogMzYgKDB4NDgpCiAgICAgU3VwcG9ydGVkIFJhdGVzOiA0OCAoMHg2 MCkKICAgICBTdXBwb3J0ZWQgUmF0ZXM6IDU0ICgweDZjKQoKPiArCX0KPiArCj4gIAlmb3IgKGkg PSAwOyBpIDwgTlVNX05MODAyMTFfQkFORFM7IGkrKykgewo+ICAJCXN0cnVjdCBpZWVlODAyMTFf c3VwcG9ydGVkX2JhbmQgKnNiYW5kID0gd2lwaHktPmJhbmRzW2ldOwo+ICAJCWludCBqOwouLi4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBt YWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from m42-4.mailgun.net ([69.72.42.4]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdAFz-0000N7-Di for ath11k@lists.infradead.org; Thu, 12 Nov 2020 10:55:13 +0000 MIME-Version: 1.0 Date: Thu, 12 Nov 2020 18:55:08 +0800 From: Wen Gong Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable In-Reply-To: <20170308132022.4216-1-johannes@sipsolutions.net> (sfid-20170308_142122_587641_AAD67C42) References: <20170308132022.4216-1-johannes@sipsolutions.net> (sfid-20170308_142122_587641_AAD67C42) Message-ID: <07179008e9369bc81e152009ca85191d@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: Johannes Berg , kirtika@google.com, linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org T24gMjAxNy0wMy0wOCAyMToyMCwgSm9oYW5uZXMgQmVyZyB3cm90ZToKPiBGcm9tOiBKb2hhbm5l cyBCZXJnIDxqb2hhbm5lcy5iZXJnQGludGVsLmNvbT4KPiAKPiBJZiB0aGUgdXNlciByYXRlIG1h c2sgcmVzdWx0cyBpbiBubyAoYmFzaWMpIHJhdGVzIGJlaW5nIHVzYWJsZSwKPiBjbGVhciBpdC4g QWxzbywgaWYgd2UncmUgYWxyZWFkeSBvcGVyYXRpbmcgd2hlbiBpdCdzIHNldCwgcmVqZWN0Cj4g aXQgaW5zdGVhZC4KPiAKPiBUZWNobmljYWxseSwgc2VsZWN0aW5nIGJhc2ljIHJhdGVzIGFzIHRo ZSBjcml0ZXJpb24gaXMgYSBiaXQgdG9vCj4gcmVzdHJpY3RpdmUsIGJ1dCBjYWxjdWxhdGluZyB0 aGUgdXNhYmxlIHJhdGVzIG92ZXIgYWxsIHN0YXRpb25zCj4gKGUuZy4gaW4gQVAgbW9kZSkgaXMg aGFyZGVyLCBhbmQgYWxsIHN0YXRpb25zIG11c3Qgc3VwcG9ydCB0aGUKPiBiYXNpYyByYXRlcy4g U2ltaWxhcmx5LCBpbiBjbGllbnQgbW9kZSwgdGhlIGJhc2ljIHJhdGVzIHdpbGwgYmUKPiB1c2Vk IGFueXdheSBmb3IgY29udHJvbCBmcmFtZXMuCj4gCj4gVGhpcyBmaXhlcyB0aGUgIm5vIHN1cHBv cnRlZCByYXRlcyAoLi4uKSBpbiByYXRlX21hc2sgLi4uIiB3YXJuaW5nCj4gdGhhdCBvY2N1cnMg b24gVFggd2hlbiB5b3UndmUgc2VsZWN0ZWQgYSByYXRlIG1hc2sgdGhhdCdzIG5vdAo+IGNvbXBh dGlibGUgd2l0aCB0aGUgY29ubmVjdGlvbiAoZS5nLiBhbiBBUCB0aGF0IGVuYWJsZXMgb25seSB0 aGUKPiByYXRlcyAzNiwgNDgsIDU0IGFuZCB5b3UndmUgc2VsZWN0ZWQgb25seSA2LCA5LCAxMi4p Cj4gCj4gUmVwb3J0ZWQtYnk6IEtpcnRpa2EgUnVjaGFuZGFuaSA8a2lydGlrYUBnb29nbGUuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IEpvaGFubmVzIEJlcmcgPGpvaGFubmVzLmJlcmdAaW50ZWwuY29t Pgo+IC0tLQo+ICBuZXQvbWFjODAyMTEvY2ZnLmMgIHwgMTggKysrKysrKysrKysrKysrKystCj4g IG5ldC9tYWM4MDIxMS9tbG1lLmMgfCAgMiArKwo+ICBuZXQvbWFjODAyMTEvcmF0ZS5jIHwgMjcg KysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIG5ldC9tYWM4MDIxMS9yYXRlLmggfCAgMiAr Kwo+ICA0IGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAK PiBkaWZmIC0tZ2l0IGEvbmV0L21hYzgwMjExL2NmZy5jIGIvbmV0L21hYzgwMjExL2NmZy5jCj4g aW5kZXggOWM3NDkwY2IyMjQzLi44YmMzZDM2NjkzNDggMTAwNjQ0Cj4gLS0tIGEvbmV0L21hYzgw MjExL2NmZy5jCj4gKysrIGIvbmV0L21hYzgwMjExL2NmZy5jCj4gQEAgLTMsNyArMyw3IEBACj4g ICAqCj4gICAqIENvcHlyaWdodCAyMDA2LTIwMTAJSm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lw c29sdXRpb25zLm5ldD4KPiAgICogQ29weXJpZ2h0IDIwMTMtMjAxNSAgSW50ZWwgTW9iaWxlIENv bW11bmljYXRpb25zIEdtYkgKPiAtICogQ29weXJpZ2h0IChDKSAyMDE1LTIwMTYgSW50ZWwgRGV1 dHNjaGxhbmQgR21iSAo+ICsgKiBDb3B5cmlnaHQgKEMpIDIwMTUtMjAxNyBJbnRlbCBEZXV0c2No bGFuZCBHbWJICj4gICAqCj4gICAqIFRoaXMgZmlsZSBpcyBHUEx2MiBhcyBmb3VuZCBpbiBDT1BZ SU5HLgo+ICAgKi8KPiBAQCAtMjA0Miw2ICsyMDQyLDcgQEAgc3RhdGljIGludCBpZWVlODAyMTFf Y2hhbmdlX2JzcyhzdHJ1Y3Qgd2lwaHkgCj4gKndpcGh5LAo+ICAJCQkJCSBwYXJhbXMtPmJhc2lj X3JhdGVzX2xlbiwKPiAgCQkJCQkgJnNkYXRhLT52aWYuYnNzX2NvbmYuYmFzaWNfcmF0ZXMpOwo+ ICAJCWNoYW5nZWQgfD0gQlNTX0NIQU5HRURfQkFTSUNfUkFURVM7Cj4gKwkJaWVlZTgwMjExX2No ZWNrX3JhdGVfbWFzayhzZGF0YSk7Cj4gIAl9Cj4gCj4gIAlpZiAocGFyYW1zLT5hcF9pc29sYXRl ID49IDApIHsKPiBAQCAtMjY4NSw2ICsyNjg2LDIxIEBAIHN0YXRpYyBpbnQgaWVlZTgwMjExX3Nl dF9iaXRyYXRlX21hc2soc3RydWN0Cj4gd2lwaHkgKndpcGh5LAo+ICAJCQlyZXR1cm4gcmV0Owo+ ICAJfQo+IAo+ICsJLyoKPiArCSAqIElmIGFjdGl2ZSB2YWxpZGF0ZSB0aGUgc2V0dGluZyBhbmQg cmVqZWN0IGl0IGlmIGl0IGRvZXNuJ3QgbGVhdmUKPiArCSAqIGF0IGxlYXN0IG9uZSBiYXNpYyBy YXRlIHVzYWJsZSwgc2luY2Ugd2UgcmVhbGx5IGhhdmUgdG8gYmUgYWJsZQo+ICsJICogdG8gc2Vu ZCBzb21ldGhpbmcsIGFuZCBpZiB3ZSdyZSBhbiBBUCB3ZSBoYXZlIHRvIGJlIGFibGUgdG8gZG8K PiArCSAqIHNvIGF0IGEgYmFzaWMgcmF0ZSBzbyB0aGF0IGFsbCBjbGllbnRzIGNhbiByZWNlaXZl IGl0Lgo+ICsJICovCj4gKwlpZiAocmN1X2FjY2Vzc19wb2ludGVyKHNkYXRhLT52aWYuY2hhbmN0 eF9jb25mKSAmJgo+ICsJICAgIHNkYXRhLT52aWYuYnNzX2NvbmYuY2hhbmRlZi5jaGFuKSB7Cj4g KwkJdTMyIGJhc2ljX3JhdGVzID0gc2RhdGEtPnZpZi5ic3NfY29uZi5iYXNpY19yYXRlczsKPiAr CQllbnVtIG5sODAyMTFfYmFuZCBiYW5kID0gc2RhdGEtPnZpZi5ic3NfY29uZi5jaGFuZGVmLmNo YW4tPmJhbmQ7Cj4gKwo+ICsJCWlmICghKG1hc2stPmNvbnRyb2xbYmFuZF0ubGVnYWN5ICYgYmFz aWNfcmF0ZXMpKQo+ICsJCQlyZXR1cm4gLUVJTlZBTDsKSWYgdXNlciB3YW50IHRvIHVzZSDigJxp dyB3bGFuMCBzZXQgYml0cmF0ZXMgbGVnYWN5LTUgNTTigJ0gdG8gc2V0IGl0IHRvIApmaXhlZCBp biA1NE0gYW5kIDU0TSBpcwpub3QgYmFzaWMgcmF0ZSBpbiBBUCdzIGJlY2FvbiBhcyBleGFtcGxl IG9mIGJlbG93LCB0aGVuIHRoZSBpdyBjb21tYW5kIAp3aWxsIGZhaWwuCgpUYWc6IFN1cHBvcnRl ZCBSYXRlcyA2KEIpLCA5LCAxMihCKSwgMTgsIDI0KEIpLCAzNiwgNDgsIDU0LCBbTWJpdC9zZWNd CiAgICAgVGFnIE51bWJlcjogU3VwcG9ydGVkIFJhdGVzICgxKQogICAgIFRhZyBsZW5ndGg6IDgK ICAgICBTdXBwb3J0ZWQgUmF0ZXM6IDYoQikgKDB4OGMpCiAgICAgU3VwcG9ydGVkIFJhdGVzOiA5 ICgweDEyKQogICAgIFN1cHBvcnRlZCBSYXRlczogMTIoQikgKDB4OTgpCiAgICAgU3VwcG9ydGVk IFJhdGVzOiAxOCAoMHgyNCkKICAgICBTdXBwb3J0ZWQgUmF0ZXM6IDI0KEIpICgweGIwKQogICAg IFN1cHBvcnRlZCBSYXRlczogMzYgKDB4NDgpCiAgICAgU3VwcG9ydGVkIFJhdGVzOiA0OCAoMHg2 MCkKICAgICBTdXBwb3J0ZWQgUmF0ZXM6IDU0ICgweDZjKQoKPiArCX0KPiArCj4gIAlmb3IgKGkg PSAwOyBpIDwgTlVNX05MODAyMTFfQkFORFM7IGkrKykgewo+ICAJCXN0cnVjdCBpZWVlODAyMTFf c3VwcG9ydGVkX2JhbmQgKnNiYW5kID0gd2lwaHktPmJhbmRzW2ldOwo+ICAJCWludCBqOwouLi4K Ci0tIAphdGgxMWsgbWFpbGluZyBsaXN0CmF0aDExa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTFrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB6E8C2D0A3 for ; Thu, 12 Nov 2020 10:55:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A7DB22201 for ; Thu, 12 Nov 2020 10:55:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726107AbgKLKzL (ORCPT ); Thu, 12 Nov 2020 05:55:11 -0500 Received: from z5.mailgun.us ([104.130.96.5]:21630 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbgKLKzL (ORCPT ); Thu, 12 Nov 2020 05:55:11 -0500 X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5fad148ef2d9c8cbca569baf (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 12 Nov 2020 10:55:10 GMT Sender: wgong=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D7ECDC433F0; Thu, 12 Nov 2020 10:55:09 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id AC67FC433C8; Thu, 12 Nov 2020 10:55:08 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 12 Nov 2020 18:55:08 +0800 From: Wen Gong To: Johannes Berg Cc: linux-wireless@vger.kernel.org, kirtika@google.com, Johannes Berg , linux-wireless-owner@vger.kernel.org, ath11k@lists.infradead.org, ath10k@lists.infradead.org Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable In-Reply-To: <20170308132022.4216-1-johannes@sipsolutions.net> (sfid-20170308_142122_587641_AAD67C42) References: <20170308132022.4216-1-johannes@sipsolutions.net> (sfid-20170308_142122_587641_AAD67C42) Message-ID: <07179008e9369bc81e152009ca85191d@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2017-03-08 21:20, Johannes Berg wrote: > From: Johannes Berg > > If the user rate mask results in no (basic) rates being usable, > clear it. Also, if we're already operating when it's set, reject > it instead. > > Technically, selecting basic rates as the criterion is a bit too > restrictive, but calculating the usable rates over all stations > (e.g. in AP mode) is harder, and all stations must support the > basic rates. Similarly, in client mode, the basic rates will be > used anyway for control frames. > > This fixes the "no supported rates (...) in rate_mask ..." warning > that occurs on TX when you've selected a rate mask that's not > compatible with the connection (e.g. an AP that enables only the > rates 36, 48, 54 and you've selected only 6, 9, 12.) > > Reported-by: Kirtika Ruchandani > Signed-off-by: Johannes Berg > --- > net/mac80211/cfg.c | 18 +++++++++++++++++- > net/mac80211/mlme.c | 2 ++ > net/mac80211/rate.c | 27 +++++++++++++++++++++++++++ > net/mac80211/rate.h | 2 ++ > 4 files changed, 48 insertions(+), 1 deletion(-) > > diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c > index 9c7490cb2243..8bc3d3669348 100644 > --- a/net/mac80211/cfg.c > +++ b/net/mac80211/cfg.c > @@ -3,7 +3,7 @@ > * > * Copyright 2006-2010 Johannes Berg > * Copyright 2013-2015 Intel Mobile Communications GmbH > - * Copyright (C) 2015-2016 Intel Deutschland GmbH > + * Copyright (C) 2015-2017 Intel Deutschland GmbH > * > * This file is GPLv2 as found in COPYING. > */ > @@ -2042,6 +2042,7 @@ static int ieee80211_change_bss(struct wiphy > *wiphy, > params->basic_rates_len, > &sdata->vif.bss_conf.basic_rates); > changed |= BSS_CHANGED_BASIC_RATES; > + ieee80211_check_rate_mask(sdata); > } > > if (params->ap_isolate >= 0) { > @@ -2685,6 +2686,21 @@ static int ieee80211_set_bitrate_mask(struct > wiphy *wiphy, > return ret; > } > > + /* > + * If active validate the setting and reject it if it doesn't leave > + * at least one basic rate usable, since we really have to be able > + * to send something, and if we're an AP we have to be able to do > + * so at a basic rate so that all clients can receive it. > + */ > + if (rcu_access_pointer(sdata->vif.chanctx_conf) && > + sdata->vif.bss_conf.chandef.chan) { > + u32 basic_rates = sdata->vif.bss_conf.basic_rates; > + enum nl80211_band band = sdata->vif.bss_conf.chandef.chan->band; > + > + if (!(mask->control[band].legacy & basic_rates)) > + return -EINVAL; If user want to use “iw wlan0 set bitrates legacy-5 54” to set it to fixed in 54M and 54M is not basic rate in AP's becaon as example of below, then the iw command will fail. Tag: Supported Rates 6(B), 9, 12(B), 18, 24(B), 36, 48, 54, [Mbit/sec] Tag Number: Supported Rates (1) Tag length: 8 Supported Rates: 6(B) (0x8c) Supported Rates: 9 (0x12) Supported Rates: 12(B) (0x98) Supported Rates: 18 (0x24) Supported Rates: 24(B) (0xb0) Supported Rates: 36 (0x48) Supported Rates: 48 (0x60) Supported Rates: 54 (0x6c) > + } > + > for (i = 0; i < NUM_NL80211_BANDS; i++) { > struct ieee80211_supported_band *sband = wiphy->bands[i]; > int j; ...