From: Sean Anderson <sean.anderson@linux.dev>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Juri Lelli <juri.lelli@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Handle threadirqs in __napi_schedule_irqoff
Date: Fri, 13 Sep 2024 12:19:05 -0400 [thread overview]
Message-ID: <0735aa31-3fc0-4767-9372-23509df751df@linux.dev> (raw)
In-Reply-To: <20240913161446.NYZEvAi1@linutronix.de>
On 9/13/24 12:14, Sebastian Andrzej Siewior wrote:
> On 2024-09-13 11:09:54 [-0400], Sean Anderson wrote:
>> The threadirqs kernel parameter can be used to force threaded IRQs even
>> on non-PREEMPT_RT kernels. Use force_irqthreads to determine if we can
>> skip disabling local interrupts. This defaults to false on regular
>> kernels, and is always true on PREEMPT_RT kernels.
>
> Is this fixing a behaviour or is this from the clean up/ make it pretty
> category?
It's in response to [1].
[1] https://lore.kernel.org/netdev/20240912084322.148d7fb2@kernel.org/
> The forced-threaded interrupts run with disabled interrupts on !RT so
> this change should not fix anything.
OK, so maybe this isn't necessary at all?
--Sean
next prev parent reply other threads:[~2024-09-13 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 15:09 [PATCH] net: Handle threadirqs in __napi_schedule_irqoff Sean Anderson
2024-09-13 15:16 ` Eric Dumazet
2024-09-13 15:23 ` Sean Anderson
2024-09-13 16:08 ` Brett Creeley
2024-09-13 16:17 ` Sean Anderson
2024-09-13 16:14 ` Sebastian Andrzej Siewior
2024-09-13 16:19 ` Sean Anderson [this message]
2024-09-30 9:55 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0735aa31-3fc0-4767-9372-23509df751df@linux.dev \
--to=sean.anderson@linux.dev \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=juri.lelli@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.