From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Denis Benato <benato.denis96@gmail.com>
Cc: Denis Benato <denis.benato@linux.dev>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Hans de Goede <hansg@kernel.org>,
"Limonciello, Mario" <mario.limonciello@amd.com>,
"Luke D . Jones" <luke@ljones.dev>,
Alok Tiwari <alok.a.tiwari@oracle.com>,
Derek John Clark <derekjohn.clark@gmail.com>,
Mateusz Schyboll <dragonn@op.pl>,
porfet828@gmail.com
Subject: Re: [PATCH] platform/x86: asus-armoury: fix only DC tunables being available
Date: Mon, 24 Nov 2025 15:28:37 +0200 (EET) [thread overview]
Message-ID: <073f7f84-cd31-2e34-e282-05ae95375b04@linux.intel.com> (raw)
In-Reply-To: <d2cd2ed3-6f0d-41c1-86bb-dfe57646262a@gmail.com>
On Sun, 23 Nov 2025, Denis Benato wrote:
> On 11/23/25 16:05, Denis Benato wrote:
> > Module asus-armoury must use AC tunables to check availability
> No idea why I missed the double space here.
>
> Do I resend a corrected version? Should checkpatch.pl also check for this?
Thanks for the heads up.
I can take care of it while applying (and if I happen to forget the sky
is not going to fall :-)).
--
i.
> > of power-related firmware attributes: fix missing attributes
> > by using AC attributes instead of DC.
> >
> > Signed-off-by: Denis Benato <denis.benato@linux.dev>
> > ---
> > drivers/platform/x86/asus-armoury.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> > index 5106e8a41e25..9c1a9ad42bc4 100644
> > --- a/drivers/platform/x86/asus-armoury.c
> > +++ b/drivers/platform/x86/asus-armoury.c
> > @@ -869,7 +869,8 @@ static bool has_valid_limit(const char *name, const struct power_limits *limits)
> >
> > static int asus_fw_attr_add(void)
> > {
> > - const struct rog_tunables *const ac_rog_tunables = asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_DC];
> > + const struct rog_tunables *const ac_rog_tunables =
> > + asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_AC];
> > const struct power_limits *limits;
> > bool should_create;
> > const char *name;
>
next prev parent reply other threads:[~2025-11-24 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-23 15:05 [PATCH] platform/x86: asus-armoury: fix only DC tunables being available Denis Benato
2025-11-23 15:21 ` Denis Benato
2025-11-24 13:28 ` Ilpo Järvinen [this message]
2025-11-24 13:54 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=073f7f84-cd31-2e34-e282-05ae95375b04@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=alok.a.tiwari@oracle.com \
--cc=benato.denis96@gmail.com \
--cc=denis.benato@linux.dev \
--cc=derekjohn.clark@gmail.com \
--cc=dragonn@op.pl \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=porfet828@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.