All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: Tom Rini <trini@konsulko.com>, Artem Lapkin <email2tema@gmail.com>
Cc: sjg@chromium.org, marek.behun@nic.cz, narmstrong@baylibre.com,
	twarren@nvidia.com, andre.przywara@arm.com, u-boot@lists.denx.de,
	u-boot-amlogic@groups.io, christianshewitt@gmail.com,
	art@khadas.com, nick@khadas.com, gouwa@khadas.com
Subject: Re: [PATCH v2 1/2] env: setenv add resolve value option
Date: Fri, 8 Apr 2022 09:09:41 -0400	[thread overview]
Message-ID: <075374b2-7149-455e-9e36-acd71e607197@gmail.com> (raw)
In-Reply-To: <20220407180526.GA885897@bill-the-cat>

On 4/7/22 2:05 PM, Tom Rini wrote:
> On Fri, Nov 19, 2021 at 12:36:46PM +0800, Artem Lapkin wrote:
>> Add possibility setup env variable with additional resolving vars inside
> 
>> value.
>>
>> Usage examples:
>>
>> => setenv a hello; setenv b world; setenv c '${a} ${b}'
>> => setenv -r d '${c}! ${a}...'
>> => printenv d
>> d=hello world! hello...
>>
>> /* internal usage example */
>> env_resolve("d", "${c}! ${a}...");
>> /* d="hello world! hello..." */
>>
>> Signed-off-by: Artem Lapkin <art@khadas.com>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> This break building on a number of platforms such as am335x_evm.
> 

Should this even be applied in the first place? I agree with Wolfgang's
objections. This should be done by the shell (if anything).

--Sean

  reply	other threads:[~2022-04-08 13:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  4:36 [PATCH v2 0/2] env: setenv add resolve value option Artem Lapkin
2021-11-19  4:36 ` [PATCH v2 1/2] " Artem Lapkin
2021-11-25  0:13   ` Simon Glass
2022-04-07 18:05   ` Tom Rini
2022-04-08 13:09     ` Sean Anderson [this message]
2022-04-08 13:11       ` Tom Rini
2021-11-19  4:36 ` [PATCH v2 2/2] test: env: deep resolve value testing Artem Lapkin
2021-11-25  0:13   ` Simon Glass
2021-11-19  7:48 ` [PATCH v2 0/2] env: setenv add resolve value option Wolfgang Denk
2021-11-19  9:06   ` Art Nikpal
2021-11-20 12:36     ` Wolfgang Denk
2021-11-22  8:25       ` Art Nikpal
     [not found]     ` <6198ebca.1c69fb81.fc50c.bf0bSMTPIN_ADDED_BROKEN@mx.google.com>
2021-11-22  8:09       ` Art Nikpal
2021-11-22  8:51         ` Wolfgang Denk
2021-11-22 10:06           ` Art Nikpal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=075374b2-7149-455e-9e36-acd71e607197@gmail.com \
    --to=seanga2@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=art@khadas.com \
    --cc=christianshewitt@gmail.com \
    --cc=email2tema@gmail.com \
    --cc=gouwa@khadas.com \
    --cc=marek.behun@nic.cz \
    --cc=narmstrong@baylibre.com \
    --cc=nick@khadas.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=twarren@nvidia.com \
    --cc=u-boot-amlogic@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.