From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'git'" <git@vger.kernel.org>
Subject: [Suggestion] Documentation: quick-install-man not propagating DESTDIR
Date: Tue, 1 Sep 2020 18:28:02 -0400 [thread overview]
Message-ID: <077a01d680af$2ad65510$8082ff30$@nexbridge.com> (raw)
The make quick-install-man rule is not propagating DESTDIR when GNU Make
4.2.1 is used.
It seems like a bit of a nit to report this, but I discovered that the
installation is not putting the manuals in the same place as git. It’s a
pretty simple fix. I can put a patch together if desired.
diff --git a/Makefile b/Makefile
index 372139f1f2..dae2d99a7f 100644
--- a/Makefile
+++ b/Makefile
@@ -2992,10 +2992,10 @@ install-gitweb:
$(MAKE) -C gitweb install
install-doc: install-man-perl
- $(MAKE) -C Documentation install
+ $(MAKE) -C Documentation install DESTDIR=$(DESTDIR)
install-man: install-man-perl
- $(MAKE) -C Documentation install-man
+ $(MAKE) -C Documentation install-man DESTDIR=$(DESTDIR)
install-man-perl: man-perl
$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(mandir_SQ)/man3'
@@ -3006,19 +3006,19 @@ install-html:
$(MAKE) -C Documentation install-html
install-info:
- $(MAKE) -C Documentation install-info
+ $(MAKE) -C Documentation install-info DESTDIR=$(DESTDIR)
install-pdf:
- $(MAKE) -C Documentation install-pdf
+ $(MAKE) -C Documentation install-pdf DESTDIR=$(DESTDIR)
quick-install-doc:
- $(MAKE) -C Documentation quick-install
+ $(MAKE) -C Documentation quick-install DESTDIR=$(DESTDIR)
quick-install-man:
- $(MAKE) -C Documentation quick-install-man
+ $(MAKE) -C Documentation quick-install-man DESTDIR=$(DESTDIR)
quick-install-html:
- $(MAKE) -C Documentation quick-install-html
+ $(MAKE) -C Documentation quick-install-html DESTDIR=$(DESTDIR)
-- Brief whoami:
NonStop developer since approximately 211288444200000000
UNIX developer since approximately 421664400
-- In my real life, I talk too much.
next reply other threads:[~2020-09-01 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 22:28 Randall S. Becker [this message]
2020-09-02 19:44 ` [Suggestion] Documentation: quick-install-man not propagating DESTDIR Junio C Hamano
2020-09-02 19:52 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='077a01d680af$2ad65510$8082ff30$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.