All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Enver Ikromov <owner@ph4ntom-rev.uz>,
	Zong-Zhe Yang <kevin_yang@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v8 5/5] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames
Date: Thu, 19 Nov 2026 08:09:44 +0000	[thread overview]
Message-ID: <077a0d609e3c4cebabe6b1be5aa9eb09@realtek.com> (raw)
In-Reply-To: <20261119080328.391-6-owner@ph4ntom-rev.uz>

Enver Ikromov <owner@ph4ntom-rev.uz> wrote:
> Injected management frames currently overwrite caller-supplied sequence
> numbers because hardware sequence numbering remains enabled when
> IEEE80211_TX_CTL_ASSIGN_SEQ is unset, and injected frames ignore NO_ACK
> and explicit radiotap retry limits.
> 
> Preserve the caller's sequence number when IEEE80211_TX_CTL_ASSIGN_SEQ
> is not set, honor radiotap retry counts up to RTW89_TX_DATA_CNT_LMT_MAX
> (63), and report IEEE80211_TX_STAT_NOACK_TRANSMITTED for NO_ACK frames.

> Set BE_TXD_BODY6_NO_ACK on Wi-Fi 7 chips that carry NO_ACK in the TX
> descriptor; 

I'd add "(not tested)" here. 

No need v9 because of this.

> Wi-Fi 6 chips such as RTL8852AE do not have a TX descriptor
> NO_ACK field and only limit transmission to a single attempt via
> tx_cnt_lmt = 1.
> 
> Signed-off-by: Enver Ikromov <owner@ph4ntom-rev.uz>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>





      reply	other threads:[~2026-11-19  8:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:03 [PATCH rtw-next v8 0/5] wifi: rtw89: monitor mode and raw frame injection fixes Enver Ikromov
2026-11-19  8:03 ` [PATCH rtw-next v8 1/5] wifi: rtw89: avoid NULL vif dereference in rtw89_ops_tx() Enver Ikromov
2026-11-19  8:03 ` [PATCH rtw-next v8 2/5] wifi: rtw89: handle negative rate index for injected frames Enver Ikromov
2026-11-19  8:03 ` [PATCH rtw-next v8 3/5] wifi: rtw89: restore channel when leaving idle on non-chanctx devices Enver Ikromov
2026-11-19  8:03 ` [PATCH rtw-next v8 4/5] wifi: rtw89: avoid reading seq_ctrl on control frames Enver Ikromov
2026-11-19  8:03 ` [PATCH rtw-next v8 5/5] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames Enver Ikromov
2026-11-19  8:09   ` Ping-Ke Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=077a0d609e3c4cebabe6b1be5aa9eb09@realtek.com \
    --to=pkshih@realtek.com \
    --cc=kevin_yang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=owner@ph4ntom-rev.uz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.