All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Helge Deller <deller@gmx.de>,
	Linux SCSI List <linux-scsi@vger.kernel.org>,
	linux-aio@kvack.org, linux-parisc <linux-parisc@vger.kernel.org>
Subject: Re: spinlock recursion in aio_complete()
Date: Mon, 22 May 2023 13:58:44 -0700	[thread overview]
Message-ID: <077b00a6-9587-2e28-3f8a-44871f9428ca@acm.org> (raw)
In-Reply-To: <8bd7faad-abf4-f7b3-03c9-e06f9b5d2148@gmx.de>

On 5/22/23 13:51, Helge Deller wrote:
> On 5/22/23 21:28, Bart Van Assche wrote:
>> On 5/20/23 22:43, Helge Deller wrote:
>>> On a single-CPU parisc64 machine I face the spinlock recursion below.
>>> Happens reproduceably directly at bootup since kernel 6.2 (and ~ 6.1.5).
>>> Kernel is built for SMP. Same kernel binary works nicely on machines with more than
>>> one CPU, but stops on UP machines.
>>> Any idea or patch I could try?
>>
>> How about performing one or more of the following actions?
>> * Translating aio_complete+0x68 into a line number.
> 
> It hangs in fs/aio.c:1128, function aio_complete(), in this call:
>      spin_lock_irqsave(&ctx->completion_lock, flags);

All code that I found and that obtains ctx->completion_lock disables IRQs.
It is not clear to me how this spinlock can be locked recursively? Is it
sure that the "spinlock recursion" report is correct?

Thanks,

Bart.


  reply	other threads:[~2023-05-22 20:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-21  5:43 spinlock recursion in aio_complete() Helge Deller
2023-05-22 19:28 ` Bart Van Assche
2023-05-22 20:51   ` Helge Deller
2023-05-22 20:58     ` Bart Van Assche [this message]
2023-05-22 21:22       ` Helge Deller
2023-05-23 10:24         ` Helge Deller
2023-05-23 10:24           ` Helge Deller
2023-05-23 10:51           ` Russell King (Oracle)
2023-05-23 10:51             ` Russell King (Oracle)
2023-05-23 20:01             ` Helge Deller
2023-05-23 20:01               ` Helge Deller
2023-05-23 20:06               ` Bart Van Assche
2023-05-23 20:06                 ` Bart Van Assche
2023-05-23 20:12                 ` Helge Deller
2023-05-23 20:12                   ` Helge Deller
2023-05-23 20:24               ` Helge Deller
2023-05-23 20:24                 ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=077b00a6-9587-2e28-3f8a-44871f9428ca@acm.org \
    --to=bvanassche@acm.org \
    --cc=deller@gmx.de \
    --cc=linux-aio@kvack.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.