From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1617333ADAA for ; Fri, 21 Nov 2025 10:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763722453; cv=none; b=Yexhb0TCpz507bsJPEma2bHgGbS6cYuYdDLK10um/EH5iWl1lovElQTy0PdcbGmaHq2zQAF9dVTAcBPbw9CeCTFfUnGV/qzuaDB6ulJ3LMg5mcVpK4cHjd1A8tReLnVhzc8p85VVAZNkhLyYRH4oQsRdsuvmHoPgYSVpO672WLk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763722453; c=relaxed/simple; bh=22bNqpghL2/hLQA/Yq7C42v6PAkQwIss5xiDgvY++6Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ge95fQTAKyA+TkhMcKfGiJHkl7OYhBpXGEvQ3JGeDSz1Wgz6AyUxuJKAuF3SyWmea7CGuCyxb1P2RkfsU+ojV3M4iCfRBM6oya18d4V9V9xEwMxwL7xijcjxCz4GqB8YROnIWnEe3haD37TIteqdGUKoRJnE3iZd63nJc34AfY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HrWvV3Lp; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HrWvV3Lp" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4779d47be12so14709015e9.2 for ; Fri, 21 Nov 2025 02:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763722450; x=1764327250; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6oc63flMYhO4xP3uUIOFRiVwpD5hRmxzv8ZfrogDNJ4=; b=HrWvV3LpqchwcDB/tqLVW1xuWGa42+jfJVI7rjvMWGrHpfMKBUSAuAqgZPfPZ5Ye3p uj10KsBouV24u7BQLPTrEtHnkCN5BTwFYeeH6p1ElVWRd8In0tR8nzG7eEnokX9Vi4Nn dpavKbFQrTUBY2gifRrcOtAE9AyKXu1mu4etF4/fkuWVoJjn65YEKKyb2WW4HMp7xCEA 9IyqmWNvMbe38IsP3qR7N269mI1ZqN0hWtaWTJVaLffSx6R0++au/ZU6MXl7CKSGn+64 jN93AtcvNoZq1RXO76s12dGdPBgydcseMBNpwpoCwbCQUb9vD3xaGAvyizThuD97nwfo XZ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763722450; x=1764327250; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6oc63flMYhO4xP3uUIOFRiVwpD5hRmxzv8ZfrogDNJ4=; b=u9KUwJ75AzJPAb8uq7C3aFLH1gtyV8SJW9g5Lhkb+UEj9PURmK60e8Zr2lf1Ac/Dap 4wP0nLElYtpId7sZWQQM2mqRKMteZTiwKGzas7L7LsozdeR17gwu7+s0z2U5x15bmiu3 AZbmq49bQBtX+YvY6bK5updiMG2eVepGYpjOJvM1Z+cOF7UWsnnJDk5l5tC5kgnH8Gp4 RyB4bqJ3pJLjeIIFInJO9b36CcCdTq3f7Kuw/zr5U7ec1tw9J5QuLUpvNwx5AHfnbAm3 BkiVLgNFMw/miHJ8Z286gm2Rfkx7WZTh5Vqg7fGF0pH1hY8hEgswyUnvX0bHazzPPiJI mJfQ== X-Forwarded-Encrypted: i=1; AJvYcCUxN7QnGTaFIankz9T7YCO7Qe8MX0GjV4uu47LInRxzirtPnBJ6wcA+t9WeYmrQPDEXWk+mLOdtvhb95gI=@vger.kernel.org X-Gm-Message-State: AOJu0YymZ0V9hkWBgZ1fgm0YzF4Oo5oMLvRekycuomRtXIjy9UfXAMBq RxaSf6vumDpnp8UndCO4sg1a1rEetX6ZiF/a6DTWyCBpPYhAKQ0RObFEI594Ig== X-Gm-Gg: ASbGnctGeSvfDv5EFJCOJJfoucD3rKJGsytysWj+iqr4S4U+sCwvCZSC4rHYfQhGHBR 8N7V+tmSs7rSSv1lbLsO+aBNkNDrFaK43apjGx5vXWcqLvU0h5g3ot7AZfg8+ICl94Wnsl99ZDv BS9ba36b88+3s/d1uBXQ3A9Jfr6QhnyeH7q7zEJqu6fvdht2nkc8IJFMjObPr9mS5y9mdqFVfVd bC5vacivERihPgUhq7VpYb2UqcKYNWNihcU9/xJ4LXa+lvT87qaRoQJh6K8cZ31pAPJh732unpg +gWeBy398x7rXlFdiUrRUVMng8OAJc3GCj/z7SSnFbzNDJMQU1bf4VAahYXJIYqYoU2alrXJFVF w1HUmvShLQ1CV0I2XpaBxb7ITfUCWf53sC+UbJAcxPJ0txM3LGrb416D+NZg/CJWDI5o6Z66UHN Xr9Y+CvcRKR1L9YOlIrVk68raD0glSik58/kfZmH7R66Q1XD/91Yi5UcRpywmGID57HZAJn88Au J+LJWJeIiA+Kj+yXkND6+FJC81DvtPNksIwXAXoCyuirg== X-Google-Smtp-Source: AGHT+IFf5mm9mbD++sAv7CzMezXpm3DY0adZVK3P1GGX5FRjtwgITGyeT2hJDnsK7dDmZK7EZbC9aQ== X-Received: by 2002:a05:600c:524d:b0:477:c71:1fc1 with SMTP id 5b1f17b1804b1-477c01d44b4mr18814025e9.19.1763722450058; Fri, 21 Nov 2025 02:54:10 -0800 (PST) Received: from ?IPV6:2003:f6:f70a:ad00:ceb4:fa20:1c7f:ed8c? (p200300f6f70aad00ceb4fa201c7fed8c.dip0.t-ipconnect.de. [2003:f6:f70a:ad00:ceb4:fa20:1c7f:ed8c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8e54sm10509307f8f.40.2025.11.21.02.54.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 02:54:09 -0800 (PST) Message-ID: <07831c5f-7cc1-41f5-b88e-ca3ece325e87@gmail.com> Date: Fri, 21 Nov 2025 11:54:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mcb: Fix incorrect sanity check To: Jose Javier Rodriguez Barbarin Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org References: <20251120113732.24678-1-dev-josejavier.rodriguez@duagon.com> <6b6e7d3e-7219-4459-b177-1e4123c531be@gmail.com> Content-Language: en-US From: Johannes Thumshirn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/21/25 11:33 AM, Jose Javier Rodriguez Barbarin wrote: > On Thu, Nov 20, 2025 at 12:48:45PM +0100, Johannes Thumshirn wrote: >> On 11/20/25 12:37 PM, Jose Javier Rodriguez Barbarin wrote: >>> __mcb_register_driver() makes some sanity checks over mcb_driver >>> to check if .probe and .remove callbacks are set. However, not all >>> mcb device drivers implement .remove callback. >>> >>> Remove .remove check to ensure all mcb device drivers can be loaded. >> The only driver I can see that doesn't implement a .remove method is >> gpio-menz127.c. > Yes. In the past gpio-menz127.c also implemented .remove method, however in > > 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove()") > > The driver changed, using now devm_* functions so .remove was no longer necessary. > >> Is this safe? >> > From the point of view of mcb bus it should be safe becase I protected the call > of .remove on mcb_remove(), preventing possible crashes when the driver is removed > from the bus. > > I'm afraid I'm lossing something because I cannot understand why these changes are or > not safe. Could you explain me why you understand that these changes are unsafe? Thanks this is the information I was missing from the changelog. I'll change the commit message to: __mcb_register_driver() makes some sanity checks over mcb_driver to check if .probe and .remove callbacks are set. However, since commit 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove()") removed the .remove callback from menz127-gpio.c, not all mcb device drivers implement .remove callback. Remove .remove check to ensure all mcb device drivers can be loaded. I'll also add Fixes: 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove()") Thanks,     Johannes