From: Peter Wang <peter.wang@mediatek.com>
To: Stanley Jhu <stanleyjhu@google.com>,
"Martin K. Petersen" <mkp@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: <powenkao@google.com>, Alim Akhtar <alim.akhtar@samsung.com>,
"Bart Van Assche" <bvanassche@acm.org>,
Bean Huo <beanhuo@micron.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH 2/3] scsi: ufs: bsg: Clear the UIC result byte before sending UIC commands
Date: Wed, 14 Oct 2026 15:28:51 +0800 [thread overview]
Message-ID: <07b41e9e46d26b4a0e0683404e98cd29d38cced0.camel@mediatek.com> (raw)
In-Reply-To: <20261013102913.948718-3-stanleyjhu@google.com>
On Tue, 2026-10-13 at 18:29 +0800, Stanley Jhu wrote:
> ufs_bsg_request() passes the user-supplied UIC argument2 unchanged,
> including the result byte (bits 7:0) that only the host controller
> writes. A non-zero value triggers the WARN_ON_ONCE() in
> ufshcd_dispatch_uic_cmd() and corrupts the reported result. Found by
> syzkaller.
>
> Clear the result byte before sending the command.
>
> Fixes: e77044c5a842 ("scsi: ufs-bsg: Add support for uic commands in
> ufs_bsg_request()")
> Fixes: 9fb4c793223b ("scsi: ufs: core: Complain if UIC argument 2 is
> invalid")
> Cc: stable@vger.kernel.org
> Signed-off-by: Stanley Jhu <stanleyjhu@google.com>
> ---
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2026-10-14 7:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 10:29 [PATCH 0/3] scsi: ufs: Fix UIC result byte and BSG request length handling Stanley Jhu
2026-10-13 10:29 ` [PATCH 1/3] scsi: ufs: bsg: Validate request_len before accessing request Stanley Jhu
2026-10-13 10:44 ` sashiko-bot
2026-10-15 0:29 ` Stanley Jhu
2026-10-14 10:02 ` Bean Huo
2026-10-13 10:29 ` [PATCH 2/3] scsi: ufs: bsg: Clear the UIC result byte before sending UIC commands Stanley Jhu
2026-10-14 7:28 ` Peter Wang [this message]
2026-10-14 10:43 ` Bean Huo
2026-10-14 13:30 ` Bart Van Assche
2026-10-15 0:22 ` Stanley Jhu
2026-10-13 10:29 ` [PATCH 3/3] scsi: ufs: core: Clear stale UIC result byte before peer DME retries Stanley Jhu
2026-10-13 10:41 ` sashiko-bot
2026-10-13 10:48 ` Stanley Jhu
2026-10-15 0:29 ` Stanley Jhu
2026-10-14 10:58 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07b41e9e46d26b4a0e0683404e98cd29d38cced0.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=powenkao@google.com \
--cc=stable@vger.kernel.org \
--cc=stanleyjhu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.