From: Wen Xiong <wenxiong@linux.ibm.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, gjoyce@linux.ibm.com,
wenxiong@us.ibm.com
Subject: Re: [PATCH] nvme: Add module reference counting for multipath nvme device
Date: Tue, 11 Aug 2026 15:33:19 -0500 [thread overview]
Message-ID: <07ba01ec9c9f54da7cf7b3b4096f1e7e@linux.ibm.com> (raw)
In-Reply-To: <ant0I66BcAugTyGX@kbusch-mbp>
On 2026-08-11 14:12, Keith Busch wrote:
> The result of nvme_find_path() is just the current path at the moment,
> so I don't think this is right.
>
I thought:
- if policy is NUMA, returns current caches path if optimized.
- Otherwise scans other paths to find a new optimal path.
> I think you need the head to hold a module reference on every path the
> head has, so the module_get/put should be in nvme_mpath_add_disk and
> nvme_mpath_remove_disk.
I will check this.
Thanks for your reviewing!
Wendy
next prev parent reply other threads:[~2026-08-11 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 23:50 [PATCH] nvme: Add module reference counting for multipath nvme device wenxiong
2026-08-11 13:18 ` John Garry
2026-08-11 18:54 ` Wen Xiong
2026-08-11 19:12 ` Keith Busch
2026-08-11 20:33 ` Wen Xiong [this message]
2026-08-11 20:49 ` Keith Busch
2026-08-12 3:59 ` Wen Xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07ba01ec9c9f54da7cf7b3b4096f1e7e@linux.ibm.com \
--to=wenxiong@linux.ibm.com \
--cc=gjoyce@linux.ibm.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.