From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Marek Vasut <marex@denx.de>, <linux-arm-kernel@lists.infradead.org>
Cc: Patrick Delaunay <patrick.delaunay@st.com>,
linux-stm32@st-md-mailman.stormreply.com,
Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Patrice Chotard <patrice.chotard@st.com>
Subject: Re: [PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM
Date: Thu, 14 Jan 2021 18:18:54 +0100 [thread overview]
Message-ID: <07c83c12-e167-0458-e6f2-cc5fcac943d6@foss.st.com> (raw)
In-Reply-To: <20201224062438.92582-1-marex@denx.de>
Hi Marek
On 12/24/20 7:24 AM, Marek Vasut wrote:
> The GPIO hog node name should match regex '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$',
> make it so and fix the following two make dtbs_check warnings:
>
> arch/arm/boot/dts/stm32mp157c-dhcom-picoitx.dt.yaml: hog-usb-port-power: $nodename:0: 'hog-usb-port-power' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
> arch/arm/boot/dts/stm32mp153c-dhcom-drc02.dt.yaml: hog-usb-hub: $nodename:0: 'hog-usb-hub' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi | 4 ++--
> arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
> index 62ab23824a3e..cb68afbbea68 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
> @@ -33,7 +33,7 @@ &gpiob {
> * during TX anyway and that it only controls drive enable DE
> * line. Hence, the RX is always enabled here.
> */
> - rs485-rx-en {
> + rs485-rx-en-hog {
> gpio-hog;
> gpios = <8 GPIO_ACTIVE_HIGH>;
> output-low;
> @@ -61,7 +61,7 @@ &gpioi {
> * order to reset the Hub when USB bus is powered down, but
> * so far there is no such functionality.
> */
> - usb-hub {
> + usb-hub-hog {
> gpio-hog;
> gpios = <2 GPIO_ACTIVE_HIGH>;
> output-high;
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> index 356150d28c42..b99f2b891629 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> @@ -43,7 +43,7 @@ &gpioa {
> * in order to turn on port power when USB bus is powered up, but so
> * far there is no such functionality.
> */
> - usb-port-power {
> + usb-port-power-hog {
> gpio-hog;
> gpios = <13 GPIO_ACTIVE_LOW>;
> output-low;
>
Applied on stm32-fixes with a Fixes tag added.
Thanks.
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-01-14 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 6:24 [PATCH] ARM: dts: stm32: Fix GPIO hog names on DHCOM Marek Vasut
2021-01-14 17:18 ` Alexandre TORGUE [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07c83c12-e167-0458-e6f2-cc5fcac943d6@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=alexandre.torgue@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marex@denx.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=patrice.chotard@st.com \
--cc=patrick.delaunay@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.