From: Akira Yokosawa <akiyks@gmail.com>
To: Junchang Wang <junchangwang@gmail.com>
Cc: perfbook@vger.kernel.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH] Update Answer to Quick Quiz 5.27
Date: Tue, 9 May 2017 23:56:25 +0900 [thread overview]
Message-ID: <07cd658e-d71b-496e-5583-e204ae1c3ebf@gmail.com> (raw)
In-Reply-To: <1494319692-4252-1-git-send-email-junchangwang@gmail.com>
On 2017/05/09 16:48:12 +0800, Junchang Wang wrote:
> Oops. Forgot the summary in previous email. Resend the patch.
>
>
> The Answer to Quick Quiz 5.27 is a bit hard to follow. Rewrite it.
>
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>
> ---
> count/count.tex | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/count/count.tex b/count/count.tex
> index cc47554..6dfc7a6 100644
> --- a/count/count.tex
> +++ b/count/count.tex
> @@ -1258,13 +1258,13 @@ machine.
> fast and scalable while allowing readers to also enjoy
> reasonable performance and scalability?
> \QuickQuizAnswer{
> - One approach would be to maintain a global approximation
> - to the value.
> - Readers would increment their per-thread variable, but when it
> - reached some predefined limit, atomically add it to a global
> - variable, then zero their per-thread variable.
> - This would permit a tradeoff between average increment overhead
> - and accuracy of the value read out.
> + One approach would be to add a global variable maintaining a
> + approximation to the exact value. An updater would increment its
> + per-thread variable, and when its value reaches predefined limit,
> + atomically add the value to the global variable, then zero its
> + per-thread variable. Readers simply return the value of global variable,
> + enjoying reasonable performance. This would permit a tradeoff between
> + average increment overhead and accuracy of the value read out.
>
> The reader is encouraged to think up and try out other approaches,
> for example, using a combining tree.
>
Hi Junchang,
What confused you seems to be a simple typo.
Isn't the following one-liner sufficient for you?
Thanks, Akira
--8<---->8--
From 725b32938e0cbc245e5a528fd475951bb8be1de5 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <akiyks@gmail.com>
Date: Tue, 9 May 2017 23:39:57 +0900
Subject: [PATCH] count: Fix typo in Answer to Quick Quiz 5.27
Reported-by: Junchang Wang <junchangwang@gmail.com>
Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
---
count/count.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/count/count.tex b/count/count.tex
index cc47554..096b53d 100644
--- a/count/count.tex
+++ b/count/count.tex
@@ -1260,7 +1260,7 @@ machine.
\QuickQuizAnswer{
One approach would be to maintain a global approximation
to the value.
- Readers would increment their per-thread variable, but when it
+ Updaters would increment their per-thread variable, but when it
reached some predefined limit, atomically add it to a global
variable, then zero their per-thread variable.
This would permit a tradeoff between average increment overhead
--
2.7.4
next prev parent reply other threads:[~2017-05-09 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 8:48 [PATCH] Update Answer to Quick Quiz 5.27 Junchang Wang
2017-05-09 14:56 ` Akira Yokosawa [this message]
2017-05-09 15:21 ` Junchang Wang
2017-05-09 22:38 ` Akira Yokosawa
2017-05-09 23:05 ` Junchang Wang
2017-05-11 0:47 ` [PATCH] count: Fix typo in " Akira Yokosawa
2017-05-11 3:15 ` Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2017-05-09 8:43 [PATCH] Update " Junchang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07cd658e-d71b-496e-5583-e204ae1c3ebf@gmail.com \
--to=akiyks@gmail.com \
--cc=junchangwang@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.