From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CDE8C83F09 for ; Wed, 9 Jul 2025 11:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:In-Reply-To:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cimesBusUUV91WuSukFwoB37riuMSdtT5ntRgk2rp3U=; b=M93udRUAnOZPPRgrJ8MNvCgfK0 By62bkhJ55gWokhrHmR5+dy8iXvcXhOHWag2gCqDhejSEh02+GlhppQ7MKCDmh7QGPUU0TV7HZ9/1 jolfPhmvf/3Ypg4B7c741CwHnOWO73gRJr4EFBm2Cxo8PVdQXNgHKI/GecGJrTH6uYx/CDoStVmEP 39pcWIqcbwGwfpkjGBV3HXsRniTskVzdmrgQda/H/I/aB16FAePYpMdLZlWpTDQVUiL0TKz7Zh5Kr TVp5LbOaUEM9OCZIC/em+IJXxYoCt/wWvRk5KRvd3vGOGbt/isUPUt3AzCjrTFwr11xVVnsIazD4i wcJRFPPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZT6l-00000008WHz-0F1c; Wed, 09 Jul 2025 11:37:03 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZRbu-00000008DdN-0lCK for linux-arm-kernel@lists.infradead.org; Wed, 09 Jul 2025 10:01:08 +0000 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20250709100056epoutp03a6d3ac8fc6d19ef7f392f9af4419ac69~QjPkC8tbs0724807248epoutp03c for ; Wed, 9 Jul 2025 10:00:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20250709100056epoutp03a6d3ac8fc6d19ef7f392f9af4419ac69~QjPkC8tbs0724807248epoutp03c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1752055256; bh=cimesBusUUV91WuSukFwoB37riuMSdtT5ntRgk2rp3U=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=dSN2X7WclO21MRD+00fqzdIAQPqNkJqga/ywHIIPNAMFno11BpKrnoXp36kv2NYYz a3tOUk3tT59L5FmIeT3FGktatot/mLzC3+UiRuOAOzWmHHOFOGzaKt/YO9mWcz9Efw vI4OPWf7/Jg4PxLi//yPzDdrcyUerCIXZMztNFdk= Received: from epsnrtp04.localdomain (unknown [182.195.42.156]) by epcas5p2.samsung.com (KnoxPortal) with ESMTPS id 20250709100055epcas5p278a3a0658d2407780cbf48dc11bb00de~QjPjdukHC2819328193epcas5p2U; Wed, 9 Jul 2025 10:00:55 +0000 (GMT) Received: from epcas5p3.samsung.com (unknown [182.195.38.181]) by epsnrtp04.localdomain (Postfix) with ESMTP id 4bcYQF3P8Qz6B9m5; Wed, 9 Jul 2025 10:00:53 +0000 (GMT) Received: from epsmtip2.samsung.com (unknown [182.195.34.31]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20250709085353epcas5p3e1e989544692330277c3096f40df8369~QiVBscay_1273512735epcas5p3n; Wed, 9 Jul 2025 08:53:53 +0000 (GMT) Received: from INBRO001840 (unknown [107.122.3.105]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250709085350epsmtip25f40e8338ed740108c76c2bec86ac6d7~QiU_rvWW-2672826728epsmtip2M; Wed, 9 Jul 2025 08:53:50 +0000 (GMT) From: "Pritam Manohar Sutar" To: "'Krzysztof Kozlowski'" Cc: , , , , , , , , , , , , , , , , , , , , , , In-Reply-To: <20250706-diamond-crab-of-will-72205e@krzk-bin> Subject: RE: [PATCH v4 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo SS phy Date: Wed, 9 Jul 2025 14:23:49 +0530 Message-ID: <07d501dbf0ae$ff2126a0$fd6373e0$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJAgQZ9LFXBZrDskwNBYris6jFv1AJ630FZAevjVggA58dhDrM15xjg Content-Language: en-in X-CMS-MailID: 20250709085353epcas5p3e1e989544692330277c3096f40df8369 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P cpgsPolicy: CPGSC10-542,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250701120009epcas5p46bc2870446c499f9c0008c1d396650bb References: <20250701120706.2219355-1-pritam.sutar@samsung.com> <20250701120706.2219355-6-pritam.sutar@samsung.com> <20250706-diamond-crab-of-will-72205e@krzk-bin> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250709_030106_537423_4F47FB28 X-CRM114-Status: GOOD ( 19.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski > Sent: 06 July 2025 03:14 PM > To: Pritam Manohar Sutar > Cc: vkoul=40kernel.org; kishon=40kernel.org; robh=40kernel.org; > krzk+dt=40kernel.org; conor+dt=40kernel.org; alim.akhtar=40samsung.com; > andre.draszik=40linaro.org; peter.griffin=40linaro.org; neil.armstrong=40= linaro.org; > kauschluss=40disroot.org; ivo.ivanov.ivanov1=40gmail.com; > m.szyprowski=40samsung.com; s.nawrocki=40samsung.com; linux- > phy=40lists.infradead.org; devicetree=40vger.kernel.org; linux- > kernel=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; linux-s= amsung- > soc=40vger.kernel.org; rosa.pila=40samsung.com; dev.tailor=40samsung.com; > faraz.ata=40samsung.com; muhammed.ali=40samsung.com; > selvarasu.g=40samsung.com > Subject: Re: =5BPATCH v4 5/6=5D dt-bindings: phy: samsung,usb3-drd-phy: a= dd > ExynosAutov920 combo SS phy >=20 > On Tue, Jul 01, 2025 at 05:37:05PM +0530, Pritam Manohar Sutar wrote: > > This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards >=20 > Agian, this? >=20 > > compatible to the USB3.0 SS(5Gbps). 'Add-on USB2.0' phy is required to > > support USB2.0 HS(480Mbps), FS(12Mbps) and LS(1.5Mbps) data rates. > > These two phys are combined to form a combo phy. > > > > Add a dedicated compatible string for USB combo SS phy found in this > > SoC. The SoC requires two clocks, named =22phy=22 and =22ref=22 and var= ious > > power supplies (regulators) for the internal circuitry to work. > > The required voltages are: > > * avdd075_usb - 0.75v > > * avdd18_usb20 - 1.8v > > * avdd33_usb20 - 3.3v >=20 > One more commitm message completely copy-pasted and completely > uninforming. The voltages are irrelevant. Explain the architecture. This = should be > just one patch with proper full description. >=20 > > > > Add schema only for 'USB3.1 SSP+' SS phy in this commit. >=20 > Why only? Add everything, describe everything, but not what voltages you = have > there but the architecture of the PHY. >=20 Will combine patch 3 (combo HS phy) & 5(combo SS phy) to describe combo phy= and even will add some details as mentioned in cover letter. > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F134DC83F03 for ; Wed, 9 Jul 2025 11:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mxoQsdnnFFwZAUAvs+AJK+gMnt3ouE8XCbwizvyLGs4=; b=UkUlBeDH5rNuWI HlXeKxovnKs3ykG6Nw2Re9HKpEvSzLplrQXDdYMfA+f8QaP9yyUDaHKIiXK3EU684MzRjLQfJ65Yq fhK0FDqMyF6b/3NXxZlrLsyZ0UyrmhET31QnJvXBqgbdolQVSvBmF2QxGhnFOhTOaaB+ZYnlga+8+ paCybEUf5IdVYV2/cutNI0/DshPxJiLRm0DxpaN33K9G4tZR+ZKaCOQAQkcZ7A4X0AttsTXkWxiTX vPxidf7tEM8TqU1v/h9fSfpFo6weXPHRU6lhaN6oFHvy1sX9bp5O9hiMdTOrmRm522HI+yxpquxbO K7Hw2vRBphQzMAEItRrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZT4T-00000008W04-2b60; Wed, 09 Jul 2025 11:34:41 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZRbn-00000008Dc7-2cWa for linux-phy@lists.infradead.org; Wed, 09 Jul 2025 10:01:01 +0000 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250709100056epoutp01a84d34e6ecb844519895320f46e53b7c~QjPkC-Zki0246902469epoutp01R for ; Wed, 9 Jul 2025 10:00:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250709100056epoutp01a84d34e6ecb844519895320f46e53b7c~QjPkC-Zki0246902469epoutp01R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1752055256; bh=cimesBusUUV91WuSukFwoB37riuMSdtT5ntRgk2rp3U=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=dSN2X7WclO21MRD+00fqzdIAQPqNkJqga/ywHIIPNAMFno11BpKrnoXp36kv2NYYz a3tOUk3tT59L5FmIeT3FGktatot/mLzC3+UiRuOAOzWmHHOFOGzaKt/YO9mWcz9Efw vI4OPWf7/Jg4PxLi//yPzDdrcyUerCIXZMztNFdk= Received: from epsnrtp04.localdomain (unknown [182.195.42.156]) by epcas5p2.samsung.com (KnoxPortal) with ESMTPS id 20250709100055epcas5p278a3a0658d2407780cbf48dc11bb00de~QjPjdukHC2819328193epcas5p2U; Wed, 9 Jul 2025 10:00:55 +0000 (GMT) Received: from epcas5p3.samsung.com (unknown [182.195.38.181]) by epsnrtp04.localdomain (Postfix) with ESMTP id 4bcYQF3P8Qz6B9m5; Wed, 9 Jul 2025 10:00:53 +0000 (GMT) Received: from epsmtip2.samsung.com (unknown [182.195.34.31]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20250709085353epcas5p3e1e989544692330277c3096f40df8369~QiVBscay_1273512735epcas5p3n; Wed, 9 Jul 2025 08:53:53 +0000 (GMT) Received: from INBRO001840 (unknown [107.122.3.105]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250709085350epsmtip25f40e8338ed740108c76c2bec86ac6d7~QiU_rvWW-2672826728epsmtip2M; Wed, 9 Jul 2025 08:53:50 +0000 (GMT) From: "Pritam Manohar Sutar" To: "'Krzysztof Kozlowski'" Cc: , , , , , , , , , , , , , , , , , , , , , , In-Reply-To: <20250706-diamond-crab-of-will-72205e@krzk-bin> Subject: RE: [PATCH v4 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo SS phy Date: Wed, 9 Jul 2025 14:23:49 +0530 Message-ID: <07d501dbf0ae$ff2126a0$fd6373e0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJAgQZ9LFXBZrDskwNBYris6jFv1AJ630FZAevjVggA58dhDrM15xjg Content-Language: en-in X-CMS-MailID: 20250709085353epcas5p3e1e989544692330277c3096f40df8369 X-Msg-Generator: CA X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P cpgsPolicy: CPGSC10-542,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250701120009epcas5p46bc2870446c499f9c0008c1d396650bb References: <20250701120706.2219355-1-pritam.sutar@samsung.com> <20250701120706.2219355-6-pritam.sutar@samsung.com> <20250706-diamond-crab-of-will-72205e@krzk-bin> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250709_030059_973662_235370B4 X-CRM114-Status: GOOD ( 20.14 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski > Sent: 06 July 2025 03:14 PM > To: Pritam Manohar Sutar > Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > andre.draszik@linaro.org; peter.griffin@linaro.org; neil.armstrong@linaro.org; > kauschluss@disroot.org; ivo.ivanov.ivanov1@gmail.com; > m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux- > phy@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com; > faraz.ata@samsung.com; muhammed.ali@samsung.com; > selvarasu.g@samsung.com > Subject: Re: [PATCH v4 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add > ExynosAutov920 combo SS phy > > On Tue, Jul 01, 2025 at 05:37:05PM +0530, Pritam Manohar Sutar wrote: > > This phy supports USB3.1 SSP+(10Gbps) protocol and is backwards > > Agian, this? > > > compatible to the USB3.0 SS(5Gbps). 'Add-on USB2.0' phy is required to > > support USB2.0 HS(480Mbps), FS(12Mbps) and LS(1.5Mbps) data rates. > > These two phys are combined to form a combo phy. > > > > Add a dedicated compatible string for USB combo SS phy found in this > > SoC. The SoC requires two clocks, named "phy" and "ref" and various > > power supplies (regulators) for the internal circuitry to work. > > The required voltages are: > > * avdd075_usb - 0.75v > > * avdd18_usb20 - 1.8v > > * avdd33_usb20 - 3.3v > > One more commitm message completely copy-pasted and completely > uninforming. The voltages are irrelevant. Explain the architecture. This should be > just one patch with proper full description. > > > > > Add schema only for 'USB3.1 SSP+' SS phy in this commit. > > Why only? Add everything, describe everything, but not what voltages you have > there but the architecture of the PHY. > Will combine patch 3 (combo HS phy) & 5(combo SS phy) to describe combo phy and even will add some details as mentioned in cover letter. > Best regards, > Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy