From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3650C433EF for ; Thu, 2 Jun 2022 11:54:14 +0000 (UTC) Received: from localhost ([::1]:51310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwjP3-0004Hp-OG for qemu-devel@archiver.kernel.org; Thu, 02 Jun 2022 07:54:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjKy-0002re-JR; Thu, 02 Jun 2022 07:50:01 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:32794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjKv-0007vs-1u; Thu, 02 Jun 2022 07:49:58 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 252Bg7wu002144; Thu, 2 Jun 2022 11:49:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : reply-to : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=s2P3+uXvKMBEhnk2gAKGLANMCuwQBS9BIwN1SvP+xig=; b=bSaxhe/zCwFrYpnPyGUy4BQsDFsKMEZ08S6/gkaWgztxKIzY8PioHoygwtHWwG06CmhN h6r068Dcqzd7JEr1oO4Fjh4xgVhJoJMGs9Piu+URw4oePHunZYGV5HTnGn4oeCivUH3K xN9JKaMS/8gK7SsGedsWG5nWvQkRwbRPAK2IdZ8tLxXexWAQ2l5H6lqkcVMYsYosYjWi 6OqryQSl8T1vd1AQC2YPNOiSNgdvaWWLRx8uJKSm/VB9iWzyA+WUhGTYaBAtRFsfy2cQ DmHgfhKplA2a/hKkaC7E35UmUU536Uf92YoSPMGCUMI1QJ/W/gVtLof/zsnOkJ76o0I/ fg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gevjbg3ra-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jun 2022 11:49:41 +0000 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 252BkTGU017465; Thu, 2 Jun 2022 11:49:40 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gevjbg3qx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jun 2022 11:49:40 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 252BKc8w020964; Thu, 2 Jun 2022 11:49:39 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma03dal.us.ibm.com with ESMTP id 3gd3ymyjbj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jun 2022 11:49:39 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 252Bnc1A7013274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 Jun 2022 11:49:38 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CCB46AC05E; Thu, 2 Jun 2022 11:49:38 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 44995AC05B; Thu, 2 Jun 2022 11:49:37 +0000 (GMT) Received: from [9.160.111.240] (unknown [9.160.111.240]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTPS; Thu, 2 Jun 2022 11:49:37 +0000 (GMT) Message-ID: <07d70117-6ede-673d-fb5e-422398ee8fd1@linux.ibm.com> Date: Thu, 2 Jun 2022 08:49:35 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.10.0 Subject: Re: [PATCH] target/ppc/cpu-models: Update max alias to power10 Content-Language: en-US To: Thomas Huth , qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Daniel Henrique Barboza , David Gibson , Greg Kurz , mopsfelder@gmail.com, =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , Fabiano Rosas References: <20220531172711.94564-1-muriloo@linux.ibm.com> <475c2f40-8c58-8d51-4cc5-da5b9db814f2@redhat.com> From: =?UTF-8?Q?Murilo_Opsfelder_Ara=c3=bajo?= Organization: IBM In-Reply-To: <475c2f40-8c58-8d51-4cc5-da5b9db814f2@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 1dkrSFIroABCGnfu8Cg2ujppLckK5ebc X-Proofpoint-GUID: zxlrcyc7u4gk1b0Rt4Ry12-LiliDSOV- Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-02_02,2022-06-02_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 bulkscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206020049 Received-SPF: pass client-ip=148.163.156.1; envelope-from=muriloo@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: muriloo@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, Thomas. On 6/1/22 04:27, Thomas Huth wrote: > On 31/05/2022 19.27, Murilo Opsfelder Araujo wrote: >> Update max alias to power10 so users can take advantage of a more >> recent CPU model when '-cpu max' is provided. >> >> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1038 >> Cc: Daniel P. Berrangé >> Cc: Thomas Huth >> Cc: Cédric Le Goater >> Cc: Daniel Henrique Barboza >> Cc: Fabiano Rosas >> Signed-off-by: Murilo Opsfelder Araujo >> --- >> target/ppc/cpu-models.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c >> index 976be5e0d1..c15fcb43a1 100644 >> --- a/target/ppc/cpu-models.c >> +++ b/target/ppc/cpu-models.c >> @@ -879,7 +879,6 @@ PowerPCCPUAlias ppc_cpu_aliases[] = { >> { "755", "755_v2.8" }, >> { "goldfinger", "755_v2.8" }, >> { "7400", "7400_v2.9" }, >> - { "max", "7400_v2.9" }, >> { "g4", "7400_v2.9" }, >> { "7410", "7410_v1.4" }, >> { "nitro", "7410_v1.4" }, >> @@ -910,6 +909,8 @@ PowerPCCPUAlias ppc_cpu_aliases[] = { >> { "power8nvl", "power8nvl_v1.0" }, >> { "power9", "power9_v2.0" }, >> { "power10", "power10_v2.0" }, >> + /* Update the 'max' alias to the latest CPU model */ >> + { "max", "power10_v2.0" }, >> #endif > > I'm not sure whether "max" should really be fixed alias in this list here? What if a user runs with KVM on a POWER8 host - then "max" won't work this way, will it? "-cpu max" as an alias to power10 running with KVM on a P8 host won't work. It's already broken with the current 7400_v2.9, anyway. > And in the long run, it would also be good if this would work with other machines like the "g3beige", too (which don't support the new 64-bit POWER CPUs), so you should at least mention in the commit description that this is only a temporary hack for the pseries machine, I think. I agree. I'll mention that if I end up respining the patch. Thank you! -- Murilo