From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 441B7C4361B for ; Mon, 7 Dec 2020 15:56:04 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 969712388D for ; Mon, 7 Dec 2020 15:56:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 969712388D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DD3504B236; Mon, 7 Dec 2020 10:56:02 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u1F6IeyOTLop; Mon, 7 Dec 2020 10:56:01 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B3D4D4B260; Mon, 7 Dec 2020 10:56:01 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C18604B25B for ; Mon, 7 Dec 2020 10:56:00 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0hYO--KMjHmE for ; Mon, 7 Dec 2020 10:55:59 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9A2F84B236 for ; Mon, 7 Dec 2020 10:55:59 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6113423741; Mon, 7 Dec 2020 15:55:58 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kmIrk-00Gnm0-3l; Mon, 07 Dec 2020 15:55:56 +0000 MIME-Version: 1.0 Date: Mon, 07 Dec 2020 15:55:56 +0000 From: Marc Zyngier To: Steven Price Subject: Re: [PATCH v6 1/2] arm64: kvm: Save/restore MTE registers In-Reply-To: <03566358-21b0-11d9-c4f6-d07d137a1009@arm.com> References: <20201127152113.13099-1-steven.price@arm.com> <20201127152113.13099-2-steven.price@arm.com> <946b1e7b06c4d286a78cf61408e0fc8d@kernel.org> <03566358-21b0-11d9-c4f6-d07d137a1009@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <07e40bbcf734e8c63630168406262bb2@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: steven.price@arm.com, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave.Martin@arm.com, mark.rutland@arm.com, tglx@linutronix.de, qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, richard.henderson@linaro.org, peter.maydell@linaro.org, Haibo.Xu@arm.com, drjones@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Catalin Marinas , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMC0xMi0wNyAxNDo0OCwgU3RldmVuIFByaWNlIHdyb3RlOgo+IE9uIDAzLzEyLzIwMjAg MTc6MDcsIE1hcmMgWnluZ2llciB3cm90ZToKPj4gCj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02 NC9pbmNsdWRlL2FzbS9zeXNyZWcuaCAKPj4+IGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9zeXNy ZWcuaAo+Pj4gaW5kZXggZTJlZjRjMmVkZjA2Li5iNjY2OGZmYTA0ZDkgMTAwNjQ0Cj4+PiAtLS0g YS9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL3N5c3JlZy5oCj4+PiArKysgYi9hcmNoL2FybTY0L2lu Y2x1ZGUvYXNtL3N5c3JlZy5oCj4+PiBAQCAtNTY5LDcgKzU2OSw4IEBACj4+PiDCoCNkZWZpbmUg U0NUTFJfRUx4X03CoMKgwqAgKEJJVCgwKSkKPj4+IAo+Pj4gwqAjZGVmaW5lIFNDVExSX0VMeF9G TEFHU8KgwqDCoCAoU0NUTFJfRUx4X03CoCB8IFNDVExSX0VMeF9BIHwgU0NUTFJfRUx4X0MgCj4+ PiB8IFwKPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgU0NUTFJfRUx4X1NBIHwgU0NUTFJf RUx4X0kgfCBTQ1RMUl9FTHhfSUVTQikKPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgU0NU TFJfRUx4X1NBIHwgU0NUTFJfRUx4X0kgfCBTQ1RMUl9FTHhfSUVTQiB8IFwKPj4+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgU0NUTFJfRUx4X0lURlNCKQo+Pj4gCj4+PiDCoC8qIFNDVExSX0VM MiBzcGVjaWZpYyBmbGFncy4gKi8KPj4+IMKgI2RlZmluZSBTQ1RMUl9FTDJfUkVTMcKgwqDCoCAo KEJJVCg0KSnCoCB8IChCSVQoNSkpwqAgfCAoQklUKDExKSkgfCAKPj4+IChCSVQoMTYpKSB8IFwK Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9oeXAvaW5jbHVkZS9oeXAvc3lzcmVnLXNy LmgKPj4+IGIvYXJjaC9hcm02NC9rdm0vaHlwL2luY2x1ZGUvaHlwL3N5c3JlZy1zci5oCj4+PiBp bmRleCBjY2U0M2JmZTE1OGYuLjQ1MjU1YmE2MDE1MiAxMDA2NDQKPj4+IC0tLSBhL2FyY2gvYXJt NjQva3ZtL2h5cC9pbmNsdWRlL2h5cC9zeXNyZWctc3IuaAo+Pj4gKysrIGIvYXJjaC9hcm02NC9r dm0vaHlwL2luY2x1ZGUvaHlwL3N5c3JlZy1zci5oCj4+PiBAQCAtMTgsNiArMTgsMTEgQEAKPj4+ IMKgc3RhdGljIGlubGluZSB2b2lkIF9fc3lzcmVnX3NhdmVfY29tbW9uX3N0YXRlKHN0cnVjdCBr dm1fY3B1X2NvbnRleHQgCj4+PiAqY3R4dCkKPj4+IMKgewo+Pj4gwqDCoMKgwqAgY3R4dF9zeXNf cmVnKGN0eHQsIE1EU0NSX0VMMSnCoMKgwqAgPSByZWFkX3N5c3JlZyhtZHNjcl9lbDEpOwo+Pj4g K8KgwqDCoCBpZiAoc3lzdGVtX3N1cHBvcnRzX210ZSgpKSB7Cj4+IAo+PiBQbGVhc2UgbW92ZSB0 aGUgcGVyLVZNIHByZWRpY2F0ZSB0byB0aGlzIHBhdGNoIHNvIHRoYXQgaXQgY2FuIGJlIHVzZWQK Pj4gbm90IHRvIHNhdmUvcmVzdG9yZSB0aGUgTVRFIHJlZ2lzdGVycyBpZiB3ZSBkb24ndCBuZWVk IHRvLgo+IAo+IFRoZXJlIGlzbid0IGEgdmFsaWQgc3RydWN0IGt2bV92Y3B1IG9yIHN0cnVjdCBr dm0gaGVyZS4gSSBrbm93IHRoZXJlJ3MKPiBjdHgtPl9faHlwX3J1bm5pbmdfdmNwdSBidXQgQUZB SUNUIHRoYXQgaXMgb25seSB2YWxpZCB3aXRoIHRoZSBob3N0Cj4gY29udGV4dC4KCldlIGhhdmUg cGVyLUNQVSB2YXJpYWJsZXMgZm9yIHRoZSBob3N0IGNvbnRleHQuIElmIApjdHgtPl9faHlwX3J1 bm5pbmdfdmNwdQppcyBub24gTlVMTCwgeW91IGtub3cgeW91J3JlIG9uIHRoZSBob3N0LgoKCj4g Cj4+IAo+Pj4gK8KgwqDCoMKgwqDCoMKgIGN0eHRfc3lzX3JlZyhjdHh0LCBSR1NSX0VMMSnCoMKg wqAgPSAKPj4+IHJlYWRfc3lzcmVnX3MoU1lTX1JHU1JfRUwxKTsKPj4+ICvCoMKgwqDCoMKgwqDC oCBjdHh0X3N5c19yZWcoY3R4dCwgR0NSX0VMMSnCoMKgwqAgPSByZWFkX3N5c3JlZ19zKFNZU19H Q1JfRUwxKTsKPj4+ICvCoMKgwqDCoMKgwqDCoCBjdHh0X3N5c19yZWcoY3R4dCwgVEZTUkUwX0VM MSnCoMKgwqAgPSAKPj4+IHJlYWRfc3lzcmVnX3MoU1lTX1RGU1JFMF9FTDEpOwo+Pj4gK8KgwqDC oCB9Cj4+IAo+PiBPdmVyYWxsLCBJIHN0aWxsIGRvbid0IHVuZGVyc3RhbmQgaG93IHRoaXMgaXMg Z29pbmcgdG8gd29yayBvbmNlCj4+IHdlIGhhdmUgTVRFIGluIHRoZSBrZXJuZWwuIFlvdSBtZW50 aW9uZWQgaGF2aW5nIHRoZSBhYmlsaXR5IHRvCj4+IGNyZWF0ZSB0dXJuIG9mZiB0aGUgdGFnIGNo ZWNrcyBhdCB0aW1lcywgYnV0IEkgZG9uJ3Qgc2VlIHRoYXQKPj4gaW4gdGhpcyBwYXRjaCAoYW5k IEknbSBub3Qgc3VyZSB3ZSB3YW50IHRoYXQgZWl0aGVyKS4KPiAKPiBHaXZlbiB0aGF0IHRoaXMg aXMgbm93IGhpZ2hseSB1bmxpa2VseSB0byBiZSBtZXJnZWQgZm9yIHY1LjExLCBJJ2xsCj4gcmVi YXNlIG9udG8gb2YgdGhlIEtBU0FOIE1URSBzZXJpZXMgYW5kIGRvdWJsZSBjaGVjayBleGFjdGx5 IHdoYXQKPiBoYXBwZW5zLiBNeSB0aG91Z2h0IHdhcyB0aGF0IGl0IHNob3VsZCBiZSBhcyBzaW1w bGUgYXMgc2V0dGluZyBUQ08sCj4gYnV0IHlvdXIgcHJldmlvdXMgY29tbWVudCBhYm91dCBtb3Zp bmcgdGhlIHNhdmUvcmVzdG9yZSBpbnRvIGFzc2VtYmxlcgo+IG1pZ2h0IGJlIHdpc2UgaW4gY2Fz ZSB0aGUgY29tcGlsZXIgc3RhcnRzIHBsYXlpbmcgd2l0aCBUQ08gaXRzZWxmLgoKSW5kZWVkLgoK VGhhbmtzLAoKICAgICAgICAgTS4KLS0gCkphenogaXMgbm90IGRlYWQuIEl0IGp1c3Qgc21lbGxz IGZ1bm55Li4uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cmt2bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczov L2xpc3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C743C4361B for ; Mon, 7 Dec 2020 15:57:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 916DB23731 for ; Mon, 7 Dec 2020 15:57:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 916DB23731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hNLPigU6ybyt/3BJERpSVvMo3KT+odYkff9+KDsOpdw=; b=RfNQHEx808IR9VzN/2GRjI9mM EmwMMP2WIz2BlcGtXZERVvQJ9g87s45Jk0ORRPiprmgapTkHKCkzQqt7LnzJ3iEShP31cOjjmWgfg FqHKY5b23z1JMsmaCWneWNqfYkizhRQkEN9v/EOAXA6PqIeiWxls0nwmJA6cu6Kp7XZmfzxd/Sc36 raIGodT9g9D6AUlaDuxuGuf6MwoDncvq/Qs7qHdPl61kxIxzptkmH5VDD7M+lLrSFxW019/8e6sv3 uFgANk89z2/SENNW9slwrHUsvldz6NcdVGDiGt98HSiF/xeCnZv7U5fnK1wScp8Hg9oKVno38RUyi zMzRUp0Jw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmIrq-0004Sm-Ln; Mon, 07 Dec 2020 15:56:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmIrn-0004Rp-F1 for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2020 15:56:00 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6113423741; Mon, 7 Dec 2020 15:55:58 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kmIrk-00Gnm0-3l; Mon, 07 Dec 2020 15:55:56 +0000 MIME-Version: 1.0 Date: Mon, 07 Dec 2020 15:55:56 +0000 From: Marc Zyngier To: Steven Price Subject: Re: [PATCH v6 1/2] arm64: kvm: Save/restore MTE registers In-Reply-To: <03566358-21b0-11d9-c4f6-d07d137a1009@arm.com> References: <20201127152113.13099-1-steven.price@arm.com> <20201127152113.13099-2-steven.price@arm.com> <946b1e7b06c4d286a78cf61408e0fc8d@kernel.org> <03566358-21b0-11d9-c4f6-d07d137a1009@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <07e40bbcf734e8c63630168406262bb2@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: steven.price@arm.com, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave.Martin@arm.com, mark.rutland@arm.com, tglx@linutronix.de, qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, richard.henderson@linaro.org, peter.maydell@linaro.org, Haibo.Xu@arm.com, drjones@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_105559_692689_5E7EBABB X-CRM114-Status: GOOD ( 22.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , "Dr. David Alan Gilbert" , Andrew Jones , Haibo Xu , Suzuki K Poulose , qemu-devel@nongnu.org, Catalin Marinas , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0xMi0wNyAxNDo0OCwgU3RldmVuIFByaWNlIHdyb3RlOgo+IE9uIDAzLzEyLzIwMjAg MTc6MDcsIE1hcmMgWnluZ2llciB3cm90ZToKPj4gCj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02 NC9pbmNsdWRlL2FzbS9zeXNyZWcuaCAKPj4+IGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9zeXNy ZWcuaAo+Pj4gaW5kZXggZTJlZjRjMmVkZjA2Li5iNjY2OGZmYTA0ZDkgMTAwNjQ0Cj4+PiAtLS0g YS9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL3N5c3JlZy5oCj4+PiArKysgYi9hcmNoL2FybTY0L2lu Y2x1ZGUvYXNtL3N5c3JlZy5oCj4+PiBAQCAtNTY5LDcgKzU2OSw4IEBACj4+PiDCoCNkZWZpbmUg U0NUTFJfRUx4X03CoMKgwqAgKEJJVCgwKSkKPj4+IAo+Pj4gwqAjZGVmaW5lIFNDVExSX0VMeF9G TEFHU8KgwqDCoCAoU0NUTFJfRUx4X03CoCB8IFNDVExSX0VMeF9BIHwgU0NUTFJfRUx4X0MgCj4+ PiB8IFwKPj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgU0NUTFJfRUx4X1NBIHwgU0NUTFJf RUx4X0kgfCBTQ1RMUl9FTHhfSUVTQikKPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgU0NU TFJfRUx4X1NBIHwgU0NUTFJfRUx4X0kgfCBTQ1RMUl9FTHhfSUVTQiB8IFwKPj4+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgU0NUTFJfRUx4X0lURlNCKQo+Pj4gCj4+PiDCoC8qIFNDVExSX0VM MiBzcGVjaWZpYyBmbGFncy4gKi8KPj4+IMKgI2RlZmluZSBTQ1RMUl9FTDJfUkVTMcKgwqDCoCAo KEJJVCg0KSnCoCB8IChCSVQoNSkpwqAgfCAoQklUKDExKSkgfCAKPj4+IChCSVQoMTYpKSB8IFwK Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2t2bS9oeXAvaW5jbHVkZS9oeXAvc3lzcmVnLXNy LmgKPj4+IGIvYXJjaC9hcm02NC9rdm0vaHlwL2luY2x1ZGUvaHlwL3N5c3JlZy1zci5oCj4+PiBp bmRleCBjY2U0M2JmZTE1OGYuLjQ1MjU1YmE2MDE1MiAxMDA2NDQKPj4+IC0tLSBhL2FyY2gvYXJt NjQva3ZtL2h5cC9pbmNsdWRlL2h5cC9zeXNyZWctc3IuaAo+Pj4gKysrIGIvYXJjaC9hcm02NC9r dm0vaHlwL2luY2x1ZGUvaHlwL3N5c3JlZy1zci5oCj4+PiBAQCAtMTgsNiArMTgsMTEgQEAKPj4+ IMKgc3RhdGljIGlubGluZSB2b2lkIF9fc3lzcmVnX3NhdmVfY29tbW9uX3N0YXRlKHN0cnVjdCBr dm1fY3B1X2NvbnRleHQgCj4+PiAqY3R4dCkKPj4+IMKgewo+Pj4gwqDCoMKgwqAgY3R4dF9zeXNf cmVnKGN0eHQsIE1EU0NSX0VMMSnCoMKgwqAgPSByZWFkX3N5c3JlZyhtZHNjcl9lbDEpOwo+Pj4g K8KgwqDCoCBpZiAoc3lzdGVtX3N1cHBvcnRzX210ZSgpKSB7Cj4+IAo+PiBQbGVhc2UgbW92ZSB0 aGUgcGVyLVZNIHByZWRpY2F0ZSB0byB0aGlzIHBhdGNoIHNvIHRoYXQgaXQgY2FuIGJlIHVzZWQK Pj4gbm90IHRvIHNhdmUvcmVzdG9yZSB0aGUgTVRFIHJlZ2lzdGVycyBpZiB3ZSBkb24ndCBuZWVk IHRvLgo+IAo+IFRoZXJlIGlzbid0IGEgdmFsaWQgc3RydWN0IGt2bV92Y3B1IG9yIHN0cnVjdCBr dm0gaGVyZS4gSSBrbm93IHRoZXJlJ3MKPiBjdHgtPl9faHlwX3J1bm5pbmdfdmNwdSBidXQgQUZB SUNUIHRoYXQgaXMgb25seSB2YWxpZCB3aXRoIHRoZSBob3N0Cj4gY29udGV4dC4KCldlIGhhdmUg cGVyLUNQVSB2YXJpYWJsZXMgZm9yIHRoZSBob3N0IGNvbnRleHQuIElmIApjdHgtPl9faHlwX3J1 bm5pbmdfdmNwdQppcyBub24gTlVMTCwgeW91IGtub3cgeW91J3JlIG9uIHRoZSBob3N0LgoKCj4g Cj4+IAo+Pj4gK8KgwqDCoMKgwqDCoMKgIGN0eHRfc3lzX3JlZyhjdHh0LCBSR1NSX0VMMSnCoMKg wqAgPSAKPj4+IHJlYWRfc3lzcmVnX3MoU1lTX1JHU1JfRUwxKTsKPj4+ICvCoMKgwqDCoMKgwqDC oCBjdHh0X3N5c19yZWcoY3R4dCwgR0NSX0VMMSnCoMKgwqAgPSByZWFkX3N5c3JlZ19zKFNZU19H Q1JfRUwxKTsKPj4+ICvCoMKgwqDCoMKgwqDCoCBjdHh0X3N5c19yZWcoY3R4dCwgVEZTUkUwX0VM MSnCoMKgwqAgPSAKPj4+IHJlYWRfc3lzcmVnX3MoU1lTX1RGU1JFMF9FTDEpOwo+Pj4gK8KgwqDC oCB9Cj4+IAo+PiBPdmVyYWxsLCBJIHN0aWxsIGRvbid0IHVuZGVyc3RhbmQgaG93IHRoaXMgaXMg Z29pbmcgdG8gd29yayBvbmNlCj4+IHdlIGhhdmUgTVRFIGluIHRoZSBrZXJuZWwuIFlvdSBtZW50 aW9uZWQgaGF2aW5nIHRoZSBhYmlsaXR5IHRvCj4+IGNyZWF0ZSB0dXJuIG9mZiB0aGUgdGFnIGNo ZWNrcyBhdCB0aW1lcywgYnV0IEkgZG9uJ3Qgc2VlIHRoYXQKPj4gaW4gdGhpcyBwYXRjaCAoYW5k IEknbSBub3Qgc3VyZSB3ZSB3YW50IHRoYXQgZWl0aGVyKS4KPiAKPiBHaXZlbiB0aGF0IHRoaXMg aXMgbm93IGhpZ2hseSB1bmxpa2VseSB0byBiZSBtZXJnZWQgZm9yIHY1LjExLCBJJ2xsCj4gcmVi YXNlIG9udG8gb2YgdGhlIEtBU0FOIE1URSBzZXJpZXMgYW5kIGRvdWJsZSBjaGVjayBleGFjdGx5 IHdoYXQKPiBoYXBwZW5zLiBNeSB0aG91Z2h0IHdhcyB0aGF0IGl0IHNob3VsZCBiZSBhcyBzaW1w bGUgYXMgc2V0dGluZyBUQ08sCj4gYnV0IHlvdXIgcHJldmlvdXMgY29tbWVudCBhYm91dCBtb3Zp bmcgdGhlIHNhdmUvcmVzdG9yZSBpbnRvIGFzc2VtYmxlcgo+IG1pZ2h0IGJlIHdpc2UgaW4gY2Fz ZSB0aGUgY29tcGlsZXIgc3RhcnRzIHBsYXlpbmcgd2l0aCBUQ08gaXRzZWxmLgoKSW5kZWVkLgoK VGhhbmtzLAoKICAgICAgICAgTS4KLS0gCkphenogaXMgbm90IGRlYWQuIEl0IGp1c3Qgc21lbGxz IGZ1bm55Li4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14D53C433FE for ; Mon, 7 Dec 2020 15:56:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8D8823731 for ; Mon, 7 Dec 2020 15:56:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727264AbgLGP4k (ORCPT ); Mon, 7 Dec 2020 10:56:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:47182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbgLGP4j (ORCPT ); Mon, 7 Dec 2020 10:56:39 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6113423741; Mon, 7 Dec 2020 15:55:58 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kmIrk-00Gnm0-3l; Mon, 07 Dec 2020 15:55:56 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 07 Dec 2020 15:55:56 +0000 From: Marc Zyngier To: Steven Price Cc: Catalin Marinas , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones Subject: Re: [PATCH v6 1/2] arm64: kvm: Save/restore MTE registers In-Reply-To: <03566358-21b0-11d9-c4f6-d07d137a1009@arm.com> References: <20201127152113.13099-1-steven.price@arm.com> <20201127152113.13099-2-steven.price@arm.com> <946b1e7b06c4d286a78cf61408e0fc8d@kernel.org> <03566358-21b0-11d9-c4f6-d07d137a1009@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <07e40bbcf734e8c63630168406262bb2@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: steven.price@arm.com, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave.Martin@arm.com, mark.rutland@arm.com, tglx@linutronix.de, qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, richard.henderson@linaro.org, peter.maydell@linaro.org, Haibo.Xu@arm.com, drjones@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-12-07 14:48, Steven Price wrote: > On 03/12/2020 17:07, Marc Zyngier wrote: >> >>> diff --git a/arch/arm64/include/asm/sysreg.h >>> b/arch/arm64/include/asm/sysreg.h >>> index e2ef4c2edf06..b6668ffa04d9 100644 >>> --- a/arch/arm64/include/asm/sysreg.h >>> +++ b/arch/arm64/include/asm/sysreg.h >>> @@ -569,7 +569,8 @@ >>>  #define SCTLR_ELx_M    (BIT(0)) >>> >>>  #define SCTLR_ELx_FLAGS    (SCTLR_ELx_M  | SCTLR_ELx_A | SCTLR_ELx_C >>> | \ >>> -             SCTLR_ELx_SA | SCTLR_ELx_I | SCTLR_ELx_IESB) >>> +             SCTLR_ELx_SA | SCTLR_ELx_I | SCTLR_ELx_IESB | \ >>> +             SCTLR_ELx_ITFSB) >>> >>>  /* SCTLR_EL2 specific flags. */ >>>  #define SCTLR_EL2_RES1    ((BIT(4))  | (BIT(5))  | (BIT(11)) | >>> (BIT(16)) | \ >>> diff --git a/arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h >>> b/arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h >>> index cce43bfe158f..45255ba60152 100644 >>> --- a/arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h >>> +++ b/arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h >>> @@ -18,6 +18,11 @@ >>>  static inline void __sysreg_save_common_state(struct kvm_cpu_context >>> *ctxt) >>>  { >>>      ctxt_sys_reg(ctxt, MDSCR_EL1)    = read_sysreg(mdscr_el1); >>> +    if (system_supports_mte()) { >> >> Please move the per-VM predicate to this patch so that it can be used >> not to save/restore the MTE registers if we don't need to. > > There isn't a valid struct kvm_vcpu or struct kvm here. I know there's > ctx->__hyp_running_vcpu but AFAICT that is only valid with the host > context. We have per-CPU variables for the host context. If ctx->__hyp_running_vcpu is non NULL, you know you're on the host. > >> >>> +        ctxt_sys_reg(ctxt, RGSR_EL1)    = >>> read_sysreg_s(SYS_RGSR_EL1); >>> +        ctxt_sys_reg(ctxt, GCR_EL1)    = read_sysreg_s(SYS_GCR_EL1); >>> +        ctxt_sys_reg(ctxt, TFSRE0_EL1)    = >>> read_sysreg_s(SYS_TFSRE0_EL1); >>> +    } >> >> Overall, I still don't understand how this is going to work once >> we have MTE in the kernel. You mentioned having the ability to >> create turn off the tag checks at times, but I don't see that >> in this patch (and I'm not sure we want that either). > > Given that this is now highly unlikely to be merged for v5.11, I'll > rebase onto of the KASAN MTE series and double check exactly what > happens. My thought was that it should be as simple as setting TCO, > but your previous comment about moving the save/restore into assembler > might be wise in case the compiler starts playing with TCO itself. Indeed. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D4EC433FE for ; Mon, 7 Dec 2020 15:58:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86F7723731 for ; Mon, 7 Dec 2020 15:58:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86F7723731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmItv-00077U-RE for qemu-devel@archiver.kernel.org; Mon, 07 Dec 2020 10:58:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmIrw-00061Q-Th for qemu-devel@nongnu.org; Mon, 07 Dec 2020 10:56:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:46224) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmIrt-0006u7-MK for qemu-devel@nongnu.org; Mon, 07 Dec 2020 10:56:08 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6113423741; Mon, 7 Dec 2020 15:55:58 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kmIrk-00Gnm0-3l; Mon, 07 Dec 2020 15:55:56 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 07 Dec 2020 15:55:56 +0000 From: Marc Zyngier To: Steven Price Subject: Re: [PATCH v6 1/2] arm64: kvm: Save/restore MTE registers In-Reply-To: <03566358-21b0-11d9-c4f6-d07d137a1009@arm.com> References: <20201127152113.13099-1-steven.price@arm.com> <20201127152113.13099-2-steven.price@arm.com> <946b1e7b06c4d286a78cf61408e0fc8d@kernel.org> <03566358-21b0-11d9-c4f6-d07d137a1009@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <07e40bbcf734e8c63630168406262bb2@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: steven.price@arm.com, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave.Martin@arm.com, mark.rutland@arm.com, tglx@linutronix.de, qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, richard.henderson@linaro.org, peter.maydell@linaro.org, Haibo.Xu@arm.com, drjones@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Received-SPF: pass client-ip=198.145.29.99; envelope-from=maz@kernel.org; helo=mail.kernel.org X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , "Dr. David Alan Gilbert" , Andrew Jones , Haibo Xu , Suzuki K Poulose , qemu-devel@nongnu.org, Catalin Marinas , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020-12-07 14:48, Steven Price wrote: > On 03/12/2020 17:07, Marc Zyngier wrote: >> >>> diff --git a/arch/arm64/include/asm/sysreg.h >>> b/arch/arm64/include/asm/sysreg.h >>> index e2ef4c2edf06..b6668ffa04d9 100644 >>> --- a/arch/arm64/include/asm/sysreg.h >>> +++ b/arch/arm64/include/asm/sysreg.h >>> @@ -569,7 +569,8 @@ >>>  #define SCTLR_ELx_M    (BIT(0)) >>> >>>  #define SCTLR_ELx_FLAGS    (SCTLR_ELx_M  | SCTLR_ELx_A | SCTLR_ELx_C >>> | \ >>> -             SCTLR_ELx_SA | SCTLR_ELx_I | SCTLR_ELx_IESB) >>> +             SCTLR_ELx_SA | SCTLR_ELx_I | SCTLR_ELx_IESB | \ >>> +             SCTLR_ELx_ITFSB) >>> >>>  /* SCTLR_EL2 specific flags. */ >>>  #define SCTLR_EL2_RES1    ((BIT(4))  | (BIT(5))  | (BIT(11)) | >>> (BIT(16)) | \ >>> diff --git a/arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h >>> b/arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h >>> index cce43bfe158f..45255ba60152 100644 >>> --- a/arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h >>> +++ b/arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h >>> @@ -18,6 +18,11 @@ >>>  static inline void __sysreg_save_common_state(struct kvm_cpu_context >>> *ctxt) >>>  { >>>      ctxt_sys_reg(ctxt, MDSCR_EL1)    = read_sysreg(mdscr_el1); >>> +    if (system_supports_mte()) { >> >> Please move the per-VM predicate to this patch so that it can be used >> not to save/restore the MTE registers if we don't need to. > > There isn't a valid struct kvm_vcpu or struct kvm here. I know there's > ctx->__hyp_running_vcpu but AFAICT that is only valid with the host > context. We have per-CPU variables for the host context. If ctx->__hyp_running_vcpu is non NULL, you know you're on the host. > >> >>> +        ctxt_sys_reg(ctxt, RGSR_EL1)    = >>> read_sysreg_s(SYS_RGSR_EL1); >>> +        ctxt_sys_reg(ctxt, GCR_EL1)    = read_sysreg_s(SYS_GCR_EL1); >>> +        ctxt_sys_reg(ctxt, TFSRE0_EL1)    = >>> read_sysreg_s(SYS_TFSRE0_EL1); >>> +    } >> >> Overall, I still don't understand how this is going to work once >> we have MTE in the kernel. You mentioned having the ability to >> create turn off the tag checks at times, but I don't see that >> in this patch (and I'm not sure we want that either). > > Given that this is now highly unlikely to be merged for v5.11, I'll > rebase onto of the KASAN MTE series and double check exactly what > happens. My thought was that it should be as simple as setting TCO, > but your previous comment about moving the save/restore into assembler > might be wise in case the compiler starts playing with TCO itself. Indeed. Thanks, M. -- Jazz is not dead. It just smells funny...