From: Edward Cree <ecree.xilinx@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Joe Damato <jdamato@fastly.com>, Daniel Xu <dxu@dxuuu.xyz>,
davem@davemloft.net, mkubecek@suse.cz, martin.lau@linux.dev,
netdev@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH ethtool-next] rxclass: Make output for RSS context action explicit
Date: Wed, 13 Nov 2024 03:30:05 +0000 [thread overview]
Message-ID: <07e69b19-36c2-ece4-734f-e2189b950cab@gmail.com> (raw)
In-Reply-To: <20241112072434.71dc5236@kernel.org>
On 12/11/2024 15:24, Jakub Kicinski wrote:
> Hm, interesting idea...
> Practically speaking I think it introduces complexity and I'm not sure
> anyone will actually benefit (IOW why would anyone want to keep /
> create context for inactive queues?).
Conceivably to save re-configuring them next time they increase the
queues again? But I suppose anyone doing that kind of complicated
demand-flexible tuning will be using some kind of userland software
that can automate that.
Anyway I don't have a dog in this fight as sfc doesn't support ethtool
set-channels. (Which will make it difficult for me to test this; had
I better extend netdevsim to support RSS & rxnfc?)
> My gut feeling is that we should just leave a comment for posterity
> somewhere in the code but continue to validate both based on rules
> and based on "direct" context membership.
Will do.
next prev parent reply other threads:[~2024-11-13 3:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 19:32 [PATCH ethtool-next] rxclass: Make output for RSS context action explicit Daniel Xu
2024-11-08 19:35 ` Daniel Xu
2024-11-08 19:56 ` Edward Cree
2024-11-08 20:34 ` Joe Damato
2024-11-08 20:43 ` Joe Damato
2024-11-08 21:13 ` Edward Cree
2024-11-08 22:50 ` Daniel Xu
2024-11-09 17:42 ` Jakub Kicinski
2024-11-11 10:47 ` Edward Cree
2024-11-11 18:22 ` Jakub Kicinski
2024-11-12 9:24 ` Edward Cree
2024-11-12 15:24 ` Jakub Kicinski
2024-11-13 3:30 ` Edward Cree [this message]
2024-11-14 0:46 ` Jakub Kicinski
2024-11-14 0:46 ` Jakub Kicinski
2024-11-14 23:04 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07e69b19-36c2-ece4-734f-e2189b950cab@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=dxu@dxuuu.xyz \
--cc=jdamato@fastly.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.