From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Jon Mason" <jon.mason@broadcom.com>,
netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>,
"Jon Mason" <jdmason@kudzu.us>
Subject: Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358
Date: Mon, 27 Feb 2023 10:23:45 -0800 [thread overview]
Message-ID: <07ee8ccb-96c2-eb74-5c8d-65934dc051db@gmail.com> (raw)
In-Reply-To: <20230227091156.19509-1-zajec5@gmail.com>
On 2/27/2023 1:11 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> While bringing hardware up we should perform a full reset including the
> switch bit (BGMAC_BCMA_IOCTL_SW_RESET aka SICF_SWRST). It's what
> specification says and what reference driver does.
>
> This seems to be critical for the BCM5358. Without this hardware doesn't
> get initialized properly and doesn't seem to transmit or receive any
> packets.
>
> Originally bgmac was calling bgmac_chip_reset() before setting
> "has_robosw" property which resulted in expected behaviour. That has
> changed as a side effect of adding platform device support which
> regressed BCM5358 support.
>
> Fixes: f6a95a24957a ("net: ethernet: bgmac: Add platform device support")
> Cc: Jon Mason <jdmason@kudzu.us>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2023-02-27 18:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 9:11 [PATCH net] bgmac: fix *initial* chip reset to support BCM5358 Rafał Miłecki
2023-02-27 9:54 ` Leon Romanovsky
2023-02-27 18:23 ` Florian Fainelli [this message]
2023-02-28 10:30 ` patchwork-bot+netdevbpf
2023-04-04 13:46 ` Ricardo Cañuelo
2023-04-04 13:52 ` Rafał Miłecki
2023-04-05 12:42 ` Florian Fainelli
2023-04-14 14:04 ` Linux regression tracking (Thorsten Leemhuis)
2023-04-14 14:08 ` Ricardo Cañuelo
2023-04-14 14:12 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-04-05 11:16 ` Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07ee8ccb-96c2-eb74-5c8d-65934dc051db@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdmason@kudzu.us \
--cc=jon.mason@broadcom.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.