From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Joel Selvaraj <foss@joelselvaraj.com>
Cc: linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konradybcio@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, Joel Selvaraj <jo@jsfamily.in>,
linux-kernel@vger.kernel.org,
Joel Selvaraj <joelselvaraj.oss@gmail.com>
Subject: Re: [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support
Date: Sat, 26 Oct 2024 12:27:45 +0200 [thread overview]
Message-ID: <07f712be-e30b-40e9-ac64-5fd8a26b145c@oss.qualcomm.com> (raw)
In-Reply-To: <172839929004.1375659.17484732521935836404.robh@kernel.org>
On 8.10.2024 4:56 PM, Rob Herring (Arm) wrote:
>
> On Mon, 07 Oct 2024 21:59:25 -0500, Joel Selvaraj wrote:
>> In the first patch, I have enabled the qupv3_id_1 and gpi_dma1 as they
>> are required for configuring touchscreen. Also added the pinctrl configurations.
>> These are common for both the Poco F1 Tianma and EBBG panel variant.
>>
>> In the subsequent patches, I have enabled support for the Novatek NT36672a
>> touchscreen and FocalTech FT8719 touchscreen that are used in the Poco F1
>> Tianma and EBBG panel variant respectively.
>>
>> Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
>> ---
[...]
> New warnings running 'make CHECK_DTBS=y qcom/sdm845-xiaomi-beryllium-ebbg.dtb qcom/sdm845-xiaomi-beryllium-tianma.dtb' for 20241007-pocof1-touchscreen-support-v1-0-db31b21818c5@joelselvaraj.com:
>
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: touchscreen@38: 'panel' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/input/touchscreen/edt-ft5x06.yaml#
This needs a bindings update
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb: pinctrl@3400000: ts-int-default-state: 'oneOf' conditional failed, one must be fixed:
> 'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
> False schema does not allow True
> from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
I think these warnings are unhappy about input-enable (which is not really a
thing on TLMM, see:
e49eabe3e13f ("pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE")
Konrad
next prev parent reply other threads:[~2024-10-26 10:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 2:59 [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support Joel Selvaraj
2024-10-08 2:59 ` Joel Selvaraj via B4 Relay
2024-10-08 2:59 ` [PATCH 1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes Joel Selvaraj
2024-10-08 2:59 ` Joel Selvaraj via B4 Relay
2024-10-08 2:59 ` [PATCH 2/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support Joel Selvaraj
2024-10-08 2:59 ` Joel Selvaraj via B4 Relay
2024-10-26 10:28 ` Konrad Dybcio
2024-10-08 2:59 ` [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: " Joel Selvaraj
2024-10-08 2:59 ` Joel Selvaraj via B4 Relay
2024-10-26 10:28 ` Konrad Dybcio
2024-10-08 14:56 ` [PATCH 0/3] Add Xiaomi Poco F1 " Rob Herring (Arm)
2024-10-26 10:27 ` Konrad Dybcio [this message]
2025-05-11 23:01 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f712be-e30b-40e9-ac64-5fd8a26b145c@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=foss@joelselvaraj.com \
--cc=jo@jsfamily.in \
--cc=joelselvaraj.oss@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.