From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87085C433EF for ; Thu, 9 Dec 2021 09:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bAxO8Iud/QtxvEzOTfIBdyZIPLiafMEM+BNFoiHiiXc=; b=NM6I5A6UQ/MV+V BtJWJi8O/XoxCHClbjpdN9XP43u7pgY3rEDo+QuyjwFelgXX0TrMd9MgDKL0WzwEq7PBV+QOOk+hr yAC6BY+TWZUa63MM85PA2xPlbuIAC7LBc6cxMNDoXupzDtVwA9G++x4dhcHGNj3PYUaBg0zNiEqPb uH4uUecajiTYRzlKCngw5IBVN2XZyd6h0C7euBVypFG+u0s8BRmesqwv+Ec13FbyPI5g7l6GLWN0v KPe8rhfSeQD6Gz10tj9tI5TnAAr8HAhaCYXlMS2EEbnrqlb5rfQHki4P1uh0GahXeKOqG3v9eFZB0 LQyhD7KPhsk51D5z8HXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvG9P-00FV3O-9X; Thu, 09 Dec 2021 09:55:43 +0000 Received: from mx3.securetransport.de ([116.203.31.6]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvG9L-00FV1y-BX for linux-arm-kernel@lists.infradead.org; Thu, 09 Dec 2021 09:55:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1639043696; bh=D92sG7pqJsQvW5p/anEPdQNU4uUsJV79re/4mVXXBG4=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=Gm47OL16qU2n3jnrT9XPaNrZG73lBTbPwjOXhbARSDSwcQCVrjAEdrbSlQFtof13n fJP6EBkV3nZ/ApQUuyRHW/hRoMMdveTvjgjJsgzivC6KCVlOOmfR+/ffrpNFuGHVik qehaQbDPsmiOGLdNJojkhVmLwsr8oOQAMgoDwbivterxXwgQosATdImn8i78UA5sCm F6XdjIrg3HGITNIaWbfSCw45UBVcihd/vFHND7xvCHh5iCrP0JvejZwI872OeCxL1g qqH/yNBRJfthPVz71KPO66fzEV8JbUyO36AH6tYLFYqAWE08uYkTQut7oApSmZRcOD 4j773PKpYqUSw== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: "Marek MV. Vasut" , "linux-arm-kernel@lists.infradead.org" CC: Shawn Guo , Fabio Estevam , "NXP Linux Team" , kernel Subject: RE: [PATCH] ARM: dts: imx6qdl-dhcom: Add USB overcurrent pin on SoM layer Thread-Topic: [PATCH] ARM: dts: imx6qdl-dhcom: Add USB overcurrent pin on SoM layer Thread-Index: AQHX7EaK1KK+ea/u1U+GNWWVPdOK66wpPJgAgACYmYA= Date: Thu, 9 Dec 2021 09:54:46 +0000 Message-ID: <07f9d418afb34494ad78ed5c903930da@dh-electronics.com> References: <20211208151504.10758-1-cniedermaier@dh-electronics.com> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211209_015539_719025_B51AF175 X-CRM114-Status: GOOD ( 18.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Marek Vasut Sent: Thursday, December 9, 2021 1:23 AM > > On 12/8/21 16:15, Christoph Niedermaier wrote: >> Add USB overcurrent pin muxing on SoM layer, but disable it >> by default. If a board has connected this pin like the >> picoITX, this property should be removed in the board file. >> >> Signed-off-by: Christoph Niedermaier >> Cc: Shawn Guo >> Cc: Fabio Estevam >> Cc: Marek Vasut >> Cc: NXP Linux Team >> Cc: kernel@dh-electronics.com >> To: linux-arm-kernel@lists.infradead.org >> --- >> arch/arm/boot/dts/imx6qdl-dhcom-picoitx.dtsi | 4 ++++ >> arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi | 2 ++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx6qdl-dhcom-picoitx.dtsi b/arch/arm/boot/dts/imx6qdl-dhcom-picoitx.dtsi >> index 4cd4cb9543c8..a67682bfe7bd 100644 >> --- a/arch/arm/boot/dts/imx6qdl-dhcom-picoitx.dtsi >> +++ b/arch/arm/boot/dts/imx6qdl-dhcom-picoitx.dtsi >> @@ -48,6 +48,10 @@ >> "", "", "", "", "", "", "", ""; >> }; >> >> +&usbh1 { /* USB overcurrent pin is connected */ >> + /delete-property/ disable-over-current; >> +}; >> + >> &iomuxc { >> pinctrl-0 = < >> /* >> diff --git a/arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi b/arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi >> index 5d10c40313cb..e4fdce016c34 100644 >> --- a/arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi >> +++ b/arch/arm/boot/dts/imx6qdl-dhcom-som.dtsi >> @@ -385,6 +385,7 @@ >> }; >> >> &usbh1 { >> + disable-over-current; >> dr_mode = "host"; >> pinctrl-0 = <&pinctrl_usbh1>; >> pinctrl-names = "default"; >> @@ -728,6 +729,7 @@ >> pinctrl_usbh1: usbh1-grp { >> fsl,pins = < >> MX6QDL_PAD_EIM_D31__GPIO3_IO31 0x120b0 >> + MX6QDL_PAD_EIM_D30__USB_H1_OC 0x1b0b1 >> >; >> }; > > Shouldn't this be the other way around -- boards with unused USB > overcurrent detection should disable it ? In this case, PDK2 and DRC02 > should add the 'disable-over-current' DT property and pinmux, while > picoitx should add the USB OC pinmux . This pin is defined by the DHCOM standard, therefore no other function can be used on this pin. That is why it should be configured in the SoM file. The first internal version was the other way around, but then we had a discussion about accidentally enabling the overcurrent detection, because it is enabled by default. Since most customers do not use overcurrent detection, we have decided to disable it by default. So if a customer uses that pin, he has to actively remove the DT property as for example shown in the PicoITX board file. In this way, the source of issues should be reduced. Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel