All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jay Cornwall <jay.cornwall@amd.com>
To: Gang Ba <Gang.Ba@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Kent.Russell@amd.com
Subject: Re: [PATCH v2] drm/amdkfd: Fix TCP XNACK scoreboard reset race
Date: Tue, 8 Sep 2026 08:17:13 -0500	[thread overview]
Message-ID: <08079aaa-3dea-4214-a599-67e10f8a7274@amd.com> (raw)
In-Reply-To: <20260903210825.839968-1-Gang.Ba@amd.com>

On 9/3/2026 16:08, Gang Ba wrote:

> @@ -240,6 +254,11 @@ bool kfd_set_dbg_ev_from_interrupt(struct kfd_node *dev,
>   			mutex_unlock(&p->mutex);
>   		} else if (trap_mask & KFD_EC_MASK(EC_DEVICE_MEMORY_VIOLATION)) {
>   			kfd_evict_process_device(pdd);
> +
> +			/* GPR cleaner shader for MI2XX */
> +			if (KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 2))
> +				gfx942_clean_fault(pdd);
> +
>   			kfd_signal_vm_fault_event(pdd, NULL, exception_data);
>   
>   			signaled_to_debugger_or_runtime = true;

This code runs conditionally on:

if (!kfd_dbg_ev_raise(trap_mask, p, dev, doorbell_id, true,
                       exception_data, exception_data_size)) {

It returns true if the process or debugger (I'm unclear on the logic) 
receives the exception. This is not what we want: this code must run 
unconditionally.

      reply	other threads:[~2026-09-08 13:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 21:08 [PATCH v2] drm/amdkfd: Fix TCP XNACK scoreboard reset race Gang Ba
2026-09-08 13:17 ` Jay Cornwall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08079aaa-3dea-4214-a599-67e10f8a7274@amd.com \
    --to=jay.cornwall@amd.com \
    --cc=Gang.Ba@amd.com \
    --cc=Kent.Russell@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.