From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Schofield, Alison" <alison.schofield@intel.com>,
"Weiny, Ira" <ira.weiny@intel.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Subject: Re: [PATCH ndctl RESEND 1/2] ndctl/test: Add destroy region test
Date: Wed, 6 Dec 2023 03:00:21 +0000 [thread overview]
Message-ID: <081a326aaa95d2b5dc355381f1f4c4895767a9c0.camel@intel.com> (raw)
In-Reply-To: <656f948febeb0_182977294ec@iweiny-mobl.notmuch>
On Tue, 2023-12-05 at 13:22 -0800, Ira Weiny wrote:
> Verma, Vishal L wrote:
>
> [snip]
>
> > > >
> > >
> > Correct, the set -e will cause the script to abort with an error exit
> > code whenever a command fails.
> >
> > I do wonder if we need this new test - with Dave's patch here[1],
>
> I'm not sure.
>
> > destroy-region and disable-region both use the same helper that
> > performs the libdaxctl checks.
> >
> > cxl-create-region.sh already has flows that create a region and then
> > destroy it. Those should now cover this case as well yeah?
>
> I thought it would have but I don't think it covers the case where the dax
> device is not system ram (the default when creating a region).
Oh, you're right, the devdax case isn't covered by the other test. I'll
keep this then, thanks!
next prev parent reply other threads:[~2023-12-06 3:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 4:06 [PATCH ndctl RESEND 0/2] ndctl: Fix ups for region destroy Ira Weiny
2023-12-01 4:06 ` [PATCH ndctl RESEND 1/2] ndctl/test: Add destroy region test Ira Weiny
2023-12-01 17:40 ` Dave Jiang
2023-12-01 19:39 ` Alison Schofield
2023-12-04 18:05 ` Ira Weiny
2023-12-04 20:42 ` Verma, Vishal L
2023-12-05 21:22 ` Ira Weiny
2023-12-06 3:00 ` Verma, Vishal L [this message]
2023-12-01 4:06 ` [PATCH ndctl RESEND 2/2] cxl/region: Fix memory device teardown in disable-region Ira Weiny
2023-12-01 17:39 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=081a326aaa95d2b5dc355381f1f4c4895767a9c0.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.